Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/linting #576

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Feat/linting #576

merged 4 commits into from
Aug 16, 2023

Conversation

Leptopoda
Copy link
Member

@Leptopoda Leptopoda commented Aug 16, 2023 •
edited
Loading

fixes: #567

@Leptopoda Leptopoda marked this pull request as ready for review August 16, 2023 14:04
provokateurin
provokateurin requested changes Aug 16, 2023
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a few nit picks

packages/nextcloud/lib/src/api/core.openapi.dart Show resolved Hide resolved
packages/neon_lints/pubspec.yaml Outdated Show resolved Hide resolved
packages/neon_lints/pubspec.yaml Outdated Show resolved Hide resolved
packages/neon_lints/pubspec.yaml Outdated Show resolved Hide resolved
packages/neon_lints/bin/neon_lints.dart Outdated Show resolved Hide resolved
packages/neon_lints/bin/neon_lints.dart Outdated Show resolved Hide resolved
@Leptopoda
feat(neon_lints): add custom linting rules
87fe640 
Signed-off-by: Nikolas Rimikis <rimikis.nikolas@gmail.com>
@Leptopoda
chore(app,dynamite,dynamite_runtime,file_icons,neon,neon_files,neon_n…
a1f2d72 
…ews,neon_notes,neon_notifications,neon_lints,nextcloud,sort_box): use custom neon_lints package

Signed-off-by: Nikolas Rimikis <rimikis.nikolas@gmail.com>
@Leptopoda
fix(dynamite,nextcloud): unnecessary_breaks
70d7cef 
Signed-off-by: Nikolas Rimikis <rimikis.nikolas@gmail.com>
@Leptopoda
fix(dynamite,neon_files,neon_news,neon_lints): fix lints
19b3b92 
Signed-off-by: Nikolas Rimikis <rimikis.nikolas@gmail.com>
@Leptopoda Leptopoda merged commit 88fd6d6 into main Aug 16, 2023
3 checks passed
@Leptopoda Leptopoda deleted the feat/linting branch August 16, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove breaks from switch statements
2 participants
@Leptopoda @provokateurin