Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nextclouds temp dir #493

Merged
merged 2 commits into from Apr 11, 2019
Merged

Use nextclouds temp dir #493

merged 2 commits into from Apr 11, 2019

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Apr 11, 2019

@Grotax Grotax requested a review from SMillerDev April 11, 2019 08:48
@SMillerDev SMillerDev requested a review from kesselb April 11, 2019 09:21
SMillerDev
SMillerDev reviewed Apr 11, 2019
View reviewed changes
Copy link
Contributor

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but I really have no idea.

@Grotax
Copy link
Member Author

Grotax commented Apr 11, 2019

I did test it on my local machine and it seems to work fine:
if no dir is defined -> /tmp
if a dir "/tmp/nextcloudtemp" is defined and exists -> /tmp/nextcloudtemp
if defined but not existing -> /tmp
files are named url$hash

@SMillerDev
Copy link
Contributor

If @kesselb doesn't respond I'll approve it, but I think the person who pointed out the problem would be uniquely qualified to review the fix.

kesselb
kesselb approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

lib/AppInfo/Application.php Outdated Show resolved Hide resolved
@Grotax Grotax merged commit 6410d92 into master Apr 11, 2019
@SMillerDev
Copy link
Contributor

Still looks fine to me

@Grotax Grotax deleted the Grotax-Patch-1 branch April 11, 2019 10:59
nachoparker added a commit to nachoparker/news that referenced this pull request May 11, 2019
@nachoparker
Merge remote-tracking branch 'origin/master' into css-tweak-tablet-sc…
e2bda14 
…reen

* origin/master: (32 commits)
  prevent menu actions from collapsing sidebar (nextcloud#504)
  add "mark read" floating button mobile. Fixes nextcloud#469 (nextcloud#505)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  update js dependencies (nextcloud#500)
  [tx-robot] updated from transifex
  removed warning about non utf8mb4 charset for mysql/mariadb - nextcloud#496 (nextcloud#497)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  Update feed-io: adds UT timezone (nextcloud#495)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  Release 13.1.6 (nextcloud#490)
  Use nextclouds temp dir (nextcloud#493)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  UI: Make BasicAuth Credentials less important in subscribtion form
  Set tmp dir as cache for favicon
  embed codecov status
  remove coverage from integration run, upload to codecov
  ...

Signed-off-by: nachoparker <nacho@ownyourbits.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev left review comments

@kesselb kesselb kesselb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Grotax @SMillerDev @kesselb