Remove UTF-8 charset warning from news #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ud#496 Signed-off-by: Daniel Opitz <git@copynpaste.de>
danopz
force-pushed
the
remove-utf8-warning
branch
from
909d91d
to
c24cc00
Compare
|
Unused translations are probably automatically removed :) I think we can simply keep the api flag. |
SMillerDev
approved these changes
Apr 25, 2019
nachoparker
added a commit
to nachoparker/news
that referenced
this pull request
May 11, 2019
…reen * origin/master: (32 commits) prevent menu actions from collapsing sidebar (nextcloud#504) add "mark read" floating button mobile. Fixes nextcloud#469 (nextcloud#505) [tx-robot] updated from transifex [tx-robot] updated from transifex update js dependencies (nextcloud#500) [tx-robot] updated from transifex removed warning about non utf8mb4 charset for mysql/mariadb - nextcloud#496 (nextcloud#497) [tx-robot] updated from transifex [tx-robot] updated from transifex Update feed-io: adds UT timezone (nextcloud#495) [tx-robot] updated from transifex [tx-robot] updated from transifex Release 13.1.6 (nextcloud#490) Use nextclouds temp dir (nextcloud#493) [tx-robot] updated from transifex [tx-robot] updated from transifex UI: Make BasicAuth Credentials less important in subscribtion form Set tmp dir as cache for favicon embed codecov status remove coverage from integration run, upload to codecov ... Signed-off-by: nachoparker <nacho@ownyourbits.com>
|
This hasn't been released yet, right? At least it still there in my updated NC16.x instance. Will it cause any problems, if I remove the part manually? |
Grotax
added a commit
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #496 first I just removed the notification from the frontend. How are the translations removed - have I to remove them or is Transifex removing unused translations?
We still have an API request returning a flag for this. For BC we are not able to remove this flag, but I'm not sure if we should just keep it or return false in every case and update the documentation?