Bump phpunit/phpunit from 9.2.6 to 9.4.0 #818
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/composer/phpunit/phpunit-9.4.0
branch
from
4f47399
to
214f68e
Compare
|
Not only will the configuration need a migration but also |
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/composer/phpunit/phpunit-9.4.0
branch
from
214f68e
to
1d1aac7
Compare
|
No Idea why phpuint fails, on my local machine after migration everything worked fine except code coverage as thats not configured on my machine |
|
Guess it's a code coverage issue then since it also fails for me. |
Grotax
force-pushed
the
dependabot/composer/phpunit/phpunit-9.4.0
branch
from
e64306a
to
09739b6
Compare
|
Yea i installed and enabled xDebug and got the same error, but I can't make any sense from that error |
|
A newer version of phpunit/phpunit exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Grotax
force-pushed
the
dependabot/composer/phpunit/phpunit-9.4.0
branch
2 times, most recently
from
b20e99b
to
d68d19f
Compare
|
I also searched on google quite heavily but apparently no one has had that error, it is also so weird like the line that errors comes from a phpunit plugin but apparently as soon as we upgrade to 9.4.0 it breaks. |
|
I think it's a nextcloud specific issue. Maybe @kesselb knows something or someone? |
|
No idea sorry 🤷♂️ |
Grotax
force-pushed
the
dependabot/composer/phpunit/phpunit-9.4.0
branch
2 times, most recently
from
44731d1
to
9dc057a
Compare
|
Now that the server setup works with PHP 8, the integration test then stops while testing the PHP dependencies, since PHP 8 is only supported from at least phpunit 9.3. (Which would be solved with this PR here.) |
|
Do we need to switch to NC 21 as base? |
|
I don't think that this is currently necessary. The integration tests work for NC 20 and NC master (21) and the app works fine on my NC 21 beta4. And this phpunit bump would probably work also with NC 20. |
Grotax
force-pushed
the
dependabot/composer/phpunit/phpunit-9.4.0
branch
from
9dc057a
to
b327908
Compare
|
Every time I re based this commit I tried to get help from google regarding this but apparently no one ever had this issue and posted about it :( |
|
What if you run it against master as a test? |
|
I tested this against nextcloud/master, no error apart from a unit test error. |
|
Already if we test against the v21.0.0beta4 the tests run through, only a new error pops up in one of our unit tests. So I guess we could drop testing 20 and switch to 21 after the release? |
|
Yeah, we can run the unittests on 21 then. And we'll only keep the integration tests for 20. |
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 9.2.6 to 9.4.0. - [Release notes](https://github.com/sebastianbergmann/phpunit/releases) - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-9.4.md) - [Commits](sebastianbergmann/phpunit@9.2.6...9.4.0) Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax
force-pushed
the
dependabot/composer/phpunit/phpunit-9.4.0
branch
from
b327908
to
64ea76d
Compare
delete-merged-branch
bot
deleted the
dependabot/composer/phpunit/phpunit-9.4.0
branch
Bumps phpunit/phpunit from 9.2.6 to 9.4.0.
Changelog
Sourced from phpunit/phpunit's changelog.
Commits
ef53346Prepare release6099c5eReport an error instead of a failure when the prerequisites for using the cus...6f084faMerge branch '9.3'b1f4768Merge branch '8.5' into 9.3684ef7bAlso mention output904b6e7Merge branch '9.3'b03b938Merge branch '8.5' into 9.3155e5b0Motivated by #4471, do not even try to add non-public methods as test methodsc9f25eeMerge branch '9.3'b77f2daUpdate ChangeLogDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)