Make PHPstan stricter #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
force-pushed
the
phpstan_stricter
branch
from
b36fa02
to
372d0c0
Compare
anoymouserver
approved these changes
Nov 20, 2020
|
Well .. the checks probably still need to be fixed. |
SMillerDev
force-pushed
the
phpstan_stricter
branch
3 times, most recently
from
ddef59e
to
7300d0a
Compare
SMillerDev
force-pushed
the
phpstan_stricter
branch
from
7300d0a
to
83ad138
Compare
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
SMillerDev
force-pushed
the
phpstan_stricter
branch
from
83ad138
to
c9612de
Compare
Grotax
approved these changes
Mar 25, 2021
Grotax
added a commit
that referenced
this pull request
Apr 3, 2021
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211)
Merged
Grotax
added a commit
that referenced
this pull request
Apr 3, 2021
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax
added a commit
that referenced
this pull request
Apr 3, 2021
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
Changed - Add BATS as integration tests (nextcloud#1213) - Update FeedFetcher to import categories from feeds (nextcloud#1248) - Update serialization of item to include categories (nextcloud#1248) - Make PHPStan stricter (nextcloud#955) - Search: Add folder search (nextcloud#1215) - Improve test coverage (nextcloud#1263) - Allow directly adding a feed without going through the discovery process (nextcloud#1265) Fixed - Do not show deleted feeds in item list (nextcloud#1214) - Fix update queries (nextcloud#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably doesn't fix anything yet, but it's nice to have the checks