Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB: Updates should use set() #1214

Merged

Conversation

SMillerDev
Copy link
Contributor

Fixes GH-1211

Signed-off-by: Sean Molenaar sean@seanmolenaar.eu

@anoymouserver
Copy link
Contributor

Doesn't seem to work 🙁

Log message
{
    "reqId": "Ii7kLWN2uzuMM8LTtj5n",
    "level": 3,
    "time": "2021-03-02T06:50:37+00:00",
    "remoteAddr": "127.0.0.1",
    "user": "anoymouserver",
    "app": "index",
    "method": "POST",
    "url": "/apps/news/feeds/135/read",
    "message": {
        "Exception": "InvalidArgumentException",
        "Message": "Only strings, Literals and Parameters are allowed",
        "Code": 0,
        "Trace": [{
                "file": "/var/www/cloud/lib/private/DB/QueryBuilder/QueryBuilder.php",
                "line": 740,
                "function": "quoteColumnName",
                "class": "OC\\DB\\QueryBuilder\\QuoteHelper",
                "type": "->",
                "args": [0]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                "line": 167,
                "function": "set",
                "class": "OC\\DB\\QueryBuilder\\QueryBuilder",
                "type": "->",
                "args": ["unread", 0]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                "line": 358,
                "function": "read",
                "class": "OCA\\News\\Db\\FeedMapperV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129155]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                "line": 286,
                "function": "read",
                "class": "OCA\\News\\Service\\FeedServiceV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129155]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 169,
                "function": "read",
                "class": "OCA\\News\\Controller\\FeedController",
                "type": "->",
                "args": [135, 129155]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 100,
                "function": "executeController",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                "line": 152,
                "function": "dispatch",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/Route/Router.php",
                "line": 309,
                "function": "main",
                "class": "OC\\AppFramework\\App",
                "type": "::",
                "args": ["OCA\\News\\Controller\\FeedController", "read", {
                        "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                    }, {
                        "feedId": "135",
                        "_route": "news.feed.read"
                    }
                ]
            }, {
                "file": "/var/www/cloud/lib/base.php",
                "line": 1008,
                "function": "match",
                "class": "OC\\Route\\Router",
                "type": "->",
                "args": ["/apps/news/feeds/135/read"]
            }, {
                "file": "/var/www/cloud/index.php",
                "line": 37,
                "function": "handleRequest",
                "class": "OC",
                "type": "::",
                "args": []
            }
        ],
        "File": "/var/www/cloud/lib/private/DB/QueryBuilder/QuoteHelper.php",
        "Line": 62,
        "CustomMessage": "--"
    },
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0",
    "version": "20.0.7.1",
    "id": "603de052c817d"
}

@SMillerDev
Copy link
Contributor Author

Thanks for testing. I still haven't found a good way to do that with api calls. I know what the remaining issue is now.

@SMillerDev SMillerDev force-pushed the fix/mapper/update_uses_setvalues branch from db796ed to 6d1a0c1 Compare March 2, 2021 09:53
@anoymouserver
Copy link
Contributor

Now the initial error is back.

Log message
{
    "reqId": "cdBBPbI8O6G63ppV42Nn",
    "level": 3,
    "time": "2021-03-02T12:15:32+00:00",
    "remoteAddr": "127.0.0.1",
    "user": "anoymouserver",
    "app": "index",
    "method": "POST",
    "url": "/apps/news/feeds/135/read",
    "message": {
        "Exception": "Doctrine\\DBAL\\Exception\\SyntaxErrorException",
        "Message": "An exception occurred while executing 'UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)':\n\nSQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1",
        "Code": 0,
        "Trace": [{
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 169,
                "function": "convertException",
                "class": "Doctrine\\DBAL\\Driver\\AbstractMySQLDriver",
                "type": "->",
                "args": ["An exception occurred while executing 'UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)':\n\nSQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1", {
                        "errorInfo": ["42000", 1064, "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }
                ]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 149,
                "function": "wrapException",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["42000", 1064, "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "An exception occurred while executing 'UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)':\n\nSQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1"]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                "line": 1071,
                "function": "driverExceptionDuringQuery",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["42000", 1064, "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", []]
            }, {
                "file": "/var/www/cloud/lib/private/DB/Connection.php",
                "line": 222,
                "function": "executeUpdate",
                "class": "Doctrine\\DBAL\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", [], []]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                "line": 179,
                "function": "executeUpdate",
                "class": "OC\\DB\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                "line": 358,
                "function": "read",
                "class": "OCA\\News\\Db\\FeedMapperV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129155]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                "line": 286,
                "function": "read",
                "class": "OCA\\News\\Service\\FeedServiceV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129155]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 169,
                "function": "read",
                "class": "OCA\\News\\Controller\\FeedController",
                "type": "->",
                "args": [135, 129155]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 100,
                "function": "executeController",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                "line": 152,
                "function": "dispatch",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/Route/Router.php",
                "line": 309,
                "function": "main",
                "class": "OC\\AppFramework\\App",
                "type": "::",
                "args": ["OCA\\News\\Controller\\FeedController", "read", {
                        "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                    }, {
                        "feedId": "135",
                        "_route": "news.feed.read"
                    }
                ]
            }, {
                "file": "/var/www/cloud/lib/base.php",
                "line": 1008,
                "function": "match",
                "class": "OC\\Route\\Router",
                "type": "->",
                "args": ["/apps/news/feeds/135/read"]
            }, {
                "file": "/var/www/cloud/index.php",
                "line": 37,
                "function": "handleRequest",
                "class": "OC",
                "type": "::",
                "args": []
            }
        ],
        "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php",
        "Line": 79,
        "Previous": {
            "Exception": "Doctrine\\DBAL\\Driver\\PDOException",
            "Message": "SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1",
            "Code": "42000",
            "Trace": [{
                    "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                    "line": 1068,
                    "function": "exec",
                    "class": "Doctrine\\DBAL\\Driver\\PDOConnection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                }, {
                    "file": "/var/www/cloud/lib/private/DB/Connection.php",
                    "line": 222,
                    "function": "executeUpdate",
                    "class": "Doctrine\\DBAL\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", [], []]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                    "line": 179,
                    "function": "executeUpdate",
                    "class": "OC\\DB\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                    "line": 358,
                    "function": "read",
                    "class": "OCA\\News\\Db\\FeedMapperV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 129155]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                    "line": 286,
                    "function": "read",
                    "class": "OCA\\News\\Service\\FeedServiceV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 129155]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 169,
                    "function": "read",
                    "class": "OCA\\News\\Controller\\FeedController",
                    "type": "->",
                    "args": [135, 129155]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 100,
                    "function": "executeController",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                    "line": 152,
                    "function": "dispatch",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/Route/Router.php",
                    "line": 309,
                    "function": "main",
                    "class": "OC\\AppFramework\\App",
                    "type": "::",
                    "args": ["OCA\\News\\Controller\\FeedController", "read", {
                            "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                        }, {
                            "feedId": "135",
                            "_route": "news.feed.read"
                        }
                    ]
                }, {
                    "file": "/var/www/cloud/lib/base.php",
                    "line": 1008,
                    "function": "match",
                    "class": "OC\\Route\\Router",
                    "type": "->",
                    "args": ["/apps/news/feeds/135/read"]
                }, {
                    "file": "/var/www/cloud/index.php",
                    "line": 37,
                    "function": "handleRequest",
                    "class": "OC",
                    "type": "::",
                    "args": []
                }
            ],
            "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php",
            "Line": 43,
            "Previous": {
                "Exception": "PDOException",
                "Message": "SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1",
                "Code": "42000",
                "Trace": [{
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php",
                        "line": 41,
                        "function": "exec",
                        "class": "PDO",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                    }, {
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                        "line": 1068,
                        "function": "exec",
                        "class": "Doctrine\\DBAL\\Driver\\PDOConnection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                    }, {
                        "file": "/var/www/cloud/lib/private/DB/Connection.php",
                        "line": 222,
                        "function": "executeUpdate",
                        "class": "Doctrine\\DBAL\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", [], []]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                        "line": 179,
                        "function": "executeUpdate",
                        "class": "OC\\DB\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = `:unread` WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                        "line": 358,
                        "function": "read",
                        "class": "OCA\\News\\Db\\FeedMapperV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 129155]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                        "line": 286,
                        "function": "read",
                        "class": "OCA\\News\\Service\\FeedServiceV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 129155]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 169,
                        "function": "read",
                        "class": "OCA\\News\\Controller\\FeedController",
                        "type": "->",
                        "args": [135, 129155]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 100,
                        "function": "executeController",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                        "line": 152,
                        "function": "dispatch",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/Route/Router.php",
                        "line": 309,
                        "function": "main",
                        "class": "OC\\AppFramework\\App",
                        "type": "::",
                        "args": ["OCA\\News\\Controller\\FeedController", "read", {
                                "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                            }, {
                                "feedId": "135",
                                "_route": "news.feed.read"
                            }
                        ]
                    }, {
                        "file": "/var/www/cloud/lib/base.php",
                        "line": 1008,
                        "function": "match",
                        "class": "OC\\Route\\Router",
                        "type": "->",
                        "args": ["/apps/news/feeds/135/read"]
                    }, {
                        "file": "/var/www/cloud/index.php",
                        "line": 37,
                        "function": "handleRequest",
                        "class": "OC",
                        "type": "::",
                        "args": []
                    }
                ],
                "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php",
                "Line": 41
            }
        },
        "CustomMessage": "--"
    },
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0",
    "version": "20.0.8.1",
    "id": "603e2c6ee3e65"
}

@SMillerDev
Copy link
Contributor Author

Stupid Doctorine parameters not being the same as setParameter usage.

@SMillerDev SMillerDev force-pushed the fix/mapper/update_uses_setvalues branch from 6d1a0c1 to 782aedb Compare March 2, 2021 20:09
@SMillerDev
Copy link
Contributor Author

Okay, maybe this version 😅

@codecov-io
Copy link

codecov-io commented Mar 2, 2021

Codecov Report

Merging #1214 (0efa751) into master (2baa7a2) will decrease coverage by 1.92%.
The diff coverage is 45.29%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1214      +/-   ##
============================================
- Coverage     87.25%   85.33%   -1.93%     
- Complexity      701      718      +17     
============================================
  Files            60       63       +3     
  Lines          2519     2604      +85     
============================================
+ Hits           2198     2222      +24     
- Misses          321      382      +61     
Impacted Files Coverage Δ Complexity Δ
lib/Command/Debug/FeedRead.php 0.00% <0.00%> (ø) 5.00 <5.00> (?)
lib/Command/Debug/FolderRead.php 0.00% <0.00%> (ø) 5.00 <5.00> (?)
lib/Command/Debug/ItemRead.php 0.00% <0.00%> (ø) 7.00 <7.00> (?)
lib/Db/FeedMapperV2.php 100.00% <100.00%> (ø) 9.00 <0.00> (ø)
lib/Db/FolderMapperV2.php 95.83% <100.00%> (+0.96%) 6.00 <0.00> (ø)
lib/Db/ItemMapperV2.php 100.00% <100.00%> (ø) 53.00 <0.00> (ø)
lib/Fetcher/FeedFetcher.php 88.57% <0.00%> (-0.17%) 37.00% <0.00%> (ø%)
lib/Service/FeedServiceV2.php 100.00% <0.00%> (ø) 28.00% <0.00%> (ø%)
lib/Command/Debug/ItemList.php 0.00% <0.00%> (ø) 6.00% <0.00%> (ø%)
lib/Command/Debug/FeedItemList.php 0.00% <0.00%> (ø) 6.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2baa7a2...0efa751. Read the comment docs.

@anoymouserver
Copy link
Contributor

umm, nope

Log message
{
    "reqId": "pXVPwtb64txgz7jSVLit",
    "level": 3,
    "time": "2021-03-02T20:21:35+00:00",
    "remoteAddr": "127.0.0.1",
    "user": "anoymouserver",
    "app": "index",
    "method": "POST",
    "url": "/apps/news/feeds/135/read",
    "message": {
        "Exception": "Doctrine\\DBAL\\Exception\\SyntaxErrorException",
        "Message": "An exception occurred while executing 'UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)':\n\nSQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1",
        "Code": 0,
        "Trace": [{
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 169,
                "function": "convertException",
                "class": "Doctrine\\DBAL\\Driver\\AbstractMySQLDriver",
                "type": "->",
                "args": ["An exception occurred while executing 'UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)':\n\nSQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1", {
                        "errorInfo": ["42000", 1064, "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }
                ]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 149,
                "function": "wrapException",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["42000", 1064, "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "An exception occurred while executing 'UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)':\n\nSQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1"]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                "line": 1071,
                "function": "driverExceptionDuringQuery",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["42000", 1064, "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", []]
            }, {
                "file": "/var/www/cloud/lib/private/DB/Connection.php",
                "line": 222,
                "function": "executeUpdate",
                "class": "Doctrine\\DBAL\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", [], []]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                "line": 180,
                "function": "executeUpdate",
                "class": "OC\\DB\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                "line": 358,
                "function": "read",
                "class": "OCA\\News\\Db\\FeedMapperV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129155]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                "line": 286,
                "function": "read",
                "class": "OCA\\News\\Service\\FeedServiceV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129155]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 169,
                "function": "read",
                "class": "OCA\\News\\Controller\\FeedController",
                "type": "->",
                "args": [135, 129155]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 100,
                "function": "executeController",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                "line": 152,
                "function": "dispatch",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/Route/Router.php",
                "line": 309,
                "function": "main",
                "class": "OC\\AppFramework\\App",
                "type": "::",
                "args": ["OCA\\News\\Controller\\FeedController", "read", {
                        "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                    }, {
                        "feedId": "135",
                        "_route": "news.feed.read"
                    }
                ]
            }, {
                "file": "/var/www/cloud/lib/base.php",
                "line": 1008,
                "function": "match",
                "class": "OC\\Route\\Router",
                "type": "->",
                "args": ["/apps/news/feeds/135/read"]
            }, {
                "file": "/var/www/cloud/index.php",
                "line": 37,
                "function": "handleRequest",
                "class": "OC",
                "type": "::",
                "args": []
            }
        ],
        "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php",
        "Line": 79,
        "Previous": {
            "Exception": "Doctrine\\DBAL\\Driver\\PDOException",
            "Message": "SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1",
            "Code": "42000",
            "Trace": [{
                    "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                    "line": 1068,
                    "function": "exec",
                    "class": "Doctrine\\DBAL\\Driver\\PDOConnection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                }, {
                    "file": "/var/www/cloud/lib/private/DB/Connection.php",
                    "line": 222,
                    "function": "executeUpdate",
                    "class": "Doctrine\\DBAL\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", [], []]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                    "line": 180,
                    "function": "executeUpdate",
                    "class": "OC\\DB\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                    "line": 358,
                    "function": "read",
                    "class": "OCA\\News\\Db\\FeedMapperV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 129155]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                    "line": 286,
                    "function": "read",
                    "class": "OCA\\News\\Service\\FeedServiceV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 129155]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 169,
                    "function": "read",
                    "class": "OCA\\News\\Controller\\FeedController",
                    "type": "->",
                    "args": [135, 129155]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 100,
                    "function": "executeController",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                    "line": 152,
                    "function": "dispatch",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/Route/Router.php",
                    "line": 309,
                    "function": "main",
                    "class": "OC\\AppFramework\\App",
                    "type": "::",
                    "args": ["OCA\\News\\Controller\\FeedController", "read", {
                            "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                        }, {
                            "feedId": "135",
                            "_route": "news.feed.read"
                        }
                    ]
                }, {
                    "file": "/var/www/cloud/lib/base.php",
                    "line": 1008,
                    "function": "match",
                    "class": "OC\\Route\\Router",
                    "type": "->",
                    "args": ["/apps/news/feeds/135/read"]
                }, {
                    "file": "/var/www/cloud/index.php",
                    "line": 37,
                    "function": "handleRequest",
                    "class": "OC",
                    "type": "::",
                    "args": []
                }
            ],
            "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php",
            "Line": 43,
            "Previous": {
                "Exception": "PDOException",
                "Message": "SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)' at line 1",
                "Code": "42000",
                "Trace": [{
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php",
                        "line": 41,
                        "function": "exec",
                        "class": "PDO",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                    }, {
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                        "line": 1068,
                        "function": "exec",
                        "class": "Doctrine\\DBAL\\Driver\\PDOConnection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                    }, {
                        "file": "/var/www/cloud/lib/private/DB/Connection.php",
                        "line": 222,
                        "function": "executeUpdate",
                        "class": "Doctrine\\DBAL\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", [], []]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                        "line": 180,
                        "function": "executeUpdate",
                        "class": "OC\\DB\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                        "line": 358,
                        "function": "read",
                        "class": "OCA\\News\\Db\\FeedMapperV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 129155]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                        "line": 286,
                        "function": "read",
                        "class": "OCA\\News\\Service\\FeedServiceV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 129155]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 169,
                        "function": "read",
                        "class": "OCA\\News\\Controller\\FeedController",
                        "type": "->",
                        "args": [135, 129155]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 100,
                        "function": "executeController",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                        "line": 152,
                        "function": "dispatch",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/Route/Router.php",
                        "line": 309,
                        "function": "main",
                        "class": "OC\\AppFramework\\App",
                        "type": "::",
                        "args": ["OCA\\News\\Controller\\FeedController", "read", {
                                "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                            }, {
                                "feedId": "135",
                                "_route": "news.feed.read"
                            }
                        ]
                    }, {
                        "file": "/var/www/cloud/lib/base.php",
                        "line": 1008,
                        "function": "match",
                        "class": "OC\\Route\\Router",
                        "type": "->",
                        "args": ["/apps/news/feeds/135/read"]
                    }, {
                        "file": "/var/www/cloud/index.php",
                        "line": 37,
                        "function": "handleRequest",
                        "class": "OC",
                        "type": "::",
                        "args": []
                    }
                ],
                "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php",
                "Line": 41
            }
        },
        "CustomMessage": "--"
    },
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0",
    "version": "20.0.8.1",
    "id": "603e9e5d02758"
}

@SMillerDev SMillerDev force-pushed the fix/mapper/update_uses_setvalues branch from 782aedb to 54266af Compare March 2, 2021 20:32
@SMillerDev
Copy link
Contributor Author

And another try

@anoymouserver
Copy link
Contributor

anoymouserver commented Mar 2, 2021

Nope .. you're unlucky today

Log message
{
    "reqId": "TdgQ7DrosL6SVCKoadsE",
    "level": 3,
    "time": "2021-03-02T20:36:37+00:00",
    "remoteAddr": "127.0.0.1",
    "user": "anoymouserver",
    "app": "index",
    "method": "POST",
    "url": "/apps/news/feeds/135/read",
    "message": {
        "Exception": "Doctrine\\DBAL\\Exception\\SyntaxErrorException",
        "Message": "An exception occurred while executing 'UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)':\n\nSQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =' at line 1",
        "Code": 0,
        "Trace": [{
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 169,
                "function": "convertException",
                "class": "Doctrine\\DBAL\\Driver\\AbstractMySQLDriver",
                "type": "->",
                "args": ["An exception occurred while executing 'UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)':\n\nSQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =' at line 1", {
                        "errorInfo": ["42000", 1064, "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =' at line 1"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }
                ]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 149,
                "function": "wrapException",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["42000", 1064, "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =' at line 1"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "An exception occurred while executing 'UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)':\n\nSQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =' at line 1"]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                "line": 1071,
                "function": "driverExceptionDuringQuery",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["42000", 1064, "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =' at line 1"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", []]
            }, {
                "file": "/var/www/cloud/lib/private/DB/Connection.php",
                "line": 222,
                "function": "executeUpdate",
                "class": "Doctrine\\DBAL\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", [], []]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                "line": 180,
                "function": "executeUpdate",
                "class": "OC\\DB\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                "line": 358,
                "function": "read",
                "class": "OCA\\News\\Db\\FeedMapperV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129155]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                "line": 286,
                "function": "read",
                "class": "OCA\\News\\Service\\FeedServiceV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129155]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 169,
                "function": "read",
                "class": "OCA\\News\\Controller\\FeedController",
                "type": "->",
                "args": [135, 129155]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 100,
                "function": "executeController",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                "line": 152,
                "function": "dispatch",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/Route/Router.php",
                "line": 309,
                "function": "main",
                "class": "OC\\AppFramework\\App",
                "type": "::",
                "args": ["OCA\\News\\Controller\\FeedController", "read", {
                        "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                    }, {
                        "feedId": "135",
                        "_route": "news.feed.read"
                    }
                ]
            }, {
                "file": "/var/www/cloud/lib/base.php",
                "line": 1008,
                "function": "match",
                "class": "OC\\Route\\Router",
                "type": "->",
                "args": ["/apps/news/feeds/135/read"]
            }, {
                "file": "/var/www/cloud/index.php",
                "line": 37,
                "function": "handleRequest",
                "class": "OC",
                "type": "::",
                "args": []
            }
        ],
        "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php",
        "Line": 79,
        "Previous": {
            "Exception": "Doctrine\\DBAL\\Driver\\PDOException",
            "Message": "SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =' at line 1",
            "Code": "42000",
            "Trace": [{
                    "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                    "line": 1068,
                    "function": "exec",
                    "class": "Doctrine\\DBAL\\Driver\\PDOConnection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                }, {
                    "file": "/var/www/cloud/lib/private/DB/Connection.php",
                    "line": 222,
                    "function": "executeUpdate",
                    "class": "Doctrine\\DBAL\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", [], []]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                    "line": 180,
                    "function": "executeUpdate",
                    "class": "OC\\DB\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                    "line": 358,
                    "function": "read",
                    "class": "OCA\\News\\Db\\FeedMapperV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 129155]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                    "line": 286,
                    "function": "read",
                    "class": "OCA\\News\\Service\\FeedServiceV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 129155]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 169,
                    "function": "read",
                    "class": "OCA\\News\\Controller\\FeedController",
                    "type": "->",
                    "args": [135, 129155]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 100,
                    "function": "executeController",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                    "line": 152,
                    "function": "dispatch",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/Route/Router.php",
                    "line": 309,
                    "function": "main",
                    "class": "OC\\AppFramework\\App",
                    "type": "::",
                    "args": ["OCA\\News\\Controller\\FeedController", "read", {
                            "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                        }, {
                            "feedId": "135",
                            "_route": "news.feed.read"
                        }
                    ]
                }, {
                    "file": "/var/www/cloud/lib/base.php",
                    "line": 1008,
                    "function": "match",
                    "class": "OC\\Route\\Router",
                    "type": "->",
                    "args": ["/apps/news/feeds/135/read"]
                }, {
                    "file": "/var/www/cloud/index.php",
                    "line": 37,
                    "function": "handleRequest",
                    "class": "OC",
                    "type": "::",
                    "args": []
                }
            ],
            "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php",
            "Line": 43,
            "Previous": {
                "Exception": "PDOException",
                "Message": "SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =' at line 1",
                "Code": "42000",
                "Trace": [{
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php",
                        "line": 41,
                        "function": "exec",
                        "class": "PDO",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                    }, {
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                        "line": 1068,
                        "function": "exec",
                        "class": "Doctrine\\DBAL\\Driver\\PDOConnection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                    }, {
                        "file": "/var/www/cloud/lib/private/DB/Connection.php",
                        "line": 222,
                        "function": "executeUpdate",
                        "class": "Doctrine\\DBAL\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)", [], []]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                        "line": 180,
                        "function": "executeUpdate",
                        "class": "OC\\DB\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)"]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                        "line": 358,
                        "function": "read",
                        "class": "OCA\\News\\Db\\FeedMapperV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 129155]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                        "line": 286,
                        "function": "read",
                        "class": "OCA\\News\\Service\\FeedServiceV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 129155]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 169,
                        "function": "read",
                        "class": "OCA\\News\\Controller\\FeedController",
                        "type": "->",
                        "args": [135, 129155]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 100,
                        "function": "executeController",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                        "line": 152,
                        "function": "dispatch",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/Route/Router.php",
                        "line": 309,
                        "function": "main",
                        "class": "OC\\AppFramework\\App",
                        "type": "::",
                        "args": ["OCA\\News\\Controller\\FeedController", "read", {
                                "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                            }, {
                                "feedId": "135",
                                "_route": "news.feed.read"
                            }
                        ]
                    }, {
                        "file": "/var/www/cloud/lib/base.php",
                        "line": 1008,
                        "function": "match",
                        "class": "OC\\Route\\Router",
                        "type": "->",
                        "args": ["/apps/news/feeds/135/read"]
                    }, {
                        "file": "/var/www/cloud/index.php",
                        "line": 37,
                        "function": "handleRequest",
                        "class": "OC",
                        "type": "::",
                        "args": []
                    }
                ],
                "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php",
                "Line": 41
            }
        },
        "CustomMessage": "--"
    },
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0",
    "version": "20.0.8.1",
    "id": "603ea1e02db8b"
}

The problem seems to be the missing feeds (ignored innerJoin) not the :userId you're trying to fix in the last commits.

UPDATE `oc_news_items` items SET `unread` = :unread WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (items.id =< :maxItemId)

The parameter of 6d1a0c1 probably would have worked already. 🤔

@SMillerDev
Copy link
Contributor Author

😡 why is it ignoring the join

@Grotax Grotax added API Impact API/Backend code patch bug labels Mar 3, 2021
@anoymouserver
Copy link
Contributor

The reason is apparently the missing support of UPDATE JOIN for all DB types.

Joins are not supported on update and delete queries because it is not supported on all dbms. It won't be implemented in Doctrine 1 or Doctrine 2. You can however get the same affect by using subqueries.

@SMillerDev
Copy link
Contributor Author

Thanks for looking that up. Yet another beautiful query destroyed for the sake of compatibility.

@SMillerDev SMillerDev force-pushed the fix/mapper/update_uses_setvalues branch from 54266af to 36bbe50 Compare March 9, 2021 11:45
@SMillerDev
Copy link
Contributor Author

I didn't fix the unittests this time, but can you test this?

Copy link
Contributor

@anoymouserver anoymouserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the suggested changes:

Full log entry
{
    "reqId": "DRkJ7h5Nxow5nUEdhcRY",
    "level": 3,
    "time": "2021-03-09T13:35:03+00:00",
    "remoteAddr": "127.0.0.1",
    "user": "anoymouserver",
    "app": "index",
    "method": "POST",
    "url": "/apps/news/feeds/135/read",
    "message": {
        "Exception": "Doctrine\\DBAL\\Exception\\InvalidFieldNameException",
        "Message": "An exception occurred while executing 'UPDATE `oc_news_items` SET `unread` = ? WHERE (`id` IN (`107687`)) AND (id <= ?)' with params [false, 129155]:\n\nSQLSTATE[42S22]: Column not found: 1054 Unknown column '107687' in 'where clause'",
        "Code": 0,
        "Trace": [{
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 169,
                "function": "convertException",
                "class": "Doctrine\\DBAL\\Driver\\AbstractMySQLDriver",
                "type": "->",
                "args": ["An exception occurred while executing 'UPDATE `oc_news_items` SET `unread` = ? WHERE (`id` IN (`107687`)) AND (id <= ?)' with params [false, 129155]:\n\nSQLSTATE[42S22]: Column not found: 1054 Unknown column '107687' in 'where clause'", {
                        "errorInfo": ["42S22", 1054, "Unknown column '107687' in 'where clause'"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }
                ]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 149,
                "function": "wrapException",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["42S22", 1054, "Unknown column '107687' in 'where clause'"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "An exception occurred while executing 'UPDATE `oc_news_items` SET `unread` = ? WHERE (`id` IN (`107687`)) AND (id <= ?)' with params [false, 129155]:\n\nSQLSTATE[42S22]: Column not found: 1054 Unknown column '107687' in 'where clause'"]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                "line": 1071,
                "function": "driverExceptionDuringQuery",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["42S22", 1054, "Unknown column '107687' in 'where clause'"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "UPDATE `oc_news_items` SET `unread` = ? WHERE (`id` IN (`107687`)) AND (id <= ?)", {
                        "1": false,
                        "2": 129155
                    }
                ]
            }, {
                "file": "/var/www/cloud/lib/private/DB/Connection.php",
                "line": 222,
                "function": "executeUpdate",
                "class": "Doctrine\\DBAL\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` SET `unread` = ? WHERE (`id` IN (`107687`)) AND (id <= ?)", [false, 129155], [2, 2]]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                "line": 193,
                "function": "executeUpdate",
                "class": "OC\\DB\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` SET `unread` = :unread WHERE (`id` IN (`107687`)) AND (id <= :maxItemId)", {
                        "unread": false,
                        "maxItemId": 129155
                    }
                ]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                "line": 358,
                "function": "read",
                "class": "OCA\\News\\Db\\FeedMapperV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129155]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                "line": 286,
                "function": "read",
                "class": "OCA\\News\\Service\\FeedServiceV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129155]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 169,
                "function": "read",
                "class": "OCA\\News\\Controller\\FeedController",
                "type": "->",
                "args": [135, 129155]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 100,
                "function": "executeController",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                "line": 152,
                "function": "dispatch",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/Route/Router.php",
                "line": 309,
                "function": "main",
                "class": "OC\\AppFramework\\App",
                "type": "::",
                "args": ["OCA\\News\\Controller\\FeedController", "read", {
                        "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                    }, {
                        "feedId": "135",
                        "_route": "news.feed.read"
                    }
                ]
            }, {
                "file": "/var/www/cloud/lib/base.php",
                "line": 1008,
                "function": "match",
                "class": "OC\\Route\\Router",
                "type": "->",
                "args": ["/apps/news/feeds/135/read"]
            }, {
                "file": "/var/www/cloud/index.php",
                "line": 37,
                "function": "handleRequest",
                "class": "OC",
                "type": "::",
                "args": []
            }
        ],
        "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php",
        "Line": 60,
        "Previous": {
            "Exception": "Doctrine\\DBAL\\Driver\\PDOException",
            "Message": "SQLSTATE[42S22]: Column not found: 1054 Unknown column '107687' in 'where clause'",
            "Code": "42S22",
            "Trace": [{
                    "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                    "line": 1062,
                    "function": "execute",
                    "class": "Doctrine\\DBAL\\Driver\\PDOStatement",
                    "type": "->",
                    "args": []
                }, {
                    "file": "/var/www/cloud/lib/private/DB/Connection.php",
                    "line": 222,
                    "function": "executeUpdate",
                    "class": "Doctrine\\DBAL\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` SET `unread` = ? WHERE (`id` IN (`107687`)) AND (id <= ?)", [false, 129155], [2, 2]]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                    "line": 193,
                    "function": "executeUpdate",
                    "class": "OC\\DB\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` SET `unread` = :unread WHERE (`id` IN (`107687`)) AND (id <= :maxItemId)", {
                            "unread": false,
                            "maxItemId": 129155
                        }
                    ]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                    "line": 358,
                    "function": "read",
                    "class": "OCA\\News\\Db\\FeedMapperV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 129155]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                    "line": 286,
                    "function": "read",
                    "class": "OCA\\News\\Service\\FeedServiceV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 129155]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 169,
                    "function": "read",
                    "class": "OCA\\News\\Controller\\FeedController",
                    "type": "->",
                    "args": [135, 129155]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 100,
                    "function": "executeController",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                    "line": 152,
                    "function": "dispatch",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/Route/Router.php",
                    "line": 309,
                    "function": "main",
                    "class": "OC\\AppFramework\\App",
                    "type": "::",
                    "args": ["OCA\\News\\Controller\\FeedController", "read", {
                            "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                        }, {
                            "feedId": "135",
                            "_route": "news.feed.read"
                        }
                    ]
                }, {
                    "file": "/var/www/cloud/lib/base.php",
                    "line": 1008,
                    "function": "match",
                    "class": "OC\\Route\\Router",
                    "type": "->",
                    "args": ["/apps/news/feeds/135/read"]
                }, {
                    "file": "/var/www/cloud/index.php",
                    "line": 37,
                    "function": "handleRequest",
                    "class": "OC",
                    "type": "::",
                    "args": []
                }
            ],
            "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
            "Line": 129,
            "Previous": {
                "Exception": "PDOException",
                "Message": "SQLSTATE[42S22]: Column not found: 1054 Unknown column '107687' in 'where clause'",
                "Code": "42S22",
                "Trace": [{
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
                        "line": 127,
                        "function": "execute",
                        "class": "PDOStatement",
                        "type": "->",
                        "args": [null]
                    }, {
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                        "line": 1062,
                        "function": "execute",
                        "class": "Doctrine\\DBAL\\Driver\\PDOStatement",
                        "type": "->",
                        "args": []
                    }, {
                        "file": "/var/www/cloud/lib/private/DB/Connection.php",
                        "line": 222,
                        "function": "executeUpdate",
                        "class": "Doctrine\\DBAL\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` SET `unread` = ? WHERE (`id` IN (`107687`)) AND (id <= ?)", [false, 129155], [2, 2]]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                        "line": 193,
                        "function": "executeUpdate",
                        "class": "OC\\DB\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` SET `unread` = :unread WHERE (`id` IN (`107687`)) AND (id <= :maxItemId)", {
                                "unread": false,
                                "maxItemId": 129155
                            }
                        ]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                        "line": 358,
                        "function": "read",
                        "class": "OCA\\News\\Db\\FeedMapperV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 129155]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                        "line": 286,
                        "function": "read",
                        "class": "OCA\\News\\Service\\FeedServiceV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 129155]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 169,
                        "function": "read",
                        "class": "OCA\\News\\Controller\\FeedController",
                        "type": "->",
                        "args": [135, 129155]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 100,
                        "function": "executeController",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                        "line": 152,
                        "function": "dispatch",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/Route/Router.php",
                        "line": 309,
                        "function": "main",
                        "class": "OC\\AppFramework\\App",
                        "type": "::",
                        "args": ["OCA\\News\\Controller\\FeedController", "read", {
                                "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                            }, {
                                "feedId": "135",
                                "_route": "news.feed.read"
                            }
                        ]
                    }, {
                        "file": "/var/www/cloud/lib/base.php",
                        "line": 1008,
                        "function": "match",
                        "class": "OC\\Route\\Router",
                        "type": "->",
                        "args": ["/apps/news/feeds/135/read"]
                    }, {
                        "file": "/var/www/cloud/index.php",
                        "line": 37,
                        "function": "handleRequest",
                        "class": "OC",
                        "type": "::",
                        "args": []
                    }
                ],
                "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
                "Line": 127
            }
        },
        "CustomMessage": "--"
    },
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0",
    "version": "20.0.8.1",
    "id": "60477987e995c"
}

Somehow the expr()->in() assumes column names, instead of values..

lib/Db/FeedMapperV2.php Outdated Show resolved Hide resolved
lib/Db/FeedMapperV2.php Outdated Show resolved Hide resolved
lib/Db/FeedMapperV2.php Outdated Show resolved Hide resolved
@SMillerDev SMillerDev force-pushed the fix/mapper/update_uses_setvalues branch from 7bfe1bd to 8a0ad2f Compare March 17, 2021 19:51
Copy link
Contributor

@anoymouserver anoymouserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly still not

lib/Db/FeedMapperV2.php Outdated Show resolved Hide resolved
lib/Db/FeedMapperV2.php Outdated Show resolved Hide resolved
@SMillerDev SMillerDev force-pushed the fix/mapper/update_uses_setvalues branch from 8a0ad2f to f7e34ad Compare March 23, 2021 18:40
@SMillerDev
Copy link
Contributor Author

Maybe now 😓

Copy link
Contributor

@anoymouserver anoymouserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, doesn't work.
Without wanting to offend you, are you testing the new changes at all? Or does it work with SQLite without any problems?

lib/Db/FeedMapperV2.php Outdated Show resolved Hide resolved
lib/Db/FeedMapperV2.php Outdated Show resolved Hide resolved
@SMillerDev
Copy link
Contributor Author

Without wanting to offend you, are you testing the new changes at all? Or does it work with SQLite without any problems?

I am not, I don't have a working nextcloud web setup locally and the read methods don't have a CLI associated. I think I'll need to fix that first because this is getting ridiculous.

@SMillerDev SMillerDev force-pushed the fix/mapper/update_uses_setvalues branch from f7e34ad to e68c767 Compare March 23, 2021 22:31
@SMillerDev
Copy link
Contributor Author

Well, the commands seem to work now and the PR is much larger then I want it to be 😞. I'll see if I can fix the unittests soon.

@SMillerDev SMillerDev force-pushed the fix/mapper/update_uses_setvalues branch from e68c767 to 4ddea9c Compare March 23, 2021 22:35
@anoymouserver
Copy link
Contributor

One last change .. seems to work after that.

diff --git a/lib/Db/FeedMapperV2.php b/lib/Db/FeedMapperV2.php
index df46c80fd..531993e94 100644
--- a/lib/Db/FeedMapperV2.php
+++ b/lib/Db/FeedMapperV2.php
@@ -176,7 +176,7 @@ class FeedMapperV2 extends NewsMapperV2
             ->setParameter('feedId', $id);
             
         if ($maxItemID !== null) {
-            $idBuilder->andWhere('id <= :maxItemId')
+            $idBuilder->andWhere('items.id <= :maxItemId')
                       ->setParameter('maxItemId', $maxItemID);
         }
Related log message
{
    "reqId": "AOv19scxm5ZP7IK02ptC",
    "level": 3,
    "time": "2021-03-25T09:09:10+00:00",
    "remoteAddr": "127.0.0.1",
    "user": "anoymouserver",
    "app": "index",
    "method": "POST",
    "url": "/apps/news/feeds/135/read",
    "message": {
        "Exception": "Doctrine\\DBAL\\Exception\\NonUniqueFieldNameException",
        "Message": "An exception occurred while executing 'SELECT `items`.`id` FROM `oc_news_items` `items` INNER JOIN `oc_news_feeds` `feeds` ON items.feed_id = feeds.id WHERE (feeds.user_id = ?) AND (feeds.id = ?) AND (id <= ?)' with params [\"anoymouserver\", 135, 129166]:\n\nSQLSTATE[23000]: Integrity constraint violation: 1052 Column 'id' in where clause is ambiguous",
        "Code": 0,
        "Trace": [{
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 169,
                "function": "convertException",
                "class": "Doctrine\\DBAL\\Driver\\AbstractMySQLDriver",
                "type": "->",
                "args": ["An exception occurred while executing 'SELECT `items`.`id` FROM `oc_news_items` `items` INNER JOIN `oc_news_feeds` `feeds` ON items.feed_id = feeds.id WHERE (feeds.user_id = ?) AND (feeds.id = ?) AND (id <= ?)' with params [\"anoymouserver\", 135, 129166]:\n\nSQLSTATE[23000]: Integrity constraint violation: 1052 Column 'id' in where clause is ambiguous", {
                        "errorInfo": ["23000", 1052, "Column 'id' in where clause is ambiguous"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }
                ]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 149,
                "function": "wrapException",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["23000", 1052, "Column 'id' in where clause is ambiguous"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "An exception occurred while executing 'SELECT `items`.`id` FROM `oc_news_items` `items` INNER JOIN `oc_news_feeds` `feeds` ON items.feed_id = feeds.id WHERE (feeds.user_id = ?) AND (feeds.id = ?) AND (id <= ?)' with params [\"anoymouserver\", 135, 129166]:\n\nSQLSTATE[23000]: Integrity constraint violation: 1052 Column 'id' in where clause is ambiguous"]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                "line": 914,
                "function": "driverExceptionDuringQuery",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["23000", 1052, "Column 'id' in where clause is ambiguous"],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "SELECT `items`.`id` FROM `oc_news_items` `items` INNER JOIN `oc_news_feeds` `feeds` ON items.feed_id = feeds.id WHERE (feeds.user_id = ?) AND (feeds.id = ?) AND (id <= ?)", {
                        "1": "anoymouserver",
                        "2": 135,
                        "3": 129166
                    }
                ]
            }, {
                "file": "/var/www/cloud/lib/private/DB/Connection.php",
                "line": 202,
                "function": "executeQuery",
                "class": "Doctrine\\DBAL\\Connection",
                "type": "->",
                "args": ["SELECT `items`.`id` FROM `oc_news_items` `items` INNER JOIN `oc_news_feeds` `feeds` ON items.feed_id = feeds.id WHERE (feeds.user_id = ?) AND (feeds.id = ?) AND (id <= ?)", ["anoymouserver", 135, 129166], [2, 2, 2], null]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                "line": 185,
                "function": "executeQuery",
                "class": "OC\\DB\\Connection",
                "type": "->",
                "args": ["SELECT `items`.`id` FROM `oc_news_items` `items` INNER JOIN `oc_news_feeds` `feeds` ON items.feed_id = feeds.id WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (id <= :maxItemId)", {
                        "userId": "anoymouserver",
                        "feedId": 135,
                        "maxItemId": 129166
                    }
                ]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                "line": 358,
                "function": "read",
                "class": "OCA\\News\\Db\\FeedMapperV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129166]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                "line": 286,
                "function": "read",
                "class": "OCA\\News\\Service\\FeedServiceV2",
                "type": "->",
                "args": ["anoymouserver", 135, 129166]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 169,
                "function": "read",
                "class": "OCA\\News\\Controller\\FeedController",
                "type": "->",
                "args": [135, 129166]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 100,
                "function": "executeController",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                "line": 152,
                "function": "dispatch",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/Route/Router.php",
                "line": 309,
                "function": "main",
                "class": "OC\\AppFramework\\App",
                "type": "::",
                "args": ["OCA\\News\\Controller\\FeedController", "read", {
                        "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                    }, {
                        "feedId": "135",
                        "_route": "news.feed.read"
                    }
                ]
            }, {
                "file": "/var/www/cloud/lib/base.php",
                "line": 1008,
                "function": "match",
                "class": "OC\\Route\\Router",
                "type": "->",
                "args": ["/apps/news/feeds/135/read"]
            }, {
                "file": "/var/www/cloud/index.php",
                "line": 37,
                "function": "handleRequest",
                "class": "OC",
                "type": "::",
                "args": []
            }
        ],
        "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php",
        "Line": 65,
        "Previous": {
            "Exception": "Doctrine\\DBAL\\Driver\\PDOException",
            "Message": "SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'id' in where clause is ambiguous",
            "Code": "23000",
            "Trace": [{
                    "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                    "line": 906,
                    "function": "execute",
                    "class": "Doctrine\\DBAL\\Driver\\PDOStatement",
                    "type": "->",
                    "args": []
                }, {
                    "file": "/var/www/cloud/lib/private/DB/Connection.php",
                    "line": 202,
                    "function": "executeQuery",
                    "class": "Doctrine\\DBAL\\Connection",
                    "type": "->",
                    "args": ["SELECT `items`.`id` FROM `oc_news_items` `items` INNER JOIN `oc_news_feeds` `feeds` ON items.feed_id = feeds.id WHERE (feeds.user_id = ?) AND (feeds.id = ?) AND (id <= ?)", ["anoymouserver", 135, 129166], [2, 2, 2], null]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                    "line": 185,
                    "function": "executeQuery",
                    "class": "OC\\DB\\Connection",
                    "type": "->",
                    "args": ["SELECT `items`.`id` FROM `oc_news_items` `items` INNER JOIN `oc_news_feeds` `feeds` ON items.feed_id = feeds.id WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (id <= :maxItemId)", {
                            "userId": "anoymouserver",
                            "feedId": 135,
                            "maxItemId": 129166
                        }
                    ]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                    "line": 358,
                    "function": "read",
                    "class": "OCA\\News\\Db\\FeedMapperV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 129166]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                    "line": 286,
                    "function": "read",
                    "class": "OCA\\News\\Service\\FeedServiceV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 129166]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 169,
                    "function": "read",
                    "class": "OCA\\News\\Controller\\FeedController",
                    "type": "->",
                    "args": [135, 129166]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 100,
                    "function": "executeController",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                    "line": 152,
                    "function": "dispatch",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/Route/Router.php",
                    "line": 309,
                    "function": "main",
                    "class": "OC\\AppFramework\\App",
                    "type": "::",
                    "args": ["OCA\\News\\Controller\\FeedController", "read", {
                            "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                        }, {
                            "feedId": "135",
                            "_route": "news.feed.read"
                        }
                    ]
                }, {
                    "file": "/var/www/cloud/lib/base.php",
                    "line": 1008,
                    "function": "match",
                    "class": "OC\\Route\\Router",
                    "type": "->",
                    "args": ["/apps/news/feeds/135/read"]
                }, {
                    "file": "/var/www/cloud/index.php",
                    "line": 37,
                    "function": "handleRequest",
                    "class": "OC",
                    "type": "::",
                    "args": []
                }
            ],
            "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
            "Line": 129,
            "Previous": {
                "Exception": "PDOException",
                "Message": "SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'id' in where clause is ambiguous",
                "Code": "23000",
                "Trace": [{
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
                        "line": 127,
                        "function": "execute",
                        "class": "PDOStatement",
                        "type": "->",
                        "args": [null]
                    }, {
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                        "line": 906,
                        "function": "execute",
                        "class": "Doctrine\\DBAL\\Driver\\PDOStatement",
                        "type": "->",
                        "args": []
                    }, {
                        "file": "/var/www/cloud/lib/private/DB/Connection.php",
                        "line": 202,
                        "function": "executeQuery",
                        "class": "Doctrine\\DBAL\\Connection",
                        "type": "->",
                        "args": ["SELECT `items`.`id` FROM `oc_news_items` `items` INNER JOIN `oc_news_feeds` `feeds` ON items.feed_id = feeds.id WHERE (feeds.user_id = ?) AND (feeds.id = ?) AND (id <= ?)", ["anoymouserver", 135, 129166], [2, 2, 2], null]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                        "line": 185,
                        "function": "executeQuery",
                        "class": "OC\\DB\\Connection",
                        "type": "->",
                        "args": ["SELECT `items`.`id` FROM `oc_news_items` `items` INNER JOIN `oc_news_feeds` `feeds` ON items.feed_id = feeds.id WHERE (feeds.user_id = :userId) AND (feeds.id = :feedId) AND (id <= :maxItemId)", {
                                "userId": "anoymouserver",
                                "feedId": 135,
                                "maxItemId": 129166
                            }
                        ]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                        "line": 358,
                        "function": "read",
                        "class": "OCA\\News\\Db\\FeedMapperV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 129166]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                        "line": 286,
                        "function": "read",
                        "class": "OCA\\News\\Service\\FeedServiceV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 129166]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 169,
                        "function": "read",
                        "class": "OCA\\News\\Controller\\FeedController",
                        "type": "->",
                        "args": [135, 129166]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 100,
                        "function": "executeController",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                        "line": 152,
                        "function": "dispatch",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/Route/Router.php",
                        "line": 309,
                        "function": "main",
                        "class": "OC\\AppFramework\\App",
                        "type": "::",
                        "args": ["OCA\\News\\Controller\\FeedController", "read", {
                                "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                            }, {
                                "feedId": "135",
                                "_route": "news.feed.read"
                            }
                        ]
                    }, {
                        "file": "/var/www/cloud/lib/base.php",
                        "line": 1008,
                        "function": "match",
                        "class": "OC\\Route\\Router",
                        "type": "->",
                        "args": ["/apps/news/feeds/135/read"]
                    }, {
                        "file": "/var/www/cloud/index.php",
                        "line": 37,
                        "function": "handleRequest",
                        "class": "OC",
                        "type": "::",
                        "args": []
                    }
                ],
                "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
                "Line": 127
            }
        },
        "CustomMessage": "--"
    },
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0",
    "version": "20.0.8.1",
    "id": "605c533731dc2"
}

lib/Db/FeedMapperV2.php Outdated Show resolved Hide resolved
lib/Db/FolderMapperV2.php Outdated Show resolved Hide resolved
@SMillerDev SMillerDev force-pushed the fix/mapper/update_uses_setvalues branch from 7d0d49e to e47487b Compare March 25, 2021 20:40
lib/Db/FeedMapperV2.php Outdated Show resolved Hide resolved
lib/Db/ItemMapperV2.php Outdated Show resolved Hide resolved
@SMillerDev
Copy link
Contributor Author

@anoymouserver can you try one last time and give your approval if it works?

@anoymouserver
Copy link
Contributor

No, doesn't work .. apparently something other than the necessary modifications changed after #1214 (comment), since it had worked for me then. Maybe something in the recent commits in the master branch?

Log entries
/***** mark feed as read *****/
{
    "reqId": "WMx6qQINrLHjayPosAva",
    "level": 3,
    "time": "2021-03-29T08:46:29+00:00",
    "remoteAddr": "127.0.0.1",
    "user": "anoymouserver",
    "app": "index",
    "method": "POST",
    "url": "/apps/news/feeds/135/read",
    "message": {
        "Exception": "Doctrine\\DBAL\\Exception\\DriverException",
        "Message": "An exception occurred while executing 'UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (NULL)':\n\nSQLSTATE[HY093]: Invalid parameter number: no parameters were bound",
        "Code": 0,
        "Trace": [{
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 169,
                "function": "convertException",
                "class": "Doctrine\\DBAL\\Driver\\AbstractMySQLDriver",
                "type": "->",
                "args": ["An exception occurred while executing 'UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (NULL)':\n\nSQLSTATE[HY093]: Invalid parameter number: no parameters were bound", {
                        "errorInfo": ["HY093", 0],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }
                ]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 149,
                "function": "wrapException",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["HY093", 0],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "An exception occurred while executing 'UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (NULL)':\n\nSQLSTATE[HY093]: Invalid parameter number: no parameters were bound"]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                "line": 1071,
                "function": "driverExceptionDuringQuery",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["HY093", 0],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (NULL)", []]
            }, {
                "file": "/var/www/cloud/lib/private/DB/Connection.php",
                "line": 222,
                "function": "executeUpdate",
                "class": "Doctrine\\DBAL\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (NULL)", [], []]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                "line": 194,
                "function": "executeUpdate",
                "class": "OC\\DB\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (:idList)", {
                        "unread": false,
                        "idList": []
                    }, {
                        "unread": 5,
                        "idList": 101
                    }
                ]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                "line": 357,
                "function": "read",
                "class": "OCA\\News\\Db\\FeedMapperV2",
                "type": "->",
                "args": ["anoymouserver", 135, 90032]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                "line": 286,
                "function": "read",
                "class": "OCA\\News\\Service\\FeedServiceV2",
                "type": "->",
                "args": ["anoymouserver", 135, 90032]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 169,
                "function": "read",
                "class": "OCA\\News\\Controller\\FeedController",
                "type": "->",
                "args": [135, 90032]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 100,
                "function": "executeController",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                "line": 152,
                "function": "dispatch",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/Route/Router.php",
                "line": 309,
                "function": "main",
                "class": "OC\\AppFramework\\App",
                "type": "::",
                "args": ["OCA\\News\\Controller\\FeedController", "read", {
                        "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                    }, {
                        "feedId": "135",
                        "_route": "news.feed.read"
                    }
                ]
            }, {
                "file": "/var/www/cloud/lib/base.php",
                "line": 1008,
                "function": "match",
                "class": "OC\\Route\\Router",
                "type": "->",
                "args": ["/apps/news/feeds/135/read"]
            }, {
                "file": "/var/www/cloud/index.php",
                "line": 37,
                "function": "handleRequest",
                "class": "OC",
                "type": "::",
                "args": []
            }
        ],
        "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php",
        "Line": 106,
        "Previous": {
            "Exception": "Doctrine\\DBAL\\Driver\\PDOException",
            "Message": "SQLSTATE[HY093]: Invalid parameter number: no parameters were bound",
            "Code": "HY093",
            "Trace": [{
                    "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                    "line": 1064,
                    "function": "execute",
                    "class": "Doctrine\\DBAL\\Driver\\PDOStatement",
                    "type": "->",
                    "args": [[]]
                }, {
                    "file": "/var/www/cloud/lib/private/DB/Connection.php",
                    "line": 222,
                    "function": "executeUpdate",
                    "class": "Doctrine\\DBAL\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (NULL)", [], []]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                    "line": 194,
                    "function": "executeUpdate",
                    "class": "OC\\DB\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (:idList)", {
                            "unread": false,
                            "idList": []
                        }, {
                            "unread": 5,
                            "idList": 101
                        }
                    ]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                    "line": 357,
                    "function": "read",
                    "class": "OCA\\News\\Db\\FeedMapperV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 90032]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                    "line": 286,
                    "function": "read",
                    "class": "OCA\\News\\Service\\FeedServiceV2",
                    "type": "->",
                    "args": ["anoymouserver", 135, 90032]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 169,
                    "function": "read",
                    "class": "OCA\\News\\Controller\\FeedController",
                    "type": "->",
                    "args": [135, 90032]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 100,
                    "function": "executeController",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                    "line": 152,
                    "function": "dispatch",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/Route/Router.php",
                    "line": 309,
                    "function": "main",
                    "class": "OC\\AppFramework\\App",
                    "type": "::",
                    "args": ["OCA\\News\\Controller\\FeedController", "read", {
                            "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                        }, {
                            "feedId": "135",
                            "_route": "news.feed.read"
                        }
                    ]
                }, {
                    "file": "/var/www/cloud/lib/base.php",
                    "line": 1008,
                    "function": "match",
                    "class": "OC\\Route\\Router",
                    "type": "->",
                    "args": ["/apps/news/feeds/135/read"]
                }, {
                    "file": "/var/www/cloud/index.php",
                    "line": 37,
                    "function": "handleRequest",
                    "class": "OC",
                    "type": "::",
                    "args": []
                }
            ],
            "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
            "Line": 129,
            "Previous": {
                "Exception": "PDOException",
                "Message": "SQLSTATE[HY093]: Invalid parameter number: no parameters were bound",
                "Code": "HY093",
                "Trace": [{
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
                        "line": 127,
                        "function": "execute",
                        "class": "PDOStatement",
                        "type": "->",
                        "args": [[]]
                    }, {
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                        "line": 1064,
                        "function": "execute",
                        "class": "Doctrine\\DBAL\\Driver\\PDOStatement",
                        "type": "->",
                        "args": [[]]
                    }, {
                        "file": "/var/www/cloud/lib/private/DB/Connection.php",
                        "line": 222,
                        "function": "executeUpdate",
                        "class": "Doctrine\\DBAL\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (NULL)", [], []]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                        "line": 194,
                        "function": "executeUpdate",
                        "class": "OC\\DB\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (:idList)", {
                                "unread": false,
                                "idList": []
                            }, {
                                "unread": 5,
                                "idList": 101
                            }
                        ]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                        "line": 357,
                        "function": "read",
                        "class": "OCA\\News\\Db\\FeedMapperV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 90032]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                        "line": 286,
                        "function": "read",
                        "class": "OCA\\News\\Service\\FeedServiceV2",
                        "type": "->",
                        "args": ["anoymouserver", 135, 90032]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 169,
                        "function": "read",
                        "class": "OCA\\News\\Controller\\FeedController",
                        "type": "->",
                        "args": [135, 90032]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 100,
                        "function": "executeController",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                        "line": 152,
                        "function": "dispatch",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/Route/Router.php",
                        "line": 309,
                        "function": "main",
                        "class": "OC\\AppFramework\\App",
                        "type": "::",
                        "args": ["OCA\\News\\Controller\\FeedController", "read", {
                                "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                            }, {
                                "feedId": "135",
                                "_route": "news.feed.read"
                            }
                        ]
                    }, {
                        "file": "/var/www/cloud/lib/base.php",
                        "line": 1008,
                        "function": "match",
                        "class": "OC\\Route\\Router",
                        "type": "->",
                        "args": ["/apps/news/feeds/135/read"]
                    }, {
                        "file": "/var/www/cloud/index.php",
                        "line": 37,
                        "function": "handleRequest",
                        "class": "OC",
                        "type": "::",
                        "args": []
                    }
                ],
                "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
                "Line": 127
            }
        },
        "CustomMessage": "--"
    },
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0",
    "version": "20.0.8.1",
    "id": "606194047ec7f"
}

/***** mark folder as read *****/
{
    "reqId": "SyG9oCccl2vnjolsL5eN",
    "level": 3,
    "time": "2021-03-29T08:51:05+00:00",
    "remoteAddr": "127.0.0.1",
    "user": "anoymouserver",
    "app": "index",
    "method": "POST",
    "url": "/apps/news/feeds/120/read",
    "message": {
        "Exception": "Doctrine\\DBAL\\Exception\\DriverException",
        "Message": "An exception occurred while executing 'UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)' with params [66512, 66513, 66514, 66515, 66516, 66517, 66518, 66519, 66520, 66521, 66522, 66523, 66524, 66525, 66526, 66527, 66528, 77287, 90032]:\n\nSQLSTATE[HY093]: Invalid parameter number: mixed named and positional parameters",
        "Code": 0,
        "Trace": [{
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 169,
                "function": "convertException",
                "class": "Doctrine\\DBAL\\Driver\\AbstractMySQLDriver",
                "type": "->",
                "args": ["An exception occurred while executing 'UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)' with params [66512, 66513, 66514, 66515, 66516, 66517, 66518, 66519, 66520, 66521, 66522, 66523, 66524, 66525, 66526, 66527, 66528, 77287, 90032]:\n\nSQLSTATE[HY093]: Invalid parameter number: mixed named and positional parameters", {
                        "errorInfo": ["HY093", 0],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }
                ]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
                "line": 149,
                "function": "wrapException",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["HY093", 0],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "An exception occurred while executing 'UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)' with params [66512, 66513, 66514, 66515, 66516, 66517, 66518, 66519, 66520, 66521, 66522, 66523, 66524, 66525, 66526, 66527, 66528, 77287, 90032]:\n\nSQLSTATE[HY093]: Invalid parameter number: mixed named and positional parameters"]
            }, {
                "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                "line": 1071,
                "function": "driverExceptionDuringQuery",
                "class": "Doctrine\\DBAL\\DBALException",
                "type": "::",
                "args": [{
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
                    }, {
                        "errorInfo": ["HY093", 0],
                        "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
                    }, "UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)", {
                        "1": 66512,
                        "2": 66513,
                        "3": 66514,
                        "4": 66515,
                        "5": 66516,
                        "6": 66517,
                        "7": 66518,
                        "8": 66519,
                        "9": 66520,
                        "10": 66521,
                        "11": 66522,
                        "12": 66523,
                        "13": 66524,
                        "14": 66525,
                        "15": 66526,
                        "16": 66527,
                        "17": 66528,
                        "18": 77287,
                        "19": 90032
                    }
                ]
            }, {
                "file": "/var/www/cloud/lib/private/DB/Connection.php",
                "line": 222,
                "function": "executeUpdate",
                "class": "Doctrine\\DBAL\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)", [66512, 66513, 66514, 66515, 66516, 66517, 66518, 66519, 66520, 66521, 66522, 66523, 66524, 66525, 66526, 66527, 66528, 77287, 90032], [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                "line": 194,
                "function": "executeUpdate",
                "class": "OC\\DB\\Connection",
                "type": "->",
                "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (:idList)", {
                        "unread": false,
                        "idList": [66512, 66513, 66514, 66515, 66516, 66517, 66518, 66519, 66520, 66521, 66522, 66523, 66524, 66525, 66526, 66527, 66528, 77287, 90032]
                    }, {
                        "unread": 5,
                        "idList": 101
                    }
                ]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                "line": 357,
                "function": "read",
                "class": "OCA\\News\\Db\\FeedMapperV2",
                "type": "->",
                "args": ["anoymouserver", 120, 90032]
            }, {
                "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                "line": 286,
                "function": "read",
                "class": "OCA\\News\\Service\\FeedServiceV2",
                "type": "->",
                "args": ["anoymouserver", 120, 90032]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 169,
                "function": "read",
                "class": "OCA\\News\\Controller\\FeedController",
                "type": "->",
                "args": [120, 90032]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 100,
                "function": "executeController",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                "line": 152,
                "function": "dispatch",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [{
                        "__class__": "OCA\\News\\Controller\\FeedController"
                    }, "read"]
            }, {
                "file": "/var/www/cloud/lib/private/Route/Router.php",
                "line": 309,
                "function": "main",
                "class": "OC\\AppFramework\\App",
                "type": "::",
                "args": ["OCA\\News\\Controller\\FeedController", "read", {
                        "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                    }, {
                        "feedId": "120",
                        "_route": "news.feed.read"
                    }
                ]
            }, {
                "file": "/var/www/cloud/lib/base.php",
                "line": 1008,
                "function": "match",
                "class": "OC\\Route\\Router",
                "type": "->",
                "args": ["/apps/news/feeds/120/read"]
            }, {
                "file": "/var/www/cloud/index.php",
                "line": 37,
                "function": "handleRequest",
                "class": "OC",
                "type": "::",
                "args": []
            }
        ],
        "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php",
        "Line": 106,
        "Previous": {
            "Exception": "Doctrine\\DBAL\\Driver\\PDOException",
            "Message": "SQLSTATE[HY093]: Invalid parameter number: mixed named and positional parameters",
            "Code": "HY093",
            "Trace": [{
                    "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                    "line": 1062,
                    "function": "execute",
                    "class": "Doctrine\\DBAL\\Driver\\PDOStatement",
                    "type": "->",
                    "args": []
                }, {
                    "file": "/var/www/cloud/lib/private/DB/Connection.php",
                    "line": 222,
                    "function": "executeUpdate",
                    "class": "Doctrine\\DBAL\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)", [66512, 66513, 66514, 66515, 66516, 66517, 66518, 66519, 66520, 66521, 66522, 66523, 66524, 66525, 66526, 66527, 66528, 77287, 90032], [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                    "line": 194,
                    "function": "executeUpdate",
                    "class": "OC\\DB\\Connection",
                    "type": "->",
                    "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (:idList)", {
                            "unread": false,
                            "idList": [66512, 66513, 66514, 66515, 66516, 66517, 66518, 66519, 66520, 66521, 66522, 66523, 66524, 66525, 66526, 66527, 66528, 77287, 90032]
                        }, {
                            "unread": 5,
                            "idList": 101
                        }
                    ]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                    "line": 357,
                    "function": "read",
                    "class": "OCA\\News\\Db\\FeedMapperV2",
                    "type": "->",
                    "args": ["anoymouserver", 120, 90032]
                }, {
                    "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                    "line": 286,
                    "function": "read",
                    "class": "OCA\\News\\Service\\FeedServiceV2",
                    "type": "->",
                    "args": ["anoymouserver", 120, 90032]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 169,
                    "function": "read",
                    "class": "OCA\\News\\Controller\\FeedController",
                    "type": "->",
                    "args": [120, 90032]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                    "line": 100,
                    "function": "executeController",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                    "line": 152,
                    "function": "dispatch",
                    "class": "OC\\AppFramework\\Http\\Dispatcher",
                    "type": "->",
                    "args": [{
                            "__class__": "OCA\\News\\Controller\\FeedController"
                        }, "read"]
                }, {
                    "file": "/var/www/cloud/lib/private/Route/Router.php",
                    "line": 309,
                    "function": "main",
                    "class": "OC\\AppFramework\\App",
                    "type": "::",
                    "args": ["OCA\\News\\Controller\\FeedController", "read", {
                            "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                        }, {
                            "feedId": "120",
                            "_route": "news.feed.read"
                        }
                    ]
                }, {
                    "file": "/var/www/cloud/lib/base.php",
                    "line": 1008,
                    "function": "match",
                    "class": "OC\\Route\\Router",
                    "type": "->",
                    "args": ["/apps/news/feeds/120/read"]
                }, {
                    "file": "/var/www/cloud/index.php",
                    "line": 37,
                    "function": "handleRequest",
                    "class": "OC",
                    "type": "::",
                    "args": []
                }
            ],
            "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
            "Line": 129,
            "Previous": {
                "Exception": "PDOException",
                "Message": "SQLSTATE[HY093]: Invalid parameter number: mixed named and positional parameters",
                "Code": "HY093",
                "Trace": [{
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
                        "line": 127,
                        "function": "execute",
                        "class": "PDOStatement",
                        "type": "->",
                        "args": [null]
                    }, {
                        "file": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
                        "line": 1062,
                        "function": "execute",
                        "class": "Doctrine\\DBAL\\Driver\\PDOStatement",
                        "type": "->",
                        "args": []
                    }, {
                        "file": "/var/www/cloud/lib/private/DB/Connection.php",
                        "line": 222,
                        "function": "executeUpdate",
                        "class": "Doctrine\\DBAL\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)", [66512, 66513, 66514, 66515, 66516, 66517, 66518, 66519, 66520, 66521, 66522, 66523, 66524, 66525, 66526, 66527, 66528, 77287, 90032], [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Db/FeedMapperV2.php",
                        "line": 194,
                        "function": "executeUpdate",
                        "class": "OC\\DB\\Connection",
                        "type": "->",
                        "args": ["UPDATE `oc_news_items` SET `unread` = `:unread` WHERE id IN (:idList)", {
                                "unread": false,
                                "idList": [66512, 66513, 66514, 66515, 66516, 66517, 66518, 66519, 66520, 66521, 66522, 66523, 66524, 66525, 66526, 66527, 66528, 77287, 90032]
                            }, {
                                "unread": 5,
                                "idList": 101
                            }
                        ]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Service/FeedServiceV2.php",
                        "line": 357,
                        "function": "read",
                        "class": "OCA\\News\\Db\\FeedMapperV2",
                        "type": "->",
                        "args": ["anoymouserver", 120, 90032]
                    }, {
                        "file": "/var/www/cloud/apps/news/lib/Controller/FeedController.php",
                        "line": 286,
                        "function": "read",
                        "class": "OCA\\News\\Service\\FeedServiceV2",
                        "type": "->",
                        "args": ["anoymouserver", 120, 90032]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 169,
                        "function": "read",
                        "class": "OCA\\News\\Controller\\FeedController",
                        "type": "->",
                        "args": [120, 90032]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/Http/Dispatcher.php",
                        "line": 100,
                        "function": "executeController",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/AppFramework/App.php",
                        "line": 152,
                        "function": "dispatch",
                        "class": "OC\\AppFramework\\Http\\Dispatcher",
                        "type": "->",
                        "args": [{
                                "__class__": "OCA\\News\\Controller\\FeedController"
                            }, "read"]
                    }, {
                        "file": "/var/www/cloud/lib/private/Route/Router.php",
                        "line": 309,
                        "function": "main",
                        "class": "OC\\AppFramework\\App",
                        "type": "::",
                        "args": ["OCA\\News\\Controller\\FeedController", "read", {
                                "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                            }, {
                                "feedId": "120",
                                "_route": "news.feed.read"
                            }
                        ]
                    }, {
                        "file": "/var/www/cloud/lib/base.php",
                        "line": 1008,
                        "function": "match",
                        "class": "OC\\Route\\Router",
                        "type": "->",
                        "args": ["/apps/news/feeds/120/read"]
                    }, {
                        "file": "/var/www/cloud/index.php",
                        "line": 37,
                        "function": "handleRequest",
                        "class": "OC",
                        "type": "::",
                        "args": []
                    }
                ],
                "File": "/var/www/cloud/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
                "Line": 127
            }
        },
        "CustomMessage": "--"
    },
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0",
    "version": "20.0.8.1",
    "id": "606194f9a9133"
}

Issue nextcloudGH-1211

Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
@SMillerDev SMillerDev force-pushed the fix/mapper/update_uses_setvalues branch from 0efa751 to d51b4a0 Compare March 30, 2021 12:32
@SMillerDev
Copy link
Contributor Author

Good old SQLite strikes again, apparently it was writing :unread as a boolean value to my database without so much as a message about it.

Copy link
Contributor

@anoymouserver anoymouserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works finally! 👍

@SMillerDev SMillerDev merged commit 78dce7f into nextcloud:master Mar 31, 2021
Grotax added a commit that referenced this pull request Apr 3, 2021
Changed
- Add BATS as integration tests (#1213)
- Update FeedFetcher to import categories from feeds (#1248)
- Update serialization of item to include categories (#1248)
- Make PHPStan stricter (#955)
- Search: Add folder search (#1215)
- Improve test coverage (#1263)
- Allow directly adding a feed without going through the discovery process (#1265)

Fixed
- Do not show deleted feeds in item list (#1214)
- Fix update queries (#1211)
@Grotax Grotax mentioned this pull request Apr 3, 2021
Grotax added a commit that referenced this pull request Apr 3, 2021
Changed
- Add BATS as integration tests (#1213)
- Update FeedFetcher to import categories from feeds (#1248)
- Update serialization of item to include categories (#1248)
- Make PHPStan stricter (#955)
- Search: Add folder search (#1215)
- Improve test coverage (#1263)
- Allow directly adding a feed without going through the discovery process (#1265)

Fixed
- Do not show deleted feeds in item list (#1214)
- Fix update queries (#1211)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this pull request Apr 3, 2021
Changed
- Add BATS as integration tests (#1213)
- Update FeedFetcher to import categories from feeds (#1248)
- Update serialization of item to include categories (#1248)
- Make PHPStan stricter (#955)
- Search: Add folder search (#1215)
- Improve test coverage (#1263)
- Allow directly adding a feed without going through the discovery process (#1265)

Fixed
- Do not show deleted feeds in item list (#1214)
- Fix update queries (#1211)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Neo11 pushed a commit to Neo11/news that referenced this pull request May 28, 2022
Changed
- Add BATS as integration tests (nextcloud#1213)
- Update FeedFetcher to import categories from feeds (nextcloud#1248)
- Update serialization of item to include categories (nextcloud#1248)
- Make PHPStan stricter (nextcloud#955)
- Search: Add folder search (nextcloud#1215)
- Improve test coverage (nextcloud#1263)
- Allow directly adding a feed without going through the discovery process (nextcloud#1265)

Fixed
- Do not show deleted feeds in item list (nextcloud#1214)
- Fix update queries (nextcloud#1211)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Impact API/Backend code bug patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

15.4.0-beta2: internal server errors when marking feed as read
4 participants