fix: Shared folder check #1263
Merged
fix: Shared folder check #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <kate@provokateurin.de>
|
@juliushaertl if possible this should be released as 4.9.4 because 4.9.3 is currently broken. |
juliushaertl
approved these changes
Mar 28, 2024
|
Sure, I'll spin another release with that. Thanks for the fix 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Call to a member function isShared() on null in file '/usr/src/nextcloud/apps/notes/lib/Service/NoteUtil.php' line 171introduced by #1260.This is triggered when the user has no notes folder yet and opens the dashboard (at least that was how I triggered it).