Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid conflicts on notes folder creation #1260

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

juliusknorr
Copy link
Member

No description provided.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Mar 27, 2024
@juliusknorr juliusknorr merged commit 2f66178 into main Mar 27, 2024
7 of 9 checks passed
@juliusknorr juliusknorr deleted the fix/notes-folder-conflict branch March 27, 2024 15:22
@Waltibaba
Copy link

Waltibaba commented May 6, 2024

This breaks the Notes app when the parent is a shared folder.
The process goes:

  • If selected folder is shared, create new folder.
  • Newly created folder is shared (since the parent is shared), so it may not be used -> create new folder.

On a fast system that syncs often, this just creates hundreds of new folders in minutes.
This caused #1266

@enismaholli
Copy link

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants