Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow using shared notes folder #1296

Closed

Conversation

SimeonEhrig
Copy link

Enables the use of a shared folder as a notes folder. Reverts PR #1260 as it is not clear what the problem was and using a shared notes folder is a feature that many users use: #1266

Signed-off-by: simeon <simeonehrig@web.de>
@LMRW
Copy link

LMRW commented Jun 2, 2024

Please I would love to see this fix merged in!

@LMRW
Copy link

LMRW commented Jun 2, 2024

Can I help get this merged? Let me know if I can help.

This would fix a critical issue for me which i've spent a lot of time on

@LMRW
Copy link

LMRW commented Jun 9, 2024

What can we do to fix this to be merged in please?

Its a fix for a show stopping bug that breaks a critical feature

Its also old tested code used before which was removed and would be put back, so its battle tested

Please there seems to be no good reason to not merge this in now

@SimeonEhrig
Copy link
Author

Any progress here?

@areteichi
Copy link

@juliushaertl
Can you please give us feedback?

@juliushaertl
Copy link
Member

Thanks for the pull request, unfortunately this reintroduces an issue where users without a notes folder could end up with their notes in an incoming share by accident. I've pushed a different approach to the fix to #1320 that I'll try to finish up asap and do a new release then.

@SimeonEhrig
Copy link
Author

close because PR #1320 solved the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use shared folder for notes anymore.
5 participants