Fix style of notification #10
Conversation
* normal line-height * no gray background on hover * underline on hover to detect that it is clickable * pull primary buttons to right * white color for primary button instead of grey (looked disabled) * for nextcloud/server#735
|
@jancborchardt I'm still not 100% sure about the text styling ...could you have a look at this? |
|
@MorrisJobke I would prefer the text being in grey and black on hover, as there is no underline on hover elsewhere in Nextcloud. Could you also adjust the padding of the notification to make it equal on each side? |
Sure :) Sorry I didn't noticed that.
Let me try this. |
* align close button with other paddings in notification container * text is gray by default * text is black on hover to indicate link
|
Hovered: Looks good :) |
|
Last version looks much better 👍 |
|
nice 👍 |
|
stable10: #11 |
|
While the line spacing was way to much in the original, I feel that it's been reduced by just a bit too much for the after, making it feel a bit cramped. Not by much. I'd shift just maybe 10% of the way back towards the after. Can I ask what the before / after versions were using for line spacing? Totally agree 100% with using black instead of underline for hover, btw. |
2,5em before and then normal after (I guess this is something like 1,1em or 1,2em - I couldn't find the exact value). |
Before: 2,5em Should I change it to 1,6em? |
See #13 |
Before:
After:
hovered state
Before:
After:
cc @nextcloud/designers @schiessle @rullzer @LukasReschke