Update 2.1.0 on 27.1.6 makes all office files unusable... #521
Comments
Dennis1993
changed the title
|
Same here |
|
Same here! App is broken after the update 🙉 |
|
I cannot reproduce that. Could you check your configured office server url and try to save it again to see if that makes a difference? |
|
I already tried that. Even removed the app and reinstalled it
…On Mon, Feb 19, 2024, 13:20 Julius Härtl ***@***.***> wrote:
I cannot reproduce that. Could you check your configured office server url
and try to save it again to see if that makes a difference?
—
Reply to this email directly, view it on GitHub
<#521 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4IOFPTHNNIN4OZ6ZVDKLLTYUMYQNAVCNFSM6AAAAABDMTUE32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSGIZTQNJRHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Same problem. The config has a green check and says all is ok. in the browser log I see the undefined again: |
|
Same problem here Downgrade to 2.0.3 resolved issue for us |
|
Our system is
PHP
Version: 8.1.23
Memory limit: 1 GB
Max execution time: 3600
Upload max size: 10 GB
Extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, json,
Reflection, SPL, session, standard, sodium, cgi-fcgi, mysqlnd, PDO, xml,
apcu, bcmath, bz2, calendar, ctype, curl, dom, mbstring, FFI, fileinfo,
ftp, gd, gettext, gmp, iconv, igbinary, imagick, intl, ldap, exif, mysqli,
pdo_mysql, Phar, posix, readline, redis, shmop, SimpleXML, smbclient,
sockets, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl,
zip, libsmbclient, Zend OPcache
Database
Type: mysql
Version: 10.11.1
Size: 3 GB
Operating System:
Linux 5.15.0-94-generic x86_64
may be this helps you to replicate problem
and here ih. config.php
<?php
$CONFIG = array (
'passwordsalt' => 'XXX',
'secret' => 'XXX',
'trusted_domains' =>
array (
0 => 'XXX',
1 => 'XXX',
),
'datadirectory' => '/home/data',
'dbtype' => 'mysql',
'version' => '27.1.6.2',
'overwrite.cli.url' => 'https://XXX',
'dbname' => 'XXX',
'dbhost' => 'localhost',
'dbport' => '',
'dbtableprefix' => 'oc_',
'mysql.utf8mb4' => true,
'dbuser' => 'XXX',
'dbpassword' => 'XXX',
'installed' => true,
'instanceid' => 'XXX',
'activity_expire_days' => 14,
'auth.bruteforce.protection.enabled' => true,
'blacklisted_files' =>
array (
0 => '.htaccess',
1 => 'Thumbs.db',
2 => 'thumbs.db',
),
'cron_log' => true,
'default_phone_region' => 'TR',
'enable_previews' => true,
'enabledPreviewProviders' =>
array (
0 => 'OC\\Preview\\PNG',
1 => 'OC\\Preview\\JPEG',
2 => 'OC\\Preview\\GIF',
3 => 'OC\\Preview\\BMP',
4 => 'OC\\Preview\\XBitmap',
5 => 'OC\\Preview\\Movie',
6 => 'OC\\Preview\\PDF',
7 => 'OC\\Preview\\MP3',
8 => 'OC\\Preview\\TXT',
9 => 'OC\\Preview\\MarkDown',
10 => 'OC\\Preview\\Image',
11 => 'OC\\Preview\\HEIC',
12 => 'OC\\Preview\\TIFF',
),
'filesystem_check_changes' => 1,
'filelocking.enabled' => 'true',
'htaccess.RewriteBase' => '/',
'integrity.check.disabled' => false,
'knowledgebaseenabled' => false,
'log_rotate_size' => 104857600,
'logfile' => '/var/log/nextcloud/nextcloud.log',
'loglevel' => 2,
'logtimezone' => 'Europe/Helsinki',
'memcache.local' => '\\OC\\Memcache\\APCu',
'memcache.locking' => '\\OC\\Memcache\\Redis',
'overwriteprotocol' => 'https',
'preview_max_x' => 1024,
'preview_max_y' => 768,
'preview_max_scale_factor' => 1,
'redis' =>
array (
'host' => '/var/run/redis/redis-server.sock',
'port' => 0,
'timeout' => 0.0,
),
'quota_include_external_storage' => false,
'share_folder' => '/Releases',
'skeletondirectory' => '',
'trashbin_retention_obligation' => 'auto, 7',
'mail_from_address' => 'dr',
'mail_smtpdebug' => false,
'mail_smtpmode' => 'smtp',
'mail_sendmailmode' => 'smtp',
'mail_domain' => 'XXX',
'mail_smtphost' => 'XXX',
'mail_smtpport' => 'XXX',
'maintenance' => false,
'theme' => '',
'updater.release.channel' => 'stable',
'app_install_overwrite' =>
array (
0 => 'scanner',
1 => 'impersonate', 6 => 'cms_pico',
7 => 'files_downloadactivity',
),
'mail_smtpauth' => 1,
'mail_smtpname' => 'XXX',
'mail_smtppassword' => 'XXX',
'ldapProviderFactory' => 'OCA\\User_LDAP\\LDAPProviderFactory',
'memories.exiftool' =>
'/var/www/nextcloud/apps/memories/bin-ext/exiftool-amd64-glibc',
'memories.vod.path' =>
'/var/www/nextcloud/apps/memories/bin-ext/go-vod-amd64',
'memories.vod.ffmpeg' => '/usr/bin/ffmpeg',
'memories.vod.ffprobe' => '/usr/bin/ffprobe',
'memories.gis_type' => 1,
);
2 => 'files_archive',
3 => 'transfer',
4 => 'files_fulltextsearch',
5 => 'talk_matterbridge',
…On Mon, Feb 19, 2024 at 1:53 PM Phaere ***@***.***> wrote:
Same problem here
Docs cannot be opened if shared by public link
Docs shared to user internally opens with no problem
Downgrade to 2.0.3 resolved issue for us
—
Reply to this email directly, view it on GitHub
<#521 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4IOFPS44C4YR5VW2UEGQBTYUM4M7AVCNFSM6AAAAABDMTUE32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSGI4TCNRWHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Same problem, but only in edge. In edge i see this in "inspect" - "console" tab: |
|
Some problem with Edge,Opera |
|
You can downgrade to the old version. Are you also using v27.1.6? :) |
|
It seems that the issue persists in Nextcloud version 28.0.2, and you are unable to downgrade the version of the 'officeonline' app. The problem specifically occurs with external public shares, while internal links & shares are functioning correctly.
|
|
Hi, It seems that commenting line 384 in lib/Controller/DocumentController.php, which is allowInlineScripts(true) (all by memory, sorry) concerning the "public" function removes the error. The method does not exists anymore. I did not need to comment the other similar lines but this one "helps" for the public issue. |
Thank you for your support. I completely removed this part on line 384 and the problem with public links was solved 👏 |
|
@juliushaertl is that a quick and good solution for us to publish a new version quickly? :) |
|
Thanks all for reporting and providing this additional insight. I will need to check this in further depth as for Nextcloud 28 the method was actually dropped and then there seems to be an issue with edge. I have an idea how to resolve that, just needs some more testing. For now, everyone on 27 and below can just add that line back which is a reasonable fix. For people on 28, I'll drop a message here when I have a testable patch. Follow up release will then happen as soon as possible of course as well. |
|
Thank you very much @juliushaertl for your great work! |
|
I pushed a fix for this in nextcloud/server#43778 but also a workaround for officeonline at 0e80d36 If anyone can help testing this, that would be highly appreciated. You can apply the patch on top of the 2.1.0 release with the following commands: |
|
Tried the patch. It still doesnt work as it should. In edge i get a 404 not found from the nextcloud instance. |
|
I can try some more later this afternoon. I can only reach this system by teamviewer. |
|
For me it is on both internal documents as well as external links |
@juliushaertl The patch and the workaround did not work on its own. But with the patch to nextcloud core it does work. Do you think it can be added to 28.0.3 ? |
Hi Julius, I made the changes (but by hand, I had some fails with the patch) and hope I didn't miss anything. Here what I can tell:
It looks like pretty promising! I also want to mention that there is another "old" allowInlineScript in lib/DirectEditing/DirectEditor.php. |
|
Thanks ! That might be just because DocumentController.php was not the original because I commented lines. |
|
And I don't have any issue anymore on empty docs... So as far I can tell, everything seems to work concerning this issue for me. Edit : at least on NC 28.0.2 with officeonline 2.1.0 |
|
I have updated our system to 28.0.3 to see if problem will be resolved but still the same problem "Error 404 The page could not be found on the server." then I have noticed that system overview says "Some files have not passed the integrity check. [List of invalid files] [officeonline] => Array and below one (but I am not sure if it is related with office online integration or not) "Your webserver does not serve Now I had to switch back to 27.1.6 where everything is working fine. note. I have tried the office patched but nothing changed. |
|
I patched this file 0e80d36 in my 27.1.7 install but nothing changed. Error 404 again. :(
|
|
Seems like you still need the nextcloud server patch AND you need the patch for office online. There is no possibility to patch just one part. I have not tested with 28.0.3 and after checking the patch for nextcloud server itself is not in 28.0.3. So to get 28.0.3 apply the server patch and the office online patch. |
|
how do you patch the nextcloud core? cd /var/www/nextcloud/apps/officeonline |
|
Unfortunately, we have the same problem with our 27.1.7. |
There might be a possibilty to check whats needed to get it to work in 27.1.7. @Misu4 What apps are keeping you from going to 28.0.3? |
We use the markdown editor, the metadata addon and the heic image converter. Important is the markdown editor. |
|
Is there a solution for the next NextCloud update to 28.0.4 that we can finally use again? Unfortunately, I don't know what we're waiting for at the moment. Thanks |
|
I assume we are waiting for developers to have some spare time to fix the issue for the benefit of affected community =) |
|
Any info on the Nextcloud core patch mentioned above ? , I want to try the fix while waiting for Nextcloud 28.0.4 to be released , also any news if the fix will be in next version of Office Online app and when that will be ? |
cd apps/officeonline You need those three @robake1 |
Thanks for the answer @small1 , will look at those . A bit new on Github to find the files for each but will try it :) |
|
Anyone tested this version in 28.0.4? |
|
I havent tried it yet but changelog says that So i assume if you do 0e80d36 by and office online patch it should work by let us know if any of you give it a try |
|
Short feedback: I updated my instance to 28.0.4 and without touching a file it is working. I can open and create new files 👍 |
|
Using |
|
Without change any files it is working but my Log is spammed: |
|
Ok I patched the file 0e80d36 because shares not working. Now it works fine! 😍 @juliushaertl can you create a new version of this app, please? With 28.0.4 and the patched file it works fine. |
Describe the bug
I'm using NextCloud 27.1.6 and in the app store an update for this app was offered. After the update I can't open a document. All files are shown this error:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Opens the document to edit it
Screenshots
Client details:
Server details
Operating system:
Ubuntu 20.04
Web server:
Apache 2.4.58
Database:
MariaDB 10
PHP version:
PHP 8.2
Nextcloud version:
27.1.6
Version of the officeonline app
2.1.0
Version of Office Online server
latest
Logs
Nextcloud log (data/nextcloud.log)
Browser log
The text was updated successfully, but these errors were encountered: