Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: File creation on Nextcloud 28 #519

Merged
merged 2 commits into from Feb 15, 2024
Merged

fix: File creation on Nextcloud 28 #519

merged 2 commits into from Feb 15, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Feb 14, 2024

Adapting the file creating process to the new backend API as the old JS API was removed for 28. This still works for all compatible versions back to 24.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@@ -162,7 +168,7 @@ public function updateCSP() {
}
}
} catch (\Throwable $e) {
\OCP\Server::get(LoggerInterface::class)->warning('Failed to gather federation hosts for CSP', [
\OC::$server->query(LoggerInterface::class)->warning('Failed to gather federation hosts for CSP', [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need this still for 24 compatibility.

@juliushaertl juliushaertl added 3. to review Waiting for reviews bug Something isn't working labels Feb 15, 2024
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Did not test it though.

@blizzz
Copy link
Member

blizzz commented Feb 15, 2024

What Max said.

@juliushaertl juliushaertl merged commit 82f3691 into main Feb 15, 2024
28 checks passed
@juliushaertl juliushaertl deleted the feat/28 branch February 15, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants