Expire link shared credential after x views

nextcloud · Oct 4, 2016 · dbbe383 · dbbe383
1 parent e71a822
commit dbbe383
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 1 deletion.
diff --git a/controller/sharecontroller.php b/controller/sharecontroller.php
@@ -301,6 +301,16 @@ public function deleteShareRequest($share_request_id){
 	public function getPublicCredentialData($credential_guid) {
 		//@TODO if ExpireViews --, if 0 delete
 		//@TODO Check expire date
+		$acl = $this->shareService->getACL(null, $credential_guid);
+		$views = $acl->getExpireViews();
+		if($views === 0){
+			return new NotFoundResponse();
+		} else {
+			$views--;
+			$acl->setExpireViews($views);
+			$this->shareService->updateCredentialACL($acl);
+		}
+
 	    try {
             $credential = $this->shareService->getSharedItem(null, $credential_guid);
             return new JSONResponse($credential);

diff --git a/lib/Db/SharingACLMapper.php b/lib/Db/SharingACLMapper.php
@@ -69,6 +69,16 @@ public function getItemACL($user_id, $item_guid) {
         return $this->findEntity($q, $filter);
     }
 
+    /**
+     * Update the acl for a given item guid
+     * @param $user_id
+     * @param $item_guid
+     * @return SharingACL
+     */
+    public function updateCredentialACL(SharingACL $sharingACL) {
+        return $this->update($sharingACL);
+    }
+
     /**
      * Gets the currently accepted share requests from the given user for the given vault guid
      * @param $user_id

diff --git a/lib/Service/ShareService.php b/lib/Service/ShareService.php
@@ -107,6 +107,12 @@ public function getUserPendingRequests($user_id){
         return $this->shareRequest->getUserPendingRequests($user_id);
     }
 
+    /**
+     * Get shared credentials from a user
+     * @param $user_id
+     * @param $vault_guid
+	 * @return \OCA\Passman\Db\SharingACL[]
+     */
     public function getSharedItems($user_id, $vault_guid){
         $entries = $this->sharingACL->getVaultEntries($user_id, $vault_guid);
 
@@ -125,6 +131,16 @@ public function getSharedItems($user_id, $vault_guid){
         return $return;
     }
 
+   /*
+    * Gets the acl for a given item guid
+    * @param $user_id
+    * @param $item_guid
+    * @return SharingACL
+    */
+    public function getACL($user_id, $item_guid){
+		return $this->sharingACL->getItemACL($user_id, $item_guid);
+	}
+
     public function getSharedItem($user_id, $item_guid){
         $acl = $this->sharingACL->getItemACL($user_id, $item_guid);
 
@@ -219,12 +235,17 @@ public function deleteShareRequest(ShareRequest $request) {
 	}
 
 	/**
-	 * Get pending share requests by guid
+	 * Delete ACL
 	 *
 	 * @param  ShareRequest $request
 	 * @return \OCA\Passman\Db\ShareRequest[]
 	 */
 	public function deleteShareACL(SharingACL $ACL) {
 		return $this->sharingACL->deleteShareACL($ACL);
 	}
+
+
+	public function updateCredentialACL(SharingACL $sharingACL){
+		return $this->sharingACL->updateCredentialACL($sharingACL);
+	}
 }