Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] EnPass Support #159

Closed
rushsteve1 opened this issue Jan 1, 2017 · 23 comments
Closed

[Feature Request] EnPass Support #159

rushsteve1 opened this issue Jan 1, 2017 · 23 comments
Milestone

Comments

@rushsteve1
Copy link

EnPass is a free password manager that already supports syncing via Nextcloud/ownCloud/WebDAV, so having support for synced Databases would be an amazing feature to have.

@brantje
Copy link
Member

brantje commented Jan 2, 2017

Can you provide an example export file? Writing an importer won't be a problem.

@rushsteve1
Copy link
Author

EnPass exports its data as simple TXT files. Example:

Title : Google
Username : username
Email : username@gmail.com
Password : password123
Title : Social
Number : 123456789
Name : John Smith

It seems to break up each entry by the presence of a new Title and the label and data are separated by : with spaces.

@brantje
Copy link
Member

brantje commented Jan 2, 2017

Does EnPass has the ability to add custom fields?

@rushsteve1
Copy link
Author

Yes. I just went and checked.

@brantje
Copy link
Member

brantje commented Jan 4, 2017

Installed EnPass, after a few force closes i managed to create a csv export.

@animalillo animalillo added this to the V2 milestone Jan 11, 2017
@brantje brantje removed this from the V2 milestone Jan 11, 2017
@KeithIMyers
Copy link

KeithIMyers commented Jan 12, 2017

If it helps, here is an example of the CSV Export

"Title","Field","Value","Field","Value",.........,"Note"
"Site1","Login","MyUsername","Password","MyPassword,""
"Site2","Username","MyUsername,"Email","MyEMail","Password","SomePasswordGoesHere","URL","https://kmyers.me","TOTP","GoogleTOTPChallenge","Notes"

Edit : It seems like it would be best to do it from the Text Based Dump as this has all of the Custom Fields defined. All one would need to do is loop through the dump and use "Title" as an indicator of the start of a new entry.

Title : XX
Username : XXX
Email : XXX
Password : XXX
Title : XXX
Number : XXX
Name : XXX
TOTP : XXXX
Note : XXXX

@animalillo
Copy link
Collaborator

Could we get a full example file, with all the possible features of EnPass in use? If possible on both types of encoding.

We would only need a few entries, using all the feature of enpass

@brantje brantje added this to the V2.1 milestone Jan 14, 2017
@KeithIMyers
Copy link

Sure @animalillo - I will setup an enpass install and propagate it with some dummy data. Give me a few minutes to get this over to you.

@KeithIMyers
Copy link

Passman Sample Data from Enpass.zip

I created a new enpass bank and populated it with sample data. I then exported the data and zipped it up. I included the sample bank as well in the zip file (Enpass_Backup_2017-01-14_11-42-32.walletx). The password to import/decrypt this sample bank is "passman". The Enpass_2017-01-14_11-41-18.txt is the text export directly from Enpass.

I created multiple entries with different scenarios to allow you to see the inner workings. This includes a few custom fields and TOTP in a few cases. I made sure at least one entry in each category is "stock" so you can see the basics.

For some reason I could not see the option to do a CSV export, it may not be present in the portable version of enpass. I will try the installed version a bit later.

Let me know if you need anything further

@animalillo
Copy link
Collaborator

@KeithIMyers Thank you for the files!
Currently we are going to be focusing on getting v2 stable, and this importer will be added for v2.1 hopefully.
I've took a quick look at the files and, as a lot of reverse engineering would be needed to know the encoding, encryption methods and other details, as well as possible changes on future updated of their password manager of the walletx format we would use the CSV and/or the TXT exports from EnPass.

The export you've posted seems good to me, if you can manage to get a CSV export like this one too, it would be perfect!

Thank you!

@KeithIMyers
Copy link

Just wanted to give a small update for @animalillo - It seems that enPass is currently pushing an update to allow for secure attachments (a feature already in passman). I will be updating to the beta this week and will pull a set of new files with a few attachments so you can see if it is something that will work with passman.

@animalillo
Copy link
Collaborator

Thank you, it will be great to try to import everything available into passman @KeithIMyers

@brantje
Copy link
Member

brantje commented Feb 14, 2017

@KeithIMyers
Import is working
image

Can you describe the steps to create an export?
The custom fields in EnPass i copy to custom fields in passman, however there is no way of telling what field must be secret or not. Eg cvc code.

Small problem:
image
EnPass allows use of duplicate properties, not sure how i'm gonna tackle that one.

brantje added a commit that referenced this issue Feb 14, 2017
@brantje
Copy link
Member

brantje commented Feb 14, 2017

Feature is implemented in the v2.1.0 branch, if you want you can test it.

@KeithIMyers
Copy link

This is great news, I am very excited to see this happen

Can you describe the steps to create an export?

Of course:

  1. Access your Enpass Database
  2. Select "File" > "Export" > "As Text" (or as CSV depending on how PassMan will want to handle it)
  3. Enter your "Master Password" and you will be prompted for a location to save the database. This is an unencrypted database so it should be removed as soon as you import it into Passman

The custom fields in EnPass i copy to custom fields in passman, however there is no way of telling what field must be secret or not. Eg cvc code.
I do not see how this is marked in the export however one simple solution would be to maintain a list of common sensitive fields (cvc, credit card, etc). The user can mark other sensitive fields as needed.

brantje added a commit that referenced this issue Feb 14, 2017
brantje added a commit that referenced this issue Feb 14, 2017
@brantje
Copy link
Member

brantje commented Feb 14, 2017

Thanks, i've added the info.
At this moment the following fields will be made secret:
var secret_fields = ['cvc', 'pin', 'security answer']

brantje added a commit that referenced this issue Feb 14, 2017
brantje added a commit that referenced this issue Feb 14, 2017
@KeithIMyers
Copy link

@brantje
I just tested this in the V2.1.0 Branch and it went well. There is one issue however where the TOTP field seems to be creating a custom field (with the TOTP Secret) instead of importing it as the OTP Secret in Passman. I had to manually copy the value into the OTP secret on Passman. Other then that, it worked perfectly

@brantje
Copy link
Member

brantje commented Feb 15, 2017

Ouch, missed that one. Will define that as a special field, after we're done uploading the Android app source to GH.

@KeithIMyers
Copy link

Ouch, missed that one. Will define that as a special field, after we're done uploading the Android app source to GH.

Speaking of which @brantje - I just installed it a few minutes ago and it has a lot of potential. Still basic as you mentioned but I can honestly see this as a real contender to other password managers.

@animalillo
Copy link
Collaborator

:D glad you like the app! It's been a lot of hard work lately! I have just uploaded all the app code into github.

@brantje
Copy link
Member

brantje commented Feb 15, 2017

Thanks, you're welcome to join our mattermost (you can use the gitlab single sign on, from there sign in with your github account)
https://mattermost.passman.cc/signup_user_complete/?id=549o395qr7rxzk8pwje8e81cty

You are our first alpha tester 🎊

@brantje
Copy link
Member

brantje commented Feb 16, 2017

Fixed in 2.1

@brantje brantje closed this as completed Feb 16, 2017
@brantje
Copy link
Member

brantje commented Feb 17, 2017

@KeithIMyers TOTP fields are now detected on import. Added in 46ed638

brantje added a commit that referenced this issue Feb 17, 2017
    Fix share button, fix shared_key not added to storedCredential after sharing (Fixes #249)
    Add password app importer. Fixes #248
    Fix version check via proxy. Fixes #237
    Fix activity app not filtering. Fixes #246
    Add EnPass txt importer. Fixes #159
    Fix for disabled share button
    Require vault key for export. Fixes #199
    Indicate that sharing only works with users that have 1 or more vaults.
    Fixes #242
    Reset tags on logout. Fixes #245
    Ability to enter OTP secret manually. Fixes #198
    Create teampass importer. Fixes #244
passman-bot added a commit that referenced this issue Feb 17, 2017
    Lock vault after 3 wrong attempts (Fixes #197)
    Fix share button, fix shared_key not added to storedCredential after sharing (Fixes #249)
    Add password app importer. Fixes #248
    Fix version check via proxy. Fixes #237
    Fix activity app not filtering. Fixes #246
    Add EnPass txt importer. Fixes #159
    Fix for disabled share button
    Require vault key for export. Fixes #199
    Indicate that sharing only works with users that have 1 or more vaults.
    Fixes #242
    Reset tags on logout. Fixes #245
    Ability to enter OTP secret manually. Fixes #198
    Create teampass importer. Fixes #244

Signed-off-by: Passman Bot <info@passman.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants