Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PHP5.x from CI system for PRs for NextCloud 14 #497

Closed
vwbusguy opened this issue Sep 13, 2018 · 2 comments
Closed

Remove PHP5.x from CI system for PRs for NextCloud 14 #497

vwbusguy opened this issue Sep 13, 2018 · 2 comments

Comments

@vwbusguy
Copy link
Contributor

vwbusguy commented Sep 13, 2018 •
edited by jospoortvliet
Loading

NextCloud 14.0.0 only supports PHP 7.0, 7.1, and 7.2, but the CI system for Pull Requests is still attempting to test NextCloud against PHP 5.x. This is an invalid test case as NC17 no longer supports <PHP 7.0.

References:
@vwbusguy
Copy link
Contributor Author

Example of false positive failure as a result of this: https://travis-ci.org/nextcloud/passman/jobs/390034499

This was referenced Sep 13, 2018
Open
Merged
Merged
Closed
@vwbusguy
Copy link
Contributor Author

It looks like this has since been fixed. This may be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vwbusguy