Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Nextcloud 14 [$190 awarded] #491

Closed
juliushaertl opened this issue Aug 10, 2018 · 77 comments · Fixed by #502
Closed

Compatibility with Nextcloud 14 [$190 awarded] #491

juliushaertl opened this issue Aug 10, 2018 · 77 comments · Fixed by #502
Assignees
Labels
Milestone

Comments

@juliushaertl
Copy link
Member

juliushaertl commented Aug 10, 2018

Hi @brantje,

as you may have already seen, we have entered the beta phase for the release of Nextcloud 14. We try to keep up compatibility with older apps, but in some cases apps need some adjustments to properly work on new Nextcloud releases. With Nextcloud 14 there have been quite some changes in that regard:

You can find a list of all critical changes for app developers and admins at nextcloud/server#7827 You can run occ app:check-code to validate that there are no issues with deprecated or private message calls.

One critical change is the overall restructuring of the main template (nextcloud/server#9982) that might require some adjustments in your app.

We would be very pleased if you can make your app compatible with Nextcloud 14 and release a new version to the app store, so that users can properly test it and the upgrade experience to Nextcloud 14 will be even better than before.

Feel free to ask, if you have any questions regarding making your app compatible with Nextcloud 14.

Thanks for being part of the Nextcloud community and for all the effort you put into providing this app 🚀

Btw. you might have seen that starting August 25, the Nextcloud Conference takes place at the familiar TU Berlin. (https://nextcloud.com/conf/)! We'd like all contributors to be there and that most certainly includes you. You might already have registered but if you haven't - please consider joining us!


The $190 bounty on this issue has been claimed at Bountysource.

@vwbusguy
Copy link
Contributor

Nextcloud 14 was announced today and released RC, but Passman gets disabled on upgrade as of now.

@Kourai
Copy link

Kourai commented Sep 3, 2018

Any news on compatibility with Nextcloud 14 ?

@Heidistein
Copy link

The plugin works of you just club-footed increase the version in the app-info file.
There are some rendering issues, but you actually can see your passwords now.

@jospoortvliet jospoortvliet changed the title Compatibility with Nextcloud 14 Compatibility with Nextcloud 14 [$10] Sep 4, 2018
@vwbusguy
Copy link
Contributor

vwbusguy commented Sep 7, 2018

Nextcloud 14 was tagged for GA release today but sadly no compatibility update to passman yet.

@bstin
Copy link

bstin commented Sep 10, 2018

Yes, to flesh out what @Heidistein said, you can force to work by modifying the file:
/nextcloud/apps/passman/appinfo/info.xml
and change the line
<nextcloud min-version="9" max-version="13" />
to
<nextcloud min-version="9" max-version="14" />
It will work, although the rendering is little off. But you can at least access passwords this way until a final version is released.

@Putdeksel
Copy link

Putdeksel commented Sep 10, 2018

Not sure if this should be here but @bstin thank you, I was about to downgrade. I do have trouble finding that file though, it seems there is no passman folder in my /nextcloud/apps. Do you have any suggestions on where to look?

@tcassaert
Copy link

@Putdeksel You can find that file in your webroot, which is probably /var/www/nextcloud. From there you can navigate to apps/passman/appinfo/info.xml.

@Putdeksel
Copy link

Thank you for your reply @tcassaert. It seems that because I use the Techandme.se VM and their script to update instead of the traditional method in Nextcloud, unsupported apps are removed during the update. I've tried to copy the apps/passman/ folder that I found in the backup directory, into the var/www//nextcloud/apps directory and editing the info.xml file as suggested by @bstin but without any luck. Guess I'll have to restore my backup :( Thanks anyway!

@bstin
Copy link

bstin commented Sep 10, 2018

@Putdeksel

Just to add, after I edited info.xml I had to manually enable pasmman it in the list of apps. After you restored apps/passman directory back into the correct location, do you see it in list of apps?

@Putdeksel
Copy link

Putdeksel commented Sep 11, 2018

@bstin
Thank you for your reply. It did not show up in the list of apps so it got me thinking. Turns out the update script changed the backup passman directory ownership.
While in /var/www/nextcloud/apps I used chown -R www-data:www-data passman
Access to my passwords is restored. Thank you all for guiding me!

@himpierre
Copy link

Is there an official word from the maintainer? Will there be a nextcloud 14 version?

@ChildLearningClub
Copy link

Hope you have a paper copy of all your passwords in your back pocket ;)

@tcassaert
Copy link

From how it looks now, I don't think that will happen very soon. The latest "real" commit, apart from translation commits, already goes back to the first of April 2018.

@himpierre
Copy link

Oh dear. I guess i have to switch to another password manager.

@vwbusguy
Copy link
Contributor

Well, we could always fork it. I'd love to see this continue to be maintained. I've enjoyed the user experience so far. I'm willing to do some coding work but the maintainer seems MIA. I'm not sure it's worth putting in a PR if the maintainer won't even acknowledge stuff like this.

@vwbusguy
Copy link
Contributor

It looks like @brantje is active on GitHub - even today - just not here..

@vwbusguy
Copy link
Contributor

Looks like there was an update the the web extension today, so maybe there's hope? https://github.com/nextcloud/passman-webextension

@jospoortvliet jospoortvliet changed the title Compatibility with Nextcloud 14 [$10] Compatibility with Nextcloud 14 [$25] Sep 13, 2018
@synthead
Copy link

synthead commented Sep 13, 2018

If you need to get by, Passman still kinda works with a broken layout as-is on Nextcloud 14. Find where Passman is installed, then edit appinfo/info.xml. In there, you'll find this line:

        <nextcloud min-version="9" max-version="13" />

Change this to:

        <nextcloud min-version="9" max-version="14" />

This also seems to make the Passman API work, so the Android Passman app and the Passman extension (at least on Firefox) works just fine.

By the way, it'd be great to see compatibility for Nextcloud 14, so have a $15 bounty 😉

@Bubu
Copy link
Contributor

Bubu commented Sep 13, 2018 via email

@vwbusguy
Copy link
Contributor

Actually, I started doing the PR to find that the version has been bumped in this repo 6 months ago - it was just never pushed as a release to NextCloud:
https://github.com/nextcloud/passman/blob/master/appinfo/info.xml#L46

@vwbusguy
Copy link
Contributor

#497 is ultimately a blocker for this, since none of the PRs are passing tests since it's trying to test NC14 against PHP 5.x.

@vwbusguy
Copy link
Contributor

It looks like all @brantje would need to do is tag a release off of master and NC14 would work again without the hack.

@glukose
Copy link

glukose commented Sep 16, 2018

Hello,

I've also changed my version number in the file and was able to enable back the app in the admin panel.
However I can't access to my vaults through the web interface (password incorrect). The Firefox extension does open my vault but all the fields are set to 'false'. Labels of the credentials are not changed.
I successfully registered a new password through the Firefox extension though.

Anyone got the same problem ?
Is it possible I have deleted a file in my data/ directory of importance ? (I cleaned up files_thrashbin before the migration)

Cheers

@Oliv4945
Copy link
Collaborator

@glukose I used install from Git instructions, works well without editing anything.

Nevertheless I put some money in the bountysource, I hope it will motivate developers (@brantje ?) to continue & debug this useful app :)

@bstin
Copy link

bstin commented Sep 16, 2018

Hi @glukose

I have not had that problem. My password works, fields are fine, and Firefox extension works. For reference here is a listing of all files under my /var/www/nextcloud/apps/passman directory so you can compare against yours. These include the md5, so copy to your server where you should be able to theoretically test by running
cd /var/www/nextcloud/apps/passman (or wherever your apps live)

md5sum -c filename_md5.txt

Regards

Files:
passman_files_md5.txt

@MorrisJobke
Copy link
Member

Just to keep the people over here updated: it seems that some comments were a bit rougher than expected and we realized that we have a common goal. It seems that @newhinton will help @brantje and @animalillo to get Passman compatible with Nextcloud 14 within the near future.

Please also don't judge people too fast on the comments. Sometimes the feelings behind the words in here just get interpret the wrong way. We had a chat in the telegram group to exchange a bit more the feelings of each other. It's just hard to communicate always on point without leaving room for misunderstandings.

Respect each other and be kind to each other. ❤️

@gt2416
Copy link

gt2416 commented Oct 11, 2018

Just wanna say thank you for the project @brantje and @animalillo for passman.
We want to get it fixed asap cause passman is a CRITICAL piece of software for a user.
As a community I'm sure we all respect you and love your work, thanks again for your time.

@jospoortvliet jospoortvliet changed the title Compatibility with Nextcloud 14 [$145] Compatibility with Nextcloud 14 [$155] Oct 13, 2018
@jospoortvliet jospoortvliet changed the title Compatibility with Nextcloud 14 [$155] Compatibility with Nextcloud 14 [$175] Oct 14, 2018
@MagicFab
Copy link

MagicFab commented Oct 17, 2018

I think the baby grew up much faster than anticipated. It still needs nurturing and governance by more than one person, or it will die / fork.
Just like lack of signatures and lack of the ability to add contacts from emails in the Mail app, lack of passman, expiration of domain names, inability to communicate via the bug tracker with anxious users needs to be anticipated by Nextcloud - not only by its individual apps authors.
Until this app stops being managed and controlled by only one person only reachable effectively on Telegram, I will avoid it and advise others to also avoid it. Too bad the fork didn't happen, it would only have been better than the current situation.

Edit: clarified last paragraph, I meant to oppose single-dev control.

@Luticus
Copy link

Luticus commented Oct 17, 2018

The app isn't controlled by one person, it's controlled by two, now possibly three. I think we all need to take a step back and realize that pissing off the developers will not get your app updated faster. I completely understand how it is to develop something or create something and give it away for free only to have people turn around and get all demanding with it. I too am frustrated that I'm stuck on Nextcloud 13 until this app is updated for 14, but that only goes to show how important this app is. We need to understand that these guys are not paid developers, they are providing a free service. In the past the guys here have been really great and even implemented a fantastic feature I requested (vault destruction requests). While I do wish they would monitor github a bit better (that's where people generally file bug reports) and let us know they are still planning the keep the app alive, I'm certainly not going to demand anything. If you want the app done faster, increase the bounty, offer a pull request, or offer some other sort of help. Otherwise, do what I'm doing: wait patiently.

@souldessin
Copy link

souldessin commented Oct 23, 2018

So... apparently this needs to be said among some voices.

Thank you Devs!

Really; I like what you have built and look forward towards its continued development. I do have a password that I would like to get out of my vault soon, but it isn't dire that I get it right away (I would do the force install if it was). I can't am not an expert in what you have programmed, so, I am not able to contribute in way of code. Either way, I do hope that my thanks is good enough.

P.S. to the others. Don't piss off the guys that make the program that you put your passwords into, lol.

@AlvaroBrey
Copy link
Member

Question: if I upgraded my Nextcloud version to 14, and passman was disabled, is the stored data now lost?

@Depado
Copy link

Depado commented Oct 30, 2018

Question: if I upgraded my Nextcloud version to 14, and passman was disabled, is the stored data now lost?

No. If you updated Nextcloud and want to see your data anyway, you can do the steps that were mentionned earlier.

Note: This is a temporary fix while waiting for the real update of the app. Passman will have some display glitches but will work anyway.

Modify the file <nextcloud path>/apps/passman/appinfo/info.xml and change the line:

<nextcloud min-version="9" max-version="13" />

To

<nextcloud min-version="9" max-version="14" />

<nextcloud path> is the path where nextcloud is installed on your server. Some people just put it in /nextcloud, others (like me) store it in /var/www/nextcloud

Additionally you may check the permissions (and owner) of the passman directory and change it back to what it was before if it changed. chown -R www-data:www-data passman should do the trick. Check the other app directories if you're not sure about which user it should be owned by.

The next step is to go to your nextcloud instance, connect, go the your apps and enable Passman again.

(Credits to @bstin and @Putdeksel for finding the trick and additional info about the owner of the directory)

@synthead
Copy link

@ontherunvaro The stored data won't be lost. I upgraded and had Passman disabled 🙂

@jospoortvliet jospoortvliet changed the title Compatibility with Nextcloud 14 [$175] Compatibility with Nextcloud 14 [$190] Oct 30, 2018
@himpierre
Copy link

Is there an e.t.a. for the nextcloud 14 ready release?

@Luticus
Copy link

Luticus commented Nov 14, 2018

If you want a good work around, I just upgraded to NC14 because I've been testing the layout fix for 14 on a test server for a while now and I finally deemed it "good enough" to no longer delay my upgrade. What I did was go to my server, do the nextcloud upgrade to 14.0.3, then once everything was up-to-date, I changed to the apps directory and cloned the repo. (git clone https://github.com/nextcloud/passman.git) Then I checked out the fix branch (git checkout fix_layout_for_14). Finally I chown -R www-data.www-data passman the directory. The app works decently well, has some of the newer features, and even works with the passman browser plugin and even seems to work with passman alpha on android (which doesn't work that well anyway, alpha and all). Not as good as the finished deal, but it's a decent stopgap that will ease the pain a bit so they can take their time and get it done well.

@newhinton newhinton self-assigned this Dec 10, 2018
@newhinton newhinton added this to the nextcloud14 milestone Dec 10, 2018
@Jab2870
Copy link

Jab2870 commented Dec 11, 2018

Worth noting that NC 15 is in the wild now.

@newhinton
Copy link
Collaborator

Hey guys! We are almost ready to publish passman 2.2.0 for Nextcloud 14 and 15! The Update includes many fixes to bugs reported by you, and i also overhauled the userinterface! Stay tuned for the update in the close future!

@JB1985
Copy link

JB1985 commented Dec 19, 2018

Can you please update the AppStore? -> https://apps.nextcloud.com/apps/passman

@newhinton
Copy link
Collaborator

@everyone

We updated the app, and the github release is here: Github

Also the appstore has been updated: Appstore

All your instances should get the update notification in the next time!

@AndyScherzinger
Copy link
Member

Nice work everybody! 🚀

@happyreacer
Copy link

thanks a lot for all your work!

@Jab2870
Copy link

Jab2870 commented Dec 19, 2018

Thanks everyone for your work.

Is there anything special we need to do if we have manually modified the info.xml file?

@newhinton
Copy link
Collaborator

@Jab2870 to my knowledge, you only need to do something if you now have a version equal or higher to 2.2.1.
if you have checked out the fix_nc14 branch, you should be good to go ;)

but it may take some time that your instance registers the update

@newhinton
Copy link
Collaborator

newhinton commented Dec 19, 2018

@Jab2870

I have had problems with the update, i needed to move the git version to a different foldername to allow the proper app to install

@muckinger
Copy link

@newhinton
Thx for your work on this. But i have updated now to 2.2.1 via UI and still get the message "Server version 13 or lower is required." We are on Nextcloud 14.0.1. Any clue?

@Bubu
Copy link
Contributor

Bubu commented Dec 19, 2018 via email

@muckinger
Copy link

@Bubu Thx, works now!

@jospoortvliet jospoortvliet changed the title Compatibility with Nextcloud 14 [$190] Compatibility with Nextcloud 14 [$190 awarded] Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.