-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Nextcloud 14 [$190 awarded] #491
Comments
Nextcloud 14 was announced today and released RC, but Passman gets disabled on upgrade as of now. |
Any news on compatibility with Nextcloud 14 ? |
The plugin works of you just club-footed increase the version in the app-info file. |
Nextcloud 14 was tagged for GA release today but sadly no compatibility update to passman yet. |
Yes, to flesh out what @Heidistein said, you can force to work by modifying the file: |
Not sure if this should be here but @bstin thank you, I was about to downgrade. I do have trouble finding that file though, it seems there is no passman folder in my |
@Putdeksel You can find that file in your webroot, which is probably |
Thank you for your reply @tcassaert. It seems that because I use the Techandme.se VM and their script to update instead of the traditional method in Nextcloud, unsupported apps are removed during the update. I've tried to copy the apps/passman/ folder that I found in the backup directory, into the var/www//nextcloud/apps directory and editing the info.xml file as suggested by @bstin but without any luck. Guess I'll have to restore my backup :( Thanks anyway! |
Just to add, after I edited info.xml I had to manually enable pasmman it in the list of apps. After you restored apps/passman directory back into the correct location, do you see it in list of apps? |
@bstin |
Is there an official word from the maintainer? Will there be a nextcloud 14 version? |
Hope you have a paper copy of all your passwords in your back pocket ;) |
From how it looks now, I don't think that will happen very soon. The latest "real" commit, apart from translation commits, already goes back to the first of April 2018. |
Oh dear. I guess i have to switch to another password manager. |
Well, we could always fork it. I'd love to see this continue to be maintained. I've enjoyed the user experience so far. I'm willing to do some coding work but the maintainer seems MIA. I'm not sure it's worth putting in a PR if the maintainer won't even acknowledge stuff like this. |
It looks like @brantje is active on GitHub - even today - just not here.. |
Looks like there was an update the the web extension today, so maybe there's hope? https://github.com/nextcloud/passman-webextension |
If you need to get by, Passman still kinda works with a broken layout as-is on Nextcloud 14. Find where Passman is installed, then edit <nextcloud min-version="9" max-version="13" /> Change this to: <nextcloud min-version="9" max-version="14" /> This also seems to make the Passman API work, so the Android Passman app and the Passman extension (at least on Firefox) works just fine. By the way, it'd be great to see compatibility for Nextcloud 14, so have a $15 bounty 😉 |
Please do open a merge request! People can still apply it manually on their instances.
…On September 12, 2018 11:34:54 PM GMT+02:00, Scott Williams ***@***.***> wrote:
Well, we could always fork it. I'd love to see this continue to be
maintained. I've enjoyed the user experience so far. I'm willing to
do some coding work but the maintainer seems MIA. I'm not sure it's
worth putting in a PR if the maintainer won't even acknowledge stuff
like this.
|
Actually, I started doing the PR to find that the version has been bumped in this repo 6 months ago - it was just never pushed as a release to NextCloud: |
#497 is ultimately a blocker for this, since none of the PRs are passing tests since it's trying to test NC14 against PHP 5.x. |
It looks like all @brantje would need to do is tag a release off of master and NC14 would work again without the hack. |
Hello, I've also changed my version number in the file and was able to enable back the app in the admin panel. Anyone got the same problem ? Cheers |
@glukose I used install from Git instructions, works well without editing anything. Nevertheless I put some money in the bountysource, I hope it will motivate developers (@brantje ?) to continue & debug this useful app :) |
Hi @glukose I have not had that problem. My password works, fields are fine, and Firefox extension works. For reference here is a listing of all files under my
Regards Files: |
Just to keep the people over here updated: it seems that some comments were a bit rougher than expected and we realized that we have a common goal. It seems that @newhinton will help @brantje and @animalillo to get Passman compatible with Nextcloud 14 within the near future. Please also don't judge people too fast on the comments. Sometimes the feelings behind the words in here just get interpret the wrong way. We had a chat in the telegram group to exchange a bit more the feelings of each other. It's just hard to communicate always on point without leaving room for misunderstandings. Respect each other and be kind to each other. ❤️ |
Just wanna say thank you for the project @brantje and @animalillo for passman. |
I think the baby grew up much faster than anticipated. It still needs nurturing and governance by more than one person, or it will die / fork. Edit: clarified last paragraph, I meant to oppose single-dev control. |
The app isn't controlled by one person, it's controlled by two, now possibly three. I think we all need to take a step back and realize that pissing off the developers will not get your app updated faster. I completely understand how it is to develop something or create something and give it away for free only to have people turn around and get all demanding with it. I too am frustrated that I'm stuck on Nextcloud 13 until this app is updated for 14, but that only goes to show how important this app is. We need to understand that these guys are not paid developers, they are providing a free service. In the past the guys here have been really great and even implemented a fantastic feature I requested (vault destruction requests). While I do wish they would monitor github a bit better (that's where people generally file bug reports) and let us know they are still planning the keep the app alive, I'm certainly not going to demand anything. If you want the app done faster, increase the bounty, offer a pull request, or offer some other sort of help. Otherwise, do what I'm doing: wait patiently. |
So... apparently this needs to be said among some voices. Thank you Devs! Really; I like what you have built and look forward towards its continued development. I do have a password that I would like to get out of my vault soon, but it isn't dire that I get it right away (I would do the force install if it was). I can't am not an expert in what you have programmed, so, I am not able to contribute in way of code. Either way, I do hope that my thanks is good enough. P.S. to the others. Don't piss off the guys that make the program that you put your passwords into, lol. |
Question: if I upgraded my Nextcloud version to 14, and passman was disabled, is the stored data now lost? |
No. If you updated Nextcloud and want to see your data anyway, you can do the steps that were mentionned earlier. Note: This is a temporary fix while waiting for the real update of the app. Passman will have some display glitches but will work anyway. Modify the file <nextcloud min-version="9" max-version="13" /> To <nextcloud min-version="9" max-version="14" />
Additionally you may check the permissions (and owner) of the The next step is to go to your nextcloud instance, connect, go the your apps and enable Passman again. (Credits to @bstin and @Putdeksel for finding the trick and additional info about the owner of the directory) |
@ontherunvaro The stored data won't be lost. I upgraded and had Passman disabled 🙂 |
Is there an e.t.a. for the nextcloud 14 ready release? |
If you want a good work around, I just upgraded to NC14 because I've been testing the layout fix for 14 on a test server for a while now and I finally deemed it "good enough" to no longer delay my upgrade. What I did was go to my server, do the nextcloud upgrade to 14.0.3, then once everything was up-to-date, I changed to the apps directory and cloned the repo. (git clone https://github.com/nextcloud/passman.git) Then I checked out the fix branch (git checkout fix_layout_for_14). Finally I chown -R www-data.www-data passman the directory. The app works decently well, has some of the newer features, and even works with the passman browser plugin and even seems to work with passman alpha on android (which doesn't work that well anyway, alpha and all). Not as good as the finished deal, but it's a decent stopgap that will ease the pain a bit so they can take their time and get it done well. |
Worth noting that NC 15 is in the wild now. |
Hey guys! We are almost ready to publish passman 2.2.0 for Nextcloud 14 and 15! The Update includes many fixes to bugs reported by you, and i also overhauled the userinterface! Stay tuned for the update in the close future! |
Can you please update the AppStore? -> https://apps.nextcloud.com/apps/passman |
Nice work everybody! 🚀 |
thanks a lot for all your work! |
Thanks everyone for your work. Is there anything special we need to do if we have manually modified the |
@Jab2870 to my knowledge, you only need to do something if you now have a version equal or higher to 2.2.1. but it may take some time that your instance registers the update |
I have had problems with the update, i needed to move the git version to a different foldername to allow the proper app to install |
@newhinton |
Try to force refresh the page in your browser. I've seen this happening with other apps.
…On December 19, 2018 5:06:38 PM GMT+01:00, Muckinger ***@***.***> wrote:
@newhinton
Thx for your work on this. But i have updated now to 2.2.1 via UI and
still get the message "Server version 13 or lower is required." We are
on Nextcloud 14.0.1. Any clue?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#491 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
@Bubu Thx, works now! |
Hi @brantje,
as you may have already seen, we have entered the beta phase for the release of Nextcloud 14. We try to keep up compatibility with older apps, but in some cases apps need some adjustments to properly work on new Nextcloud releases. With Nextcloud 14 there have been quite some changes in that regard:
You can find a list of all critical changes for app developers and admins at nextcloud/server#7827 You can run
occ app:check-code
to validate that there are no issues with deprecated or private message calls.One critical change is the overall restructuring of the main template (nextcloud/server#9982) that might require some adjustments in your app.
We would be very pleased if you can make your app compatible with Nextcloud 14 and release a new version to the app store, so that users can properly test it and the upgrade experience to Nextcloud 14 will be even better than before.
Feel free to ask, if you have any questions regarding making your app compatible with Nextcloud 14.
Thanks for being part of the Nextcloud community and for all the effort you put into providing this app 🚀
Btw. you might have seen that starting August 25, the Nextcloud Conference takes place at the familiar TU Berlin. (https://nextcloud.com/conf/)! We'd like all contributors to be there and that most certainly includes you. You might already have registered but if you haven't - please consider joining us!
The $190 bounty on this issue has been claimed at Bountysource.
The text was updated successfully, but these errors were encountered: