-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix NC16 compatibility #575
Conversation
Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>
this is great! However, i cannot create a "proper" release, with an update for nextcloud But: i will test this, and merge it if it is working as intended If i have not done so by sunday evening, feel free to push ;) |
Can you publish a new release at least on the Github releases page so there is at least an updated package available? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure which kind of side effects could this have on the app, but i guess we need to get the app working on nc16 so i'm aproving this merge request
@Bubu I am sorry to inform you that i need you to recreate this pull request. It was not signed, and i overlooked that it was not. We require you to sign this before we can merge it to the master branch. I would still like to include your code in passman, could you recreate the pr and sign the code beforehand? That would be very helpful! Sorry for the inconvenience! |
It was actually. (Not in the first iteration but I force-pushed to this merge request after the bot told me it needed to be signed.) (And I actually wondered at that time, can a contribution that solely removes code actually be under copyright? 🤔 ) |
This reverts commit dba146f.
Caveat: I've no idea if that is the right fix. All I can say is that I'm running this in production for a few weeks now and no-one complained that passman isn't working yet.