Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NC16 compatibility #575

Merged
merged 1 commit into from
May 12, 2019
Merged

fix NC16 compatibility #575

merged 1 commit into from
May 12, 2019

Conversation

Bubu
Copy link
Contributor

@Bubu Bubu commented May 8, 2019

Caveat: I've no idea if that is the right fix. All I can say is that I'm running this in production for a few weeks now and no-one complained that passman isn't working yet.

Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>
@newhinton
Copy link
Collaborator

@Bubu

this is great! However, i cannot create a "proper" release, with an update for nextcloud

But: i will test this, and merge it if it is working as intended

If i have not done so by sunday evening, feel free to push ;)

@e-alfred
Copy link

e-alfred commented May 8, 2019

this is great! However, i cannot create a "proper" release, with an update for nextcloud

Can you publish a new release at least on the Github releases page so there is at least an updated package available?

Copy link
Collaborator

@animalillo animalillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure which kind of side effects could this have on the app, but i guess we need to get the app working on nc16 so i'm aproving this merge request

@newhinton newhinton merged commit 9e6673d into nextcloud:master May 12, 2019
@ghost ghost removed the in progress label May 12, 2019
newhinton added a commit that referenced this pull request May 13, 2019
This reverts commit 9e6673d, reversing
changes made to 387bd36.
@newhinton
Copy link
Collaborator

newhinton commented May 13, 2019

@Bubu I am sorry to inform you that i need you to recreate this pull request. It was not signed, and i overlooked that it was not. We require you to sign this before we can merge it to the master branch. I would still like to include your code in passman, could you recreate the pr and sign the code beforehand? That would be very helpful! Sorry for the inconvenience!

@Bubu
Copy link
Contributor Author

Bubu commented May 13, 2019

It was not signed,

It was actually. (Not in the first iteration but I force-pushed to this merge request after the bot told me it needed to be signed.)

(And I actually wondered at that time, can a contribution that solely removes code actually be under copyright? 🤔 )

@Bubu Bubu mentioned this pull request May 13, 2019
newhinton added a commit that referenced this pull request May 13, 2019
fix NC16 compatibility

closes #575 
closes #569
animalillo added a commit that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants