Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password expiration support #101

Merged
merged 3 commits into from
Apr 20, 2020
Merged

password expiration support #101

merged 3 commits into from
Apr 20, 2020

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Apr 7, 2020

My straight forward attempt is here to check the password validity after the login succeeded against the backend. Only in that case we certainly know, who the users is (not just the loginname) and can be certain that the password used to be right. This avoids that information is leaked to the outside (user enumeration? chance for social engineering?), although it comes at costs, that already postLogin events were done by other apps (for instance, the lastLogin timestamp is already set).

We could act in the BeforeUserLoggedInEvent event, with the constraints named above, and need guessing over the user id (we have mechanisms). I tend to change it thereto.

  • last login might be updated despite rejected login
  • error page is unfriendly (best message with login mask) (server issue)
  • notification couple days advance (perhaps separate PR?)
  • take out users from foreign backends
  • extends tests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
externals have their mechanisms

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
Copy link
Member Author

blizzz commented Apr 9, 2020

This avoids that information is leaked to the outside (user enumeration? chance for social engineering?), although it comes at costs, that already postLogin events were done by other apps (for instance, the lastLogin timestamp is already set).

We could act in the BeforeUserLoggedInEvent event, with the constraints named above, and need guessing over the user id (we have mechanisms). I tend to change it thereto.

I changed it now to the pre-login event, but that's in a single commit. @rullzer what's your opinion on it?

@blizzz blizzz marked this pull request as ready for review April 9, 2020 20:36
This was referenced Apr 15, 2020
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Lets do this

@blizzz blizzz merged commit 16d5a20 into master Apr 20, 2020
@blizzz blizzz deleted the enh/noid/password-expiry branch April 20, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants