Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FaceCovers: Hide first description line if there's no face title #1241

Merged
merged 1 commit into from
Sep 14, 2022
Merged

FaceCovers: Hide first description line if there's no face title #1241

merged 1 commit into from
Sep 14, 2022

Conversation

marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Sep 14, 2022 •
edited
Loading

image

@jancborchardt
Copy link
Member

Could you show how it looks like with 1 person actually having a name set? It would be good if the text baseline is the same, no matter if it’s a name or a "x photos" line.

(I am thinking that probably the "x photos" lines are a bit further up cause they are smaller, so would be nice to align them.)

@marcelklehr
Copy link
Member Author

marcelklehr commented Sep 14, 2022 •
edited
Loading

before after
image image

jancborchardt
jancborchardt approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! :)

@marcelklehr marcelklehr force-pushed the fix/hide-empty-face-title branch 2 times, most recently from 579cca8 to 59c71ae Compare September 14, 2022 12:36
@marcelklehr
Copy link
Member Author

/compile amend /js

@marcelklehr
Copy link
Member Author

/compile amend /js

@marcelklehr @nextcloud-command
FaceCovers: Hide first description line if there's no face title
0d42e71 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@marcelklehr marcelklehr merged commit ac8c298 into master Sep 14, 2022
@marcelklehr marcelklehr deleted the fix/hide-empty-face-title branch September 14, 2022 13:16
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelklehr @jancborchardt