Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(faces): Implement UnassignedFaces view #1832

Merged
merged 2 commits into from Jun 5, 2023

Conversation

marcelklehr
Copy link
Member

Screenshot from 2023-05-28 15-23-05
Screenshot from 2023-05-28 15-22-54

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr added the 3. to review Waiting for reviews label May 28, 2023
this.loadingFiles = true

let { data: fetchedFiles } = await client.getDirectoryContents(
`/recognize/${getCurrentUser()?.uid}/unassigned-faces`,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This endpoint will be available starting in recognize v4.2.0

marcelklehr added a commit to nextcloud/recognize that referenced this pull request May 28, 2023
fixes #442

also see nextcloud/photos#1832

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woow, how cool is that

@marcelklehr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@marcelklehr
Copy link
Member Author

marcelklehr commented May 30, 2023

Block fixup and squash commits (pull_request) action broke:

Docker build failed with exit code 1

@marcelklehr
Copy link
Member Author

Should be good to merge

@marcelklehr marcelklehr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 30, 2023
@marcelklehr
Copy link
Member Author

Could you take a look at this @artonge ?

@artonge artonge merged commit e6ea82d into master Jun 5, 2023
23 checks passed
@artonge artonge deleted the enhancement/unassigned-faces branch June 5, 2023 16:06
@marcelklehr
Copy link
Member Author

🎉 thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants