Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faces with cluster_id NULL #442

Closed
illnesse opened this issue Oct 31, 2022 · 7 comments · Fixed by #866
Closed

Faces with cluster_id NULL #442

illnesse opened this issue Oct 31, 2022 · 7 comments · Fixed by #866
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@illnesse
Copy link

What's going to happen with faces that have been removed from clusters, can we maybe get a "Unknown Person" cluster element in Photos/Memories that has all the removed and not yet assigned faces in it? (so basically all with cluster_id = NULL)

Currently if you delete a face from a cluster (remove from person) it won't show up anywhere in the UI any more, right?

@marcelklehr
Copy link
Member

Currently if you delete a face from a cluster (remove from person) it won't show up anywhere in the UI any more, right?

Yes, it's still up for grabs for the next run of the clustering algorithm in case new photos appear with that face.

@marcelklehr
Copy link
Member

can we maybe get a "Unknown Person" cluster element

What would be the use case for this, in your mind?

@illnesse
Copy link
Author

illnesse commented Nov 4, 2022

The "Unknown Person / Unassigned Faces" thing would be very useful as it would give users the ability to see which faces have been removed from existing clusters during cleanup or have not yet been clustered, so you can manually assign clusters to them.
There is currently no way to see ALL detected faces.

If i understood you right, there's also currently no way to "re-cluster" except uploading a photo with a similar face and hope recognize puts them into the same cluster?

root@nextcloud:~# mysql -e 'select count(*) from nextcloud.oc_recognize_face_detections where cluster_id is null'
+----------+
| count(*) |
+----------+
|     6231 |
+----------+
root@nextcloud:~# mysql -e 'select count(*) from nextcloud.oc_recognize_face_detections'
+----------+
| count(*) |
+----------+
|    30247 |
+----------+
root@nextcloud:~# mysql -e 'select count(*) from nextcloud.oc_recognize_face_clusters'
+----------+
| count(*) |
+----------+
|     4596 |
+----------+

I'd like to 'fix' some of these 6231 unassigned faces

@Cebrain
Copy link

Cebrain commented Nov 10, 2022

Would also like to see a feature for the removed and unassigned faces.

@bsaggy
Copy link

bsaggy commented Jan 2, 2023

It would be helpful to keep state of people that have been Removed from a cluster and also clusters that have been deleted (maybe soft delete and just hide instead, with the option to view 'hidden' clusters).

There are times when I toggle off and on the Face Recognition feature and in my brief testing this seems to re-find these faces and recreate the deleted clusters.

If a face is Removed from Person, perhaps it could be given a status that prevents it from being added back to that same person.

If a cluster is removed, it would be beneficial to maintain that cluster as hidden so that new images that would get added to that cluster are indeed added to it instead of generating a new cluster. This also then may benefit from a 'review / approve' process to be sure that unintended faces/images aren't added to hidden clusters without ever knowing about it.

Edit: 11k/21k detected faces in my instance are clustered as NULL.

@chrissi5120
Copy link

What would i have to do, to get my ~10k NULL-cluster faces back in queue for reprocessing without nuking anything else?

I often used "remove from person" or even "remove person" to get rid und cluttered/unorganised stuff and continued to clean out the good clusters.

@marcelklehr marcelklehr added the good first issue Good for newcomers label May 19, 2023
@marcelklehr
Copy link
Member

get my ~10k NULL-cluster faces back in queue for reprocessing without nuking anything else?

They are automatically thrown into the mix whenever a clustering run is done.

marcelklehr added a commit that referenced this issue May 28, 2023
fixes #442

also see nextcloud/photos#1832

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants