Merge pull request #3091 from nextcloud/publicUsername-performance-fix

improve validatePublicUsername() performance
nextcloud · Sep 27, 2023 · 4f32195 · 4f32195
2 parents c3c7f20 + 6169251
commit 4f32195
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/Service/SystemService.php b/lib/Service/SystemService.php
@@ -145,8 +145,9 @@ public function validatePublicUsername(string $userName, Share $share): bool {
 			throw new InvalidUsernameException;
 		}
 
-		// get all groups
-		foreach (Group::search() as $group) {
+		// get all groups, that include the requested username in their gid
+		// or displayname and check if any match completely
+		foreach (Group::search($userName) as $group) {
 			if ($userName === strtolower(trim($group->getId()))
 				|| $userName === strtolower(trim($group->getDisplayName()))) {
 				throw new InvalidUsernameException;