Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switchin from scss to css. #250

Closed
dartcafe opened this issue Nov 21, 2017 · 7 comments
Closed

Switchin from scss to css. #250

dartcafe opened this issue Nov 21, 2017 · 7 comments

Comments

@dartcafe
Copy link
Collaborator

There are some issues regarding non standard installations of NC. So we should switch to css for the releases, until scss support in NC is complete for this installation variants. Additionally this issue would support NC11 and OC as well.

@dartcafe dartcafe added this to the 0.8.1 milestone Nov 21, 2017
@splitt3r
Copy link
Contributor

How do other apps like Contacts or Deck handle this problem? Sounds like a rare case 🤔 perhaps we could implment a fallback?

@dartcafe
Copy link
Collaborator Author

The problem seems to be inside the scss precompiler in NC which compiles background-image: url('../img/open-voted-vote.svg'); to background-image: url('../../../apps/polls/css/../img/open-voted-vote.svg'); pointing from the css directory.

If I compile the scss locally the precompiler leaves it untouched.

I have no idea how to have a fall back strategy. Seems, that the functions in core have to be updated. Until then, we can switch to native compiled css.

@dartcafe
Copy link
Collaborator Author

Affected issues: #200, #249 and some more remarks about that in some unusal installations (I don't find the issues or comments in PRs).

@dartcafe
Copy link
Collaborator Author

@v1r0x: We just need to eleminate the scss files from the releases.
@splitt3r Any change to have a robot which nightly compiles the css files? Maybe for some other jobs too.

@splitt3r
Copy link
Contributor

Hm i don´t think so. Perhaps Travis CI could do it but that would be a very hacky solution. Let´s wait for an answer to #249 (comment).

@splitt3r
Copy link
Contributor

splitt3r commented Nov 23, 2017

So if nextcloud/server#7257 gets merged we don´t need to switch 👍

@hanzei
Copy link

hanzei commented Nov 27, 2017

nextcloud/server#7257 is merged 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants