Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circles integration #1128

Merged
merged 65 commits into from
Oct 20, 2020
Merged

Circles integration #1128

merged 65 commits into from
Oct 20, 2020

Conversation

dartcafe
Copy link
Collaborator

@dartcafe dartcafe commented Oct 1, 2020 •
edited

fixes #204

  • Add circles to shares
  • Circles must be resolved to individual shares after adding the invitation (same method as with contact groups)
  • Added User model/class for consistent user informations
  • refactoring the invitations/shares
  • avoid double shares

The package of the current state can be found here: https://github.com/nextcloud/polls/releases/tag/1.6-circles-alpha4

@dartcafe dartcafe mentioned this pull request Oct 1, 2020
Closed
@dartcafe dartcafe self-assigned this Oct 1, 2020
@dartcafe dartcafe added this to the 1.6 milestone Oct 1, 2020
@dartcafe dartcafe requested a review from v1r0x October 18, 2020 09:15
@dartcafe dartcafe mentioned this pull request Oct 18, 2020
Merged
@dartcafe dartcafe merged commit 5eab9ab into master Oct 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the circles-integration branch October 20, 2020 11:44
@dartcafe dartcafe mentioned this pull request Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1r0x v1r0x Awaiting requested review from v1r0x

Assignees

@dartcafe dartcafe

Labels
3. to review enhancement
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

[Feature Request] Is integration with circles possible?
1 participant
@dartcafe