Delete polls for deleted user #1490
Conversation
Signed-off-by: kauron <9221197+kauron@users.noreply.github.com>
Updates the requirements on [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) to permit the latest version. - [Release notes](https://github.com/sebastianbergmann/phpunit/releases) - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-9.5.md) - [Commits](sebastianbergmann/phpunit@8.5.0...9.5.2) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 3.7.0 to 3.7.2. - [Release notes](https://github.com/nextcloud/nextcloud-vue/releases) - [Changelog](https://github.com/nextcloud/nextcloud-vue/blob/master/CHANGELOG.md) - [Commits](nextcloud-libraries/nextcloud-vue@v3.7.0...v3.7.2) Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
jotoeri
force-pushed
the
enh/user_deleted_forms
branch
from
7a44040
to
d2686c7
Compare
|
👍 That saved me some time 'cause that is still on my to do list. But so far I didn't dig into the event listner thing. Thanks. But there is a little bit to do, we have to anonymize every action of the user, but votes should still stand after the user left the system. |
|
Yeah, i don't know which data you store additionally, but for forms i now left the submissions as is, with the thought that submissions, also in connection to a user-name, are 'property' of the form-owner once submitted. But that's indeed discussable and needs some handling of e.g. the DisplayName if a user can not be found anymore. |
Signed-off-by: dartcafe <github@dartcafe.de>
enhanced error handling in watchPolls
some more fixes after testing
fix detectColorScheme
Signed-off-by: dartcafe <github@dartcafe.de>
|
I will complete this after 1.8 is out (estimated for Saturday). |
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Some minor design fixes
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
…into redesign/comments Signed-off-by: dartcafe <github@dartcafe.de>
redesign comments list
Signed-off-by: dartcafe <github@dartcafe.de>
Print polls table
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
…/polls into pr-1490/nextcloud/enh/user_deleted_forms Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
|
I did a rebase and switched the logic to delete via sql. |
|
Just that doing it synchronously slows down the user-deletion process... So if several apps insert their job synchronously that can become quite annoying. So afaik such things should always be done asynchronously. Iirc there also was some discussion on that on the community-chat somehwen... |
|
I see. I come over it, because the user gets deleted and his/her polls are still available with an invalid owner. This could confuse other users and looks like a bug. |
|
Well typically cron-jobs are run quite often (each five minutes typ. with cron?)... So i don't think that should be too much of a problem... 🤷♂️ 😉 |
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
|
Finished the PR with deleting
The userId in votes, comments and options will get renamed to a deleted status, to avoid changing poll options and results. |
Hey @dartcafe,
this is a first step to delete a users polls after the user got deleted.
I recently implemented this for forms and as i originally realised this for polls on the forum and having nextcloud/forms#274 in mind, i thought why not just pushing the same here. 😉
However:
$this->pollService->delete($poll->getId());really deletes all information including options and votes for a poll. Probably somewhere is another procedure to delete all of that?Unfortunately it's not just straight forward for me, so i'd need to dig deeper into the whole app. So if you want to use this part, just take it over (as far as i see, only the effective internal delete-action has to be fixed now). If you have too much other stuff around or don't want this, just close this PR. 😉
Greets,
Jonas