Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoarchive closed polls #1938

Merged
merged 6 commits into from
Sep 10, 2021
Merged

Autoarchive closed polls #1938

merged 6 commits into from
Sep 10, 2021

Conversation

dartcafe
Copy link
Collaborator

@dartcafe dartcafe commented Sep 6, 2021

Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe added this to the 3.2 milestone Sep 6, 2021
@dartcafe dartcafe added this to In progress in Administrative Settings via automation Sep 6, 2021
@dartcafe dartcafe added this to In progress in Poll management via automation Sep 6, 2021
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Copy link
Contributor

@Valdnet Valdnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for setting the number of days to archive after polls is closed, my suggestion to change is more understandable.

{{ t('polls', 'Archive closed polls automatically') }}
</CheckboxRadioSwitch>
<div v-if="autoArchive" class="settings_details">
<span>{{ t('polls', 'Days after closing, the polls shall be archived:') }}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<span>{{ t('polls', 'Days after closing, the polls shall be archived:') }}</span>
<span>{{ t('polls', 'After how many days are the closed polls to be archived:') }}</span>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh. Wrong button. This wording sounds like a question.

I would say this sounds like a question.

Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@dartcafe dartcafe merged commit 41606b1 into master Sep 10, 2021
Administrative Settings automation moved this from In progress to Done Sep 10, 2021
Poll management automation moved this from In progress to Done Sep 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/autoarchive branch September 10, 2021 06:59
@dartcafe dartcafe mentioned this pull request Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Automatically archive polls that have been closed some time ago (Additional feature to #524)
2 participants