Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a reminder job configurable per poll #2039

Merged
merged 8 commits into from
Oct 27, 2021
Merged

Conversation

dartcafe
Copy link
Collaborator

@dartcafe dartcafe commented Oct 17, 2021

Added an autoreminder, which can be activated in date polls and in polls, where an expiration date is set.

The automatic reminder is sent to all shares via email, triggerd by cron

For polls with expiration

  • 48 hours before the expiration date, if the poll is created more than 5 days before the expiration.
  • 36 hours before the expiration date, if the poll is created more than 2 and less than 5 days before the expiration.

For date polls without expiration

  • 48 hours before the first date option, if the poll is created more than 5 days before the expiration.
  • 36 hours before the first date option, if the poll is created more than 2 and less than 5 days before the expiration.

No reminder is sent

  • for text polls without expiration.
  • for polls created less than 2 days before the expiration
  • if a share already got a reminder (no matter, if the expiration date got changed)
  • if the poll is already closed

relates #1305
fixes #656

Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe added this to the 3.4 milestone Oct 17, 2021
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
This reverts commit 6fa7531.
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe merged commit 7a7c503 into master Oct 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/auto-reminder branch October 27, 2021 07:14
@joesch2
Copy link

joesch2 commented Jan 4, 2022

In my opinion, it would also be useful to only remind those participants who have not yet voted.

@dartcafe
Copy link
Collaborator Author

dartcafe commented Jan 4, 2022

How can we determine, who has NOT voted if he is not invited?

@joesch2
Copy link

joesch2 commented Jan 4, 2022

You're right ;-) I put it differently:
To send an email, I need an email address. If someone does not vote anonymously, the system knows the user account and their email address. No notification should be sent to them if the vote has already taken place. If the user voted anonymously, it is not possible to make this distinction.

@dartcafe
Copy link
Collaborator Author

dartcafe commented Jan 4, 2022

What is missing, is sending reminders to people which did vote, but are not invited. This is on the list and will come later.

But for the future: Please add a new issue rather than commenting in closed issues, because these comments may be overseen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadline / Reminder support
2 participants