Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change watch #2624

Merged
merged 75 commits into from Nov 1, 2022
Merged

Change watch #2624

merged 75 commits into from Nov 1, 2022

Conversation

dartcafe
Copy link
Collaborator

@dartcafe dartcafe commented Oct 11, 2022 •
edited

should also fix #2582 and #2623

  • changing watch to avoid requests, if window is in background
  • overwork of the wtch functionality (should no prevent endless loops like in Thousands of requests per second, is this expected? #2582)
  • generate a unique clientId for polls, to avoid unnecessary requests from the watch caused by the client itself

@dartcafe
[WIP] Change watch
6e690ba 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe marked this pull request as draft October 11, 2022 08:50
@dartcafe dartcafe self-assigned this Oct 11, 2022
nextcloud-bot and others added 24 commits October 12, 2022 02:43
@nextcloud-bot
[tx-robot] updated from transifex
98fc278 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
@dependabot
Bump @nextcloud/vue from 7.0.0-beta.7 to 7.0.0
8fb349e 
Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 7.0.0-beta.7 to 7.0.0.
- [Release notes](https://github.com/nextcloud/nextcloud-vue/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-vue/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-vue@v7.0.0-beta.7...v7.0.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/vue"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Merge pull request #2629 from nextcloud/dependabot/npm_and_yarn/nextc…
e5cbe31 
…loud/vue-7.0.0
@nextcloud-bot
[tx-robot] updated from transifex
c922e50 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
@dartcafe
changelog
b568e84
@dartcafe
7.0.0
7f055f2
@dartcafe
4.0.0
49cb77c
@dartcafe
fix version info
83334f9
@nextcloud-bot
[tx-robot] updated from transifex
f261a5d 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
@dartcafe
new screenshots
f30e27b
@dartcafe
fix screenshot
6e22c34
@dartcafe
fix overview
99efde8
@dartcafe
bigger canvas for appstore
bf1645a
@dartcafe
optimize screenshots for appstore
bce6fdd
@dartcafe
Update README.md
6da43cd 
Signed-off-by: René Gieling <github@dartcafe.de>
@nextcloud-bot
[tx-robot] updated from transifex
e72a322 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
@dependabot
Bump @nextcloud/stylelint-config from 2.2.0 to 2.3.0
51bf33c 
Bumps [@nextcloud/stylelint-config](https://github.com/nextcloud/stylelint-config) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/nextcloud/stylelint-config/releases)
- [Changelog](https://github.com/nextcloud/stylelint-config/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/stylelint-config@v2.2.0...v2.3.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/stylelint-config"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump @nextcloud/vue from 7.0.0 to 7.0.1
f4d9e66 
Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 7.0.0 to 7.0.1.
- [Release notes](https://github.com/nextcloud/nextcloud-vue/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-vue/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-vue@v7.0.0...v7.0.1)

---
updated-dependencies:
- dependency-name: "@nextcloud/vue"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dartcafe
Merge pull request #2634 from nextcloud/dependabot/npm_and_yarn/nextc…
e577413 
…loud/vue-7.0.1

Bump @nextcloud/vue from 7.0.0 to 7.0.1
@dartcafe
Merge pull request #2631 from nextcloud/dependabot/npm_and_yarn/nextc…
8967c91 
…loud/stylelint-config-2.3.0

Bump @nextcloud/stylelint-config from 2.2.0 to 2.3.0
@nextcloud-bot
[tx-robot] updated from transifex
4c248cd 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
@dartcafe
replace deprecated css variables
327f08c 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
try define postgres version
463cbc6 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
typo
de99e8b 
Signed-off-by: dartcafe <github@dartcafe.de>
nextcloud-bot and others added 20 commits October 27, 2022 02:42
@nextcloud-bot
[tx-robot] updated from transifex
b5dd6ae 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
@dartcafe
Merge pull request #2645 from Tiller/master
5f0ee83 
Dashboard widget to list relevant polls
@dartcafe
changelog
1f0bf8b 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
fix dashboard widged icons
8bc1f3e 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
tidy icons
f0324dd 
Signed-off-by: dartcafe <github@dartcafe.de>
@nextcloud-bot
[tx-robot] updated from transifex
2b59b5f 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
@dartcafe
remove orphaned icons
e102bf7 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
rename dashboard source
bcae6a7 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
replace ncAvatar's icon class with mdIcons
05a67e3 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
Merge pull request #2648 from nextcloud/ref/tidy-icons
891ab38 
Ref/tidy-icons
@dartcafe
replace ncAvatar's icon class with mdIcons
f4e67b5 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
Merge branch 'enh/avatar-md-icons' of https://github.com/nextcloud/polls
99719c3 
 into enh/avatar-md-icons

Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
final tidy
250124a 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
Merge pull request #2649 from nextcloud/enh/avatar-md-icons
352d4d0 
replace ncAvatar's icon class with mdIcons
@dartcafe
[WIP] Change watch
f0bd538 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
tidy watchPolls
8e11c14 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
Merge branch 'enh/watch' of https://github.com/nextcloud/polls into e…
82584c1 
…nh/watch

Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
add session_id to watch table
0ace682 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
fix update watch and hash sessionId
cba2cca 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
add a client id to request headers
e12045a 
Signed-off-by: dartcafe <github@dartcafe.de>
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 30, 2022
View reviewed changes
src/js/helpers/AxiosDefault.js
*
*/

const clientSessionId = Math.random().toString(36).substring(2)

Check failure

Code scanning / CodeQL

Insecure randomness

This security context depends on a cryptographically insecure random number at [Math.random()](1).
@dartcafe
cs-fix
f8f8002 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
identify client with clientId instead of sessionId
4ea8177 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
use session_id as fallback
3b69a3d 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
fixes
c130681 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
fix
456ae89 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
Aaaand fix
cea9ec8 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe merged commit 8df58e6 into master Nov 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/watch branch November 1, 2022 20:27
@dartcafe dartcafe linked an issue Nov 2, 2022 that may be closed by this pull request
Frontend: Tab Content sometimes not up to date #2623
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dartcafe dartcafe

Labels
4. to release enhancement UX
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Frontend: Tab Content sometimes not up to date Thousands of requests per second, is this expected?
2 participants
@dartcafe @nextcloud-bot