Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revoke shares instead of deleting #3096

Merged
merged 6 commits into from Oct 3, 2023
Merged

revoke shares instead of deleting #3096

merged 6 commits into from Oct 3, 2023

Conversation

dartcafe
Copy link
Collaborator

@dartcafe dartcafe commented Oct 2, 2023

Changed the deletion of shares

  • shares without votes get deleted imediately (without the timer)
  • shares with votes can be revoked, so that the sharee is still able to view the results, but any other interaction is denied.
  • revoked shares can be reactivated
  • admin rights are also withdrawn, if a share with admin rights for the poll gets revoked
  • deleting revoked shares will also remove the sharees votes
  • refactored the acl to respect the changes (further optimizations in another pr)

todo:

  • delete votes when deleting revoked shares

Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe added this to the 5.4 milestone Oct 3, 2023
@dartcafe dartcafe merged commit db9295e into master Oct 3, 2023
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enh/revoke-shares branch October 3, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant