Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4.0-beta5] Changed revoking to locking #3109

Merged
merged 3 commits into from Oct 15, 2023
Merged

Conversation

dartcafe
Copy link
Collaborator

  • The terms have been changed from revoked to locked. It is a simple and precise term.
    disabled clashes with disabled states of components in the code and would cause more work.
    activated would possibly need more information, because there are no actions and could be misinterpreted.
  • The database schema and the usage of the term locked is used consistently in the code instead of revoked
  • Locking/unlocking is now possible for all shares, no matter if it is a public share or if the user has voted or not
  • The lock action has been moved to the context menu of the share and deletion of shares has returned to all shares.
  • Users of locked shares get an information banner on the top of the poll page, that tey just have read access.

Revoking of a share instead of deleting will come back in another pr to replace the deletion counter, which is ugly IMHO.

lock share unlock share unlocked shares list user information
grafik grafik grafik grafik

Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe added this to the 5.4 milestone Oct 15, 2023
@dartcafe dartcafe changed the title Changed revoking to locking [5.4.0-beta5] Changed revoking to locking Oct 15, 2023
Signed-off-by: dartcafe <github@dartcafe.de>
@PhrozenByte
Copy link
Contributor

As I already said in #3107 (comment), looks great, thank you! 👍

Just some quick question: Do I read the code correctly that it will just drop the revoked column and add the new locked column on update from beta 3 or 4, i.e. I don't have to take care of anything and just mind that all previously revoked shares will be unlocked, correct? I'm running a poll with beta 4 in production till tomorrow, just so that I don't accidentally break anything. I'll give some feedback about the new feature tomorrow when the poll closes.

@dartcafe
Copy link
Collaborator Author

I don't have to take care of anything and just mind that all previously revoked shares will be unlocked, correct?

That is the intention and how it works here. beta6 will come later the day.

@dartcafe dartcafe merged commit c651f1c into master Oct 15, 2023
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enh/fixes-and-changes-beta5 branch October 15, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants