-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve API documentation #3455
Conversation
Awesome. Great work. Unfortunately the structures are still subject of changing. Especially the update poll method needs some more work, since I plan to change the structure and differentiate between read only properties and properties wich can be changed. |
And, it would be good if you could sign your commits. |
Give me a hint, when you are finished. And thanks a lot, there were really a lot of missing things and broken docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great so far.
Signed-off-by: Bagout <firefox.zmcgq@aleeas.com>
Signed-off-by: Bagout <firefox.zmcgq@aleeas.com>
Signed-off-by: Bagout <firefox.zmcgq@aleeas.com>
Added examples of payload and return values for public, user and email shares Signed-off-by: Bagout <firefox.zmcgq@aleeas.com>
Signed-off-by: Bagout <firefox.zmcgq@aleeas.com>
Signed-off-by: Bagout <firefox.zmcgq@aleeas.com>
Endpoints for close and reopen Meaning of a "0" expiration timestamp Signed-off-by: Bagout <firefox.zmcgq@aleeas.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: Bagout <firefox.zmcgq@aleeas.com>
Everything should be signed off now and ready to merge @dartcafe :) |
@Bagoult Ah. And a rebase is not really necessary until you don't need the current target branch for testing your build. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Hello! I improved the documentation of the REST-API to make it easier for future users. Here is what it does:
deleted
field is now a boolean,share_api#add
endpoint was changed recently)."expire": 0
doesn't remove the current expiration date, but sets it to 0).