Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login link in public votes #857

Merged
merged 6 commits into from
Mar 2, 2020
Merged

Add login link in public votes #857

merged 6 commits into from
Mar 2, 2020

Conversation

dartcafe
Copy link
Collaborator

@dartcafe dartcafe commented Mar 1, 2020

fixes #852 See issue for screenshot.

@dartcafe dartcafe added this to the 1.4 milestone Mar 1, 2020
@dartcafe dartcafe self-assigned this Mar 1, 2020
Signed-off-by: Vinzenz Rosenkranz <vinzenz.rosenkranz@posteo.de>
@v1r0x
Copy link
Collaborator

v1r0x commented Mar 2, 2020

Your solution to generate the link didn't work for me, because my instance is running in a subfolder.
The generateUrl helper takes care of that.

@dartcafe dartcafe merged commit 12f081c into master Mar 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the loginLinkPublicVote branch March 2, 2020 17:52
@dartcafe
Copy link
Collaborator Author

dartcafe commented Mar 3, 2020

@v1r0x Ehm. I merged accidentially.

@v1r0x
Copy link
Collaborator

v1r0x commented Mar 3, 2020

But you switched to OC.generateUrl? Then I'm ok with your merge ;)

@dartcafe
Copy link
Collaborator Author

dartcafe commented Mar 3, 2020

Wasn't it your commit?
3a6e8b1

@v1r0x
Copy link
Collaborator

v1r0x commented Mar 3, 2020

You are right 😅 I thought I only suggested it :D

@dartcafe
Copy link
Collaborator Author

dartcafe commented Mar 3, 2020

No comment. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogIn Option
2 participants