-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include settings section #271
Conversation
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Sounds like a good idea. I replaced the app icon with |
okay github is broken now. It's clearly on the branch, but not in the PR view.... |
Signed-off-by: Joas Schilling <coding@schilljs.com>
303e520
to
e2f2836
Compare
Sounds good. This brings nextcloud/registration in line with most other Apps, and improves the usability. |
I will have a look with the white icon. I ise dark mode and there it looked good |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Icon color "fixed" now. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Thanks @jotoeri for the patch! |
Thanks for fixing the rest, @nickvergessen 馃槈 |
Dark mode app list fix is nextcloud/server#25655 |
I was wondering why the registration settings are a bit apart, hidden in the additional settings. Probably due to historical reasons, when it was just a few settings?
I think with this list of settings it is (meanwhile?) appropriate to create a separate section for the registration app, where it is just more within view.
Also i changed the icon now to use servers group-icon, which is used for users-settings, too. Basically, the registration belongs to users-settings imo. I just copied the svg from server, however i'm not sure, if this is ok with the license and stuff. Probably @nickvergessen can tell me?
Feedback & opposing opinions are welcome! 馃槈
Greets,
Jonas
EDIT: Just recognized with the current svg, the logo is white in the App-List, but black in Settings. If i set a black fill-color this just turns around. Any idea how to solve this? 馃槃
Before:
![grafik](https://user-images.githubusercontent.com/47433654/106764075-c2101380-6637-11eb-85b5-cb279c53316f.png)
After:
![grafik](https://user-images.githubusercontent.com/47433654/106763814-7fe6d200-6637-11eb-877c-d32cc3def01b.png)