Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include settings section #271

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Include settings section #271

merged 4 commits into from
Feb 4, 2021

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Feb 3, 2021

I was wondering why the registration settings are a bit apart, hidden in the additional settings. Probably due to historical reasons, when it was just a few settings?
I think with this list of settings it is (meanwhile?) appropriate to create a separate section for the registration app, where it is just more within view.

Also i changed the icon now to use servers group-icon, which is used for users-settings, too. Basically, the registration belongs to users-settings imo. I just copied the svg from server, however i'm not sure, if this is ok with the license and stuff. Probably @nickvergessen can tell me?

Feedback & opposing opinions are welcome! 馃槈

Greets,
Jonas

EDIT: Just recognized with the current svg, the logo is white in the App-List, but black in Settings. If i set a black fill-color this just turns around. Any idea how to solve this? 馃槃

Before:
grafik

After:
grafik

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@nickvergessen
Copy link
Member

Sounds like a good idea.

I replaced the app icon with AccountPlus of material design. I think it fits a bit better.

@nickvergessen
Copy link
Member

okay github is broken now. It's clearly on the branch, but not in the PR view....

Signed-off-by: Joas Schilling <coding@schilljs.com>
@jotoeri
Copy link
Member Author

jotoeri commented Feb 3, 2021

I think it fits a bit better.

Definitely, yes 馃憤
I just removed my icon-commit from the branch...

The icon is still white in the app-list - does that somewhen turn automatically? Or do we need to intervene there?
grafik

@Daksol
Copy link

Daksol commented Feb 3, 2021

Sounds good. This brings nextcloud/registration in line with most other Apps, and improves the usability.
So one less special case to remember to document when bringing someone up to speed as an Admin.
Thanks.

@nickvergessen
Copy link
Member

I will have a look with the white icon. I ise dark mode and there it looked good

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member

Icon color "fixed" now.
Dark mode app list is broken, but it seems to be a general issue

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member

Thanks @jotoeri for the patch!

@nickvergessen nickvergessen merged commit 42f13d6 into master Feb 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the enh/settings_section branch February 4, 2021 10:17
@jotoeri
Copy link
Member Author

jotoeri commented Feb 4, 2021

Thanks for fixing the rest, @nickvergessen 馃槈

@nickvergessen
Copy link
Member

Dark mode app list fix is nextcloud/server#25655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants