Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include settings section #271

Merged
merged 4 commits into from
Feb 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions appinfo/info.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,6 @@ This app allows users to register a new account.
</dependencies>
<settings>
<admin>OCA\Registration\Settings\RegistrationSettings</admin>
<admin-section>OCA\Registration\Settings\RegistrationSettingsSection</admin-section>
</settings>
</info>
1 change: 1 addition & 0 deletions img/app-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 1 addition & 7 deletions img/app.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions lib/Settings/RegistrationSettings.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

namespace OCA\Registration\Settings;

use OCA\Registration\AppInfo\Application;
use OCP\AppFramework\Http\TemplateResponse;
use OCP\IConfig;
use OCP\IGroupManager;
Expand All @@ -44,7 +45,6 @@ public function __construct(string $appName,
$this->appName = $appName;
$this->config = $config;
$this->groupManager = $groupManager;
$this->appName = $appName;
}

public function getForm(): TemplateResponse {
Expand Down Expand Up @@ -86,7 +86,7 @@ public function getForm(): TemplateResponse {
}

public function getSection(): string {
return 'additional';
return Application::APP_ID;
}

public function getPriority(): int {
Expand Down
77 changes: 77 additions & 0 deletions lib/Settings/RegistrationSettingsSection.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
<?php

declare(strict_types=1);

/**
* @copyright Copyright (c) 2021 Jonas Rittershofer <jotoeri@users.noreply.github.com>
*
* @author Jonas Rittershofer <jotoeri@users.noreply.github.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/

namespace OCA\Registration\Settings;

use OCA\Registration\AppInfo\Application;
use OCP\IL10N;
use OCP\IURLGenerator;
use OCP\Settings\IIconSection;

class RegistrationSettingsSection implements IIconSection {
/** @var IL10N */
private $l10n;

/** @var IURLGenerator */
private $urlGenerator;

public function __construct(IL10N $l10n, IURLGenerator $urlGenerator) {
$this->l10n = $l10n;
$this->urlGenerator = $urlGenerator;
}

/**
* Section ID to be set in Settings
* @return string
*/
public function getID(): string {
return Application::APP_ID;
}

/**
* Section Name to be displayed
* @return string
*/
public function getName(): string {
return $this->l10n->t('Registration');
}

/**
* Return Priority of section 0-100
* @return int
*/
public function getPriority(): int {
return 80;
}

/**
* Pass the relative path to the icon
* @return string
*/
public function getIcon(): string {
return $this->urlGenerator->imagePath(Application::APP_ID, 'app-dark.svg');
}
}