Show error if trying to open a file on session credential based external storage #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
added
enhancement
ChristophWurst
approved these changes
Dec 15, 2020
…nal storage Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
enh/handle-session-credentials
branch
from
3d08bf5
to
fd27586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make sure that a proper error message is shown if a document cannot be opened because the credentials to the external storage are stored in the session, which is not available for Collabora.
Requires nextcloud/server#23261 to work, but is backwards compatible to just do nothing then.
Fixes #1048