Expose session based authentication through mount point type

[juliushaertl]

With this apps can check whether an external storage mountpoint uses credentials stored in the session and can act upon that. An example scenario would be Collabora/ONLYOFFICE or the direct editing endpoint on mobile/desktop clients that cannot be used with session based auth since the session is not available in the unauthenticated requests.

Reference implementation for Collabora nextcloud/richdocuments#1178

[juliushaertl]

There seems to be some code in place where for the mount root 'external-root' is set for this, but I cannot figure out currently where. Maybe @icewind1991 knows, since this seems to be one thing that doesn't work anymore with this change.

[icewind1991]

I'm not a fan of re-using the mount point field for this, since it can cause issues for code relying on the values of that field.

Adding a separate field would be my preference

[juliushaertl]

I'm not a fan of re-using the mount point field for this, since it can cause issues for code relying on the values of that field.
Adding a separate field would be my preference

Yes, I cleaned that up now.

[juliushaertl]

🏓 for review again

[ChristophWurst]

Makes sense

[ChristophWurst]

needs rebase

[juliushaertl]

Rebased

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 633: failure

mysql8.0-php7.4

Show full log

There was 1 error:

1) OCA\DAV\Tests\unit\CardDAV\CardDavBackendTest::testMultipleUIDDenied
TypeError: Argument 2 passed to OCA\DAV\Events\AddressBookCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CardDAV/CardDavBackend.php on line 458

/drone/src/apps/dav/lib/Events/AddressBookCreatedEvent.php:51
/drone/src/apps/dav/lib/CardDAV/CardDavBackend.php:458
/drone/src/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php:400

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

integration-ldap-openldap-uid-features

• failure block could not be found - most likely this run got canceled

Show full log

+ bash tests/drone-run-integration-tests.sh || exit 0
=========================
= List of changed files =
=========================
apps/files_external/lib/Config/ConfigAdapter.php
apps/files_external/lib/Config/ExternalMountPoint.php
apps/files_external/lib/Lib/PersonalMount.php
apps/files_external/tests/PersonalMountTest.php
=========================
PHP files are modified
+ ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
Nextcloud was successfully installed
+ ./occ config:system:set redis host --value=cache
System config value redis => host set to string cache
+ ./occ config:system:set redis port --value=6379 --type=integer
System config value redis => port set to integer 6379
+ ./occ config:system:set redis timeout --value=0 --type=integer
System config value redis => timeout set to integer 0
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.local
System config value memcache.local set to string \OC\Memcache\Redis
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.distributed
PHP Warning:  Redis::connect(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /drone/src/lib/private/RedisFactory.php on line 92
An unhandled exception has been thrown:
RedisException: Redis server went away in /drone/src/lib/private/Memcache/Redis.php:55
Stack trace:
#0 /drone/src/lib/private/Memcache/Redis.php(55): Redis->get('c6bc51848682557...')
#1 /drone/src/lib/private/App/InfoParser.php(58): OC\Memcache\Redis->get('/drone/src/apps...')
#2 /drone/src/lib/private/App/AppManager.php(511): OC\App\InfoParser->parse('/drone/src/apps...')
#3 /drone/src/lib/private/legacy/OC_App.php(589): OC\App\AppManager->getAppInfo('files', false, NULL)
#4 /drone/src/lib/private/AppFramework/App.php(70): OC_App::getAppInfo('files')
#5 /drone/src/lib/private/legacy/OC_App.php(270): OC\AppFramework\App::buildAppNamespace('files')
#6 /drone/src/lib/private/AppFramework/Bootstrap/Coordinator.php(108): OC_App::registerAutoloading('files', '/drone/src/apps...')
#7 /drone/src/lib/private/AppFramework/Bootstrap/Coordinator.php(82): OC\AppFramework\Bootstrap\Coordinator->registerApps(Array)
#8 /drone/src/lib/base.php(644): OC\AppFramework\Bootstrap\Coordinator->runInitialRegistration()
#9 /drone/src/lib/base.php(1091): OC::init()
#10 /drone/src/console.php(48): require_once('/drone/src/lib/...')
#11 /drone/src/occ(11): require_once('/drone/src/cons...')
#12 {main}```
</details>

[MorrisJobke]

Code looks good 👍