Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures <iframe> contains a non-empty title attribute #1180

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Ensures <iframe> contains a non-empty title attribute #1180

merged 1 commit into from
Oct 9, 2020

Conversation

pedropintosilva
Copy link
Contributor

No description provided.

@pedropintosilva
Copy link
Contributor Author

I noticed that there is no title and was wondering if this is the way to go

juliushaertl
juliushaertl approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, doesn't hurt to have it :)

@juliushaertl juliushaertl merged commit 4b4f247 into nextcloud:master Oct 9, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedropintosilva @juliushaertl