Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the return type according to global definition #2661

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

christianlupus
Copy link
Contributor

@christianlupus christianlupus commented Dec 3, 2022

Summary

This just adds a method return type declaration to prevent errors in the console. See issue.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Fixes #2650

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus marked this pull request as draft December 3, 2022 09:17
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus marked this pull request as ready for review December 3, 2022 10:36
@juliushaertl juliushaertl merged commit 14e80c0 into master Dec 5, 2022
@juliushaertl juliushaertl deleted the fix/2650-fix-return-type branch December 5, 2022 11:20
@juliushaertl
Copy link
Member

/backport to stable25

@juliushaertl
Copy link
Member

/backport to stable24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some bugs in PHP8
2 participants