Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use new viewer api to open files again after open locally #3524

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Mar 14, 2024

Steps to reproduce:

  • Open a file in Collabora
  • Click the open locally button
  • Confirm to open locally
  • Click continue editing online

Before:

  • Nothing happened

After:

  • Properly reopens Collabora

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Mar 14, 2024
@juliushaertl
Copy link
Member Author

/backport to stable28

@juliushaertl
Copy link
Member Author

/backport to stable27

@juliushaertl
Copy link
Member Author

Cypress needs a separate fix, also fails on master

@juliushaertl juliushaertl merged commit 2115eaa into main Mar 14, 2024
42 of 44 checks passed
@juliushaertl juliushaertl deleted the fix/viewer-open-locally branch March 14, 2024 19:02
Copy link

backportbot bot commented Mar 14, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/3524/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d646f67c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3524/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/3524/stable28."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants