Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix: Close button should just exit for the edit local modal #3550

Merged
merged 1 commit into from Mar 26, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 26, 2024

This is a hotfix to avoid reopening the document if the user clicks the close button. In the old server API to open dialogs we cannot differentiate between close and the cancel action, so we use the global event object to check which one was clicked. On main (29+) this is resolved by using the spawnDialog function where we can pass our own vue component that allows us to handle this properly

Follow up fix to #3524

Steps to reproduce:

  • Open a file in Collabora
  • Click the button to open locally
  • Confirm to open locally in the first modal
  • Cancel the browser dialog to open locally
  • See the second Nextcloud dialog and press the X button to close

Before: The document reopened

After: Now the dialog is just dismissed

@backportbot backportbot bot requested a review from juliushaertl March 26, 2024 11:58
@backportbot backportbot bot added the 3. to review Ready to be reviewed label Mar 26, 2024
@backportbot backportbot bot added this to the Nextcloud 28 milestone Mar 26, 2024
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit a429dc2 into stable28 Mar 26, 2024
43 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/3549/stable28 branch March 26, 2024 17:21
@juliushaertl juliushaertl added the bug Something isn't working label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants