Skip to content

Commit

Permalink
Fixed mixed translations in sharing details
Browse files Browse the repository at this point in the history
Due to a typo in the app passed to the translation method, some
strings translations don't work.

This commit corrects the spelling `file_sharing` to `files_sharing` and
hence resolves : #40801

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
  • Loading branch information
Fenn-CS committed Oct 9, 2023
1 parent 14ed18c commit 41b9b08
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 24 deletions.
34 changes: 17 additions & 17 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
Expand Up @@ -91,17 +91,17 @@
<NcInputField v-if="isPublicShare"
:value.sync="share.label"
type="text"
:label="t('file_sharing', 'Share label')" />
:label="t('files_sharing', 'Share label')" />
<template v-if="isPublicShare">
<NcCheckboxRadioSwitch :checked.sync="isPasswordProtected" :disabled="isPasswordEnforced">
{{ t('file_sharing', 'Set password') }}
{{ t('files_sharing', 'Set password') }}
</NcCheckboxRadioSwitch>
<NcInputField v-if="isPasswordProtected"
:type="hasUnsavedPassword ? 'text' : 'password'"
:value="hasUnsavedPassword ? share.newPassword : '***************'"
:error="passwordError"
:required="isPasswordEnforced"
:label="t('file_sharing', 'Password')"
:label="t('files_sharing', 'Password')"
@update:value="onPasswordChange" />

<!-- Migrate icons and remote -> icon="icon-info"-->
Expand All @@ -124,25 +124,25 @@
:max="dateMaxEnforced"
:hide-label="true"
:disabled="isExpiryDateEnforced"
:placeholder="t('file_sharing', 'Expiration date')"
:placeholder="t('files_sharing', 'Expiration date')"
type="date"
@input="onExpirationChange" />
<NcCheckboxRadioSwitch v-if="isPublicShare"
:disabled="canChangeHideDownload"
:checked.sync="share.hideDownload"
@update:checked="queueUpdate('hideDownload')">
{{ t('file_sharing', 'Hide download') }}
{{ t('files_sharing', 'Hide download') }}
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch v-if="canTogglePasswordProtectedByTalkAvailable"
:checked.sync="isPasswordProtectedByTalk"
@update:checked="onPasswordProtectedByTalkChange">
{{ t('file_sharing', 'Video verification') }}
{{ t('files_sharing', 'Video verification') }}
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch v-if="!isPublicShare" :disabled="!canSetDownload" :checked.sync="canDownload">
{{ t('file_sharing', 'Allow download') }}
{{ t('files_sharing', 'Allow download') }}
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch :checked.sync="writeNoteToRecipientIsChecked">
{{ t('file_sharing', 'Note to recipient') }}
{{ t('files_sharing', 'Note to recipient') }}
</NcCheckboxRadioSwitch>
<template v-if="writeNoteToRecipientIsChecked">
<label for="share-note-textarea">
Expand All @@ -151,26 +151,26 @@
<textarea id="share-note-textarea" :value="share.note" @input="share.note = $event.target.value" />
</template>
<NcCheckboxRadioSwitch :checked.sync="setCustomPermissions">
{{ t('file_sharing', 'Custom permissions') }}
{{ t('files_sharing', 'Custom permissions') }}
</NcCheckboxRadioSwitch>
<section v-if="setCustomPermissions" class="custom-permissions-group">
<NcCheckboxRadioSwitch :disabled="!allowsFileDrop && share.type === SHARE_TYPES.SHARE_TYPE_LINK"
:checked.sync="hasRead">
{{ t('file_sharing', 'Read') }}
{{ t('files_sharing', 'Read') }}
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch v-if="isFolder" :disabled="!canSetCreate" :checked.sync="canCreate">
{{ t('file_sharing', 'Create') }}
{{ t('files_sharing', 'Create') }}
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch :disabled="!canSetEdit" :checked.sync="canEdit">
{{ t('file_sharing', 'Update') }}
{{ t('files_sharing', 'Update') }}
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch v-if="config.isResharingAllowed && share.type !== SHARE_TYPES.SHARE_TYPE_LINK"
:disabled="!canSetReshare"
:checked.sync="canReshare">
{{ t('file_sharing', 'Share') }}
{{ t('files_sharing', 'Share') }}
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch :disabled="!canSetDelete" :checked.sync="canDelete">
{{ t('file_sharing', 'Delete') }}
{{ t('files_sharing', 'Delete') }}
</NcCheckboxRadioSwitch>
</section>
</section>
Expand All @@ -193,7 +193,7 @@
<div class="sharingTabDetailsView__footer">
<div class="button-group">
<NcButton @click="$emit('close-sharing-details')">
{{ t('file_sharing', 'Cancel') }}
{{ t('files_sharing', 'Cancel') }}
</NcButton>
<NcButton type="primary" @click="saveShare">
{{ shareButtonText }}
Expand Down Expand Up @@ -495,9 +495,9 @@ export default {
},
shareButtonText() {
if (this.isNewShare) {
return t('file_sharing', 'Save share')
return t('files_sharing', 'Save share')
}
return t('file_sharing', 'Update share')
return t('files_sharing', 'Update share')
},
/**
Expand Down
3 changes: 3 additions & 0 deletions dist/523-523.js

Large diffs are not rendered by default.

File renamed without changes.
1 change: 1 addition & 0 deletions dist/523-523.js.map

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions dist/760-760.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/760-760.js.map

This file was deleted.

4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map

Large diffs are not rendered by default.

0 comments on commit 41b9b08

Please sign in to comment.