Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Translation mixed content in the new share menu since v27.1.1 #40801

Closed
5 of 8 tasks
davtheultimate opened this issue Oct 6, 2023 · 3 comments · Fixed by #40825
Closed
5 of 8 tasks

[Bug]: Translation mixed content in the new share menu since v27.1.1 #40801

davtheultimate opened this issue Oct 6, 2023 · 3 comments · Fixed by #40825

Comments

@davtheultimate
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

Since the update in v 27.1.1, a new menu for sharing folder or file is available. But the translations are mixed english / french at it shown on this screenshot :

image

if i edit file fr.js and fr.json from the /apps/file_sharing/l10n/

Translations are present :
server:/var/www/html/nextcloud/apps# grep -r “Note to recipient” files_sharing/l10n/fr.js | more
“Note to recipient” : “Note au destinataire”,
server:/var/www/html/nextcloud/apps# grep -r “Note to recipient” files_sharing/l10n/fr.json | more
“Note to recipient” : “Note au destinataire”,
server:/var/www/html/nextcloud/apps# grep -r “Set password” files_sharing/l10n/fr.json | more
“Set password” : “Définir un mot de passe”,
server:/var/www/html/nextcloud/apps# grep -r “Set password” files_sharing/l10n/fr.js | more
“Set password” : “Définir un mot de passe”,
server:/var/www/html/nextcloud/apps# grep -r “Hide download” files_sharing/l10n/fr.js | more
“Hide download” : “Masquer le téléchargement”,
server:/var/www/html/nextcloud/apps# grep -r “Hide download” files_sharing/l10n/fr.json | more
“Hide download” : “Masquer le téléchargement”,

Who can help me to solve this problem ?

Nextcloud version : 27.1.2
Operating system and version : Ubuntu 22.04)
Apache or nginx version : 2.4.52
PHP version : 8.2

Steps to reproduce

  1. Log in
  2. Share a file or folder with someone
  3. click Custom permissions
  4. Check the new menu and translation mixed content

Expected behavior

we want to have correct use of the selected language and not a mixed content

Installation method

None

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 22.1 to 22.2)

Are you using the Nextcloud Server Encryption module?

Encryption is Enabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@davtheultimate davtheultimate added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Oct 6, 2023
@szaimen
Copy link
Contributor

szaimen commented Oct 6, 2023

Cc @Fenn-CS

@Fenn-CS Fenn-CS self-assigned this Oct 9, 2023
@Fenn-CS Fenn-CS added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Oct 9, 2023
Fenn-CS added a commit that referenced this issue Oct 9, 2023
Due to a typo in the app passed to the translation method, some
strings translations don't work.

This commit corrects the spelling `file_sharing` to `files_sharing` and
hence resolves : #40801

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS added a commit that referenced this issue Oct 9, 2023
Due to a typo in the app passed to the translation method, some
strings translations don't work.

This commit corrects the spelling `file_sharing` to `files_sharing` and
hence resolves : #40801

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nextcloud-command pushed a commit that referenced this issue Oct 9, 2023
Due to a typo in the app passed to the translation method, some
strings translations don't work.

This commit corrects the spelling `file_sharing` to `files_sharing` and
hence resolves : #40801

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Fenn-CS added a commit that referenced this issue Oct 9, 2023
Due to a typo in the app passed to the translation method, some
strings translations don't work.

This commit corrects the spelling `file_sharing` to `files_sharing` and
hence resolves : #40801

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Fenn-CS added a commit that referenced this issue Oct 9, 2023
Due to a typo in the app passed to the translation method, some
strings translations don't work.

This commit corrects the spelling `file_sharing` to `files_sharing` and
hence resolves : #40801

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS added a commit that referenced this issue Oct 9, 2023
Due to a typo in the app passed to the translation method, some
strings translations don't work.

This commit corrects the spelling `file_sharing` to `files_sharing` and
hence resolves : #40801

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command pushed a commit that referenced this issue Oct 9, 2023
Due to a typo in the app passed to the translation method, some
strings translations don't work.

This commit corrects the spelling `file_sharing` to `files_sharing` and
hence resolves : #40801

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Fenn-CS added a commit that referenced this issue Oct 10, 2023
Due to a typo in the app passed to the translation method, some
strings translations don't work.

This commit corrects the spelling `file_sharing` to `files_sharing` and
hence resolves : #40801

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@BurtGummer
Copy link

Same problem in version 27.1.2 and the german translation:

image

@davtheultimate
Copy link
Author

One more replacement and it will be perfect. We have two checkboxes that mean the same thing.
"Autoriser le téléchargement" and "Allow Download"

image

zak39 pushed a commit to zak39/server that referenced this issue Dec 19, 2023
Due to a typo in the app passed to the translation method, some
strings translations don't work.

This commit corrects the spelling `file_sharing` to `files_sharing` and
hence resolves : nextcloud#40801

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants