Skip to content

Commit

Permalink
Move Dependencies
Browse files Browse the repository at this point in the history
Move bundled PHP libraries from
`apps/files_external/3rdparty` to `apps/files_external/vendor`

Move bundled JS dependencies from:
`core/vendor` to `core/js/vendor`
`apps/theming/js/3rdparty` to `apps/theming/js/vendor`
`apps/user_ldap/vendor` to `apps/user_ldap/js/vendor`

Signed-off-by: Christian Glombek christian.glombek@rwth-aachen.de
  • Loading branch information
LorbusChris committed Mar 22, 2018
1 parent c2b1f77 commit 653cedb
Show file tree
Hide file tree
Showing 197 changed files with 54 additions and 56 deletions.
2 changes: 1 addition & 1 deletion .bowerrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"directory": "core/vendor"
"directory": "core/js/vendor"
}
10 changes: 5 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@
!/apps/theming
!/apps/twofactor_backupcodes
!/apps/workflowengine
/apps/files_external/3rdparty/irodsphp/PHPUnitTest
/apps/files_external/3rdparty/irodsphp/web
/apps/files_external/3rdparty/irodsphp/prods/test
/apps/files_external/3rdparty/irodsphp/prods/tutorials
/apps/files_external/3rdparty/irodsphp/prods/test*
/apps/files_external/vendor/irodsphp/PHPUnitTest
/apps/files_external/vendor/irodsphp/web
/apps/files_external/vendor/irodsphp/prods/test
/apps/files_external/vendor/irodsphp/prods/tutorials
/apps/files_external/vendor/irodsphp/prods/test*
/apps/files_external/tests/config.*.php


Expand Down
3 changes: 1 addition & 2 deletions .scrutinizer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,13 @@ checks:
filter:
excluded_paths:
- '3rdparty/*'
- 'apps/*/3rdparty/*'
- 'apps/*/vendor/*'
- 'l10n/*'
- 'core/l10n/*'
- 'apps/*/l10n/*'
- 'apps/*/tests/*'
- 'lib/l10n/*'
- 'core/vendor/*'
- 'core/js/vendor/*'
- 'core/js/tests/lib/*.js'
- 'core/js/tests/specs/*.js'
- 'core/js/jquery-showpassword.js'
Expand Down
8 changes: 4 additions & 4 deletions DEPENDENCY_INFO.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
NextCloud Core Dependency Info
==============================

JavaScript libs bundled in `core/vendor/`.
JavaScript libs bundled in `core/js/vendor/`.
See the `bower.json` file in this directory.

| Library | Version | License | Comment/Patch Info (if applicable) |
Expand Down Expand Up @@ -36,21 +36,21 @@ JavaScript libs bundled in `apps/comments/js/vendor/`.
| At.js | 1.5.5 | MIT | NOTE: No bower.json file |
| Caret.js | 0.2.2 | MIT | NOTE: No bower.json file |

External PHP libs bundled in `apps/files_external/3rdparty/`.
External PHP libs bundled in `apps/files_external/vendor/`.
See the `composer.json` file in that directory.

| Library | Version | License | Comment/Patch Info (if applicable) |
| --- | --- | --- | --- |
| icewind/smb | 2.0.4 | MIT | |
| icewind/streams | 0.5.2 | MIT | |

JavaScript libs bundled in `apps/theming/js/3rdparty/`.
JavaScript libs bundled in `apps/theming/js/vendor/`.

| Library | Version | License | Comment/Patch Info (if applicable) |
| --- | --- | --- | --- |
| jscolor | 2.0.4 | GPLv3 | NOTE: No bower.json file |

JavaScript libs bundled in `apps/user_ldap/vendor/`.
JavaScript libs bundled in `apps/user_ldap/js/vendor/`.

| Library | Version | License | Comment/Patch Info (if applicable) |
| --- | --- | --- | --- |
Expand Down
2 changes: 1 addition & 1 deletion apps/comments/.bowerrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"directory": "js/vendor"
}
}
2 changes: 1 addition & 1 deletion apps/files_external/appinfo/app.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

OC::$CLASSPATH['OC_Mount_Config'] = 'files_external/lib/config.php';

require_once __DIR__ . '/../3rdparty/autoload.php';
require_once __DIR__ . '/../vendor/autoload.php';

// register Application object singleton
\OC_Mount_Config::$app = new \OCA\Files_External\AppInfo\Application();
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "files_external/3rdparty",
"description": "3rdparty components for files_external",
"name": "files_external/vendor",
"description": "Vendored PHP components for files_external",
"license": "MIT",
"config": {
"vendor-dir": ".",
Expand All @@ -12,4 +12,3 @@
"icewind/streams": "0.5.2"
}
}

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion apps/theming/templates/settings-admin.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
*
*/
script('theming', 'settings-admin');
script('theming', '3rdparty/jscolor/jscolor');
script('theming', 'vendor/jscolor/jscolor');
style('theming', 'settings-admin');
?>
<div id="theming" class="section">
Expand Down
4 changes: 2 additions & 2 deletions apps/user_ldap/js/renewPassword.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ OCA.LDAP = _.extend(OC.LDAP || {}, {

$(document).ready(function() {
$('form[name=renewpassword]').submit(OCA.LDAP.onRenewPassword);

if($('#newPassword').length) {
$('#newPassword').showPassword().keyup();
}
$('#newPassword').strengthify({
zxcvbn: OC.linkTo('core','vendor/zxcvbn/dist/zxcvbn.js'),
zxcvbn: OC.linkTo('core','js/vendor/zxcvbn/dist/zxcvbn.js'),
titles: [
t('core', 'Very weak password'),
t('core', 'Weak password'),
Expand Down
10 changes: 5 additions & 5 deletions apps/user_ldap/templates/settings.php
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
<?php

vendor_script('user_ldap', 'ui-multiselect/src/jquery.multiselect');

vendor_style('user_ldap', 'ui-multiselect/jquery.multiselect');

script('user_ldap', [
'vendor/ui-multiselect/src/jquery.multiselect',
'wizard/controller',
'wizard/configModel',
'wizard/view',
Expand Down Expand Up @@ -47,7 +44,10 @@
'wizard/wizard'
]);

style('user_ldap', 'settings');
style('user_ldap', [
'vendor/ui-multiselect/jquery.multiselect',
'settings'
]);

/** @var \OCP\IL10N $l */
/** @var array $_ */
Expand Down
4 changes: 2 additions & 2 deletions bower.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"name": "Nextcloud",
"version": "11 alpha",
"version": "14",
"homepage": "https://www.nextcloud.com",
"license": "AGPL",
"private": true,
"ignore": [
"**/.*",
"node_modules",
"bower_components",
"core/vendor",
"core/js/vendor",
"test",
"tests"
],
Expand Down
2 changes: 1 addition & 1 deletion build/.phan/config.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
'apps/federation/tests',
'apps/files/composer',
'apps/files/tests',
'apps/files_external/3rdparty',
'apps/files_external/vendor',
'apps/files_external/composer',
'apps/files_external/tests',
'apps/files_sharing/composer',
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/AppConfiguration.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
use Behat\Behat\Hook\Scope\BeforeScenarioScope;
use GuzzleHttp\Message\ResponseInterface;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

trait AppConfiguration {
/** @var string */
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/Auth.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
use GuzzleHttp\Exception\ServerException;
use GuzzleHttp\Cookie\CookieJar;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

trait Auth {
/** @var string */
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/BasicStructure.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
use GuzzleHttp\Exception\ClientException;
use Psr\Http\Message\ResponseInterface;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

trait BasicStructure {

Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/CalDavContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
*
*/

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

use GuzzleHttp\Client;
use GuzzleHttp\Message\ResponseInterface;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
use GuzzleHttp\Client;
use GuzzleHttp\Message\ResponseInterface;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

/**
* Capabilities context.
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/CardDavContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
*
*/

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

use GuzzleHttp\Client;
use GuzzleHttp\Message\ResponseInterface;
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/ChecksumsContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

use GuzzleHttp\Client;
use GuzzleHttp\Message\ResponseInterface;
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/CommandLine.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
*
*/

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

trait CommandLine {
/** @var int return code of last command */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
*
*/

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

use Behat\Behat\Hook\Scope\BeforeScenarioScope;

Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/CommentsContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
*
*/

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

class CommentsContext implements \Behat\Behat\Context\Context {
/** @var string */
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/FeatureContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
use Behat\Behat\Context\Context;
use Behat\Behat\Context\SnippetAcceptingContext;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';


/**
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/FederationContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
use GuzzleHttp\Client;
use GuzzleHttp\Message\ResponseInterface;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

/**
* Federation context.
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/FilesDropContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
use Behat\Behat\Tester\Exception\PendingException;
use GuzzleHttp\Client;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

class FilesDropContext implements Context, SnippetAcceptingContext {
use WebDav;
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/Provisioning.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
use GuzzleHttp\Client;
use GuzzleHttp\Message\ResponseInterface;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

trait Provisioning {
use BasicStructure;
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/RemoteContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

use Behat\Behat\Context\Context;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

/**
* Remote context.
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/SetupContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
*/
use Behat\Behat\Context\Context;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';


/**
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/ShareesContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
use Behat\Behat\Context\SnippetAcceptingContext;
use Psr\Http\Message\ResponseInterface;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';


/**
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/Sharing.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
use GuzzleHttp\Client;
use GuzzleHttp\Message\ResponseInterface;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';



Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/TagsContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
*
*/

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

use Behat\Gherkin\Node\TableNode;
use GuzzleHttp\Client;
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/Trashbin.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
use GuzzleHttp\Client;
use GuzzleHttp\Message\ResponseInterface;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';

/**
* Trashbin functions
Expand Down
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/WebDav.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
use Sabre\DAV\Client as SClient;
use Sabre\DAV\Xml\Property\ResourceType;

require __DIR__ . '/../../vendor/autoload.php';
require __DIR__ . '/../../js/vendor/autoload.php';


trait WebDav {
Expand Down
4 changes: 2 additions & 2 deletions build/mergejs.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
$data = json_decode(file_get_contents(__DIR__.'/../core/js/core.json'), true);
$vendors = $data['vendor'];

$vendorjs = fopen(__DIR__.'/../core/vendor/core.js', 'w');
$vendorjs = fopen(__DIR__.'/../core/js/vendor/core.js', 'w');
foreach($vendors as $vendor) {
fwrite($vendorjs, file_get_contents(__DIR__.'/../core/vendor/'.$vendor));
fwrite($vendorjs, file_get_contents(__DIR__.'/../core/js/vendor/'.$vendor));
fwrite($vendorjs, PHP_EOL);
}
fclose($vendorjs);
3 changes: 2 additions & 1 deletion core/vendor/.gitignore → core/js/vendor/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ jquery-ui/themes/ui-darkness
jquery-ui/themes/ui-lightness
jquery-ui/themes/vader
jquery-ui/ui/**
!jquery-ui/ui/minified
!jquery-ui/ui/minified/jquery-ui.custom.min.js
jquery-ui/*.json
!jquery-ui/.bower.json
Expand Down Expand Up @@ -157,7 +158,7 @@ autosize/**
!autosize/dist
!autosize/dist/autosize.min.js
!autosize/.bower.json
!autosize/LICENCE.md
!autosize/LICENSE.md

#marked
marked/bin
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
SOFTWARE.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Loading

0 comments on commit 653cedb

Please sign in to comment.