Merge pull request #22809 from nextcloud/bugfix/noid/remove-unneeded-…

…isset-check Remove unneeded isset check
nextcloud · Sep 14, 2020 · a053aa7 · a053aa7
2 parents 4c0453d + 441adaa
commit a053aa7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/private/AllConfig.php b/lib/private/AllConfig.php
@@ -317,7 +317,7 @@ public function setUserValue($userId, $appName, $key, $value, $preCondition = nu
 	 */
 	public function getUserValue($userId, $appName, $key, $default = '') {
 		$data = $this->getUserValues($userId);
-		if (isset($data[$appName]) and isset($data[$appName][$key])) {
+		if (isset($data[$appName][$key])) {
 			return $data[$appName][$key];
 		} else {
 			return $default;
@@ -355,7 +355,7 @@ public function deleteUserValue($userId, $appName, $key) {
 				'WHERE `userid` = ? AND `appid` = ? AND `configkey` = ?';
 		$this->connection->executeUpdate($sql, [$userId, $appName, $key]);
 
-		if (isset($this->userCache[$userId]) and isset($this->userCache[$userId][$appName])) {
+		if (isset($this->userCache[$userId][$appName])) {
 			unset($this->userCache[$userId][$appName][$key]);
 		}
 	}