Remove unneeded isset check #22809
Merged
Remove unneeded isset check #22809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
kesselb
approved these changes
Sep 11, 2020
| @@ -317,7 +317,7 @@ public function setUserValue($userId, $appName, $key, $value, $preCondition = nu | |||
| */ | |||
| public function getUserValue($userId, $appName, $key, $default = '') { | |||
| $data = $this->getUserValues($userId); | |||
| if (isset($data[$appName]) and isset($data[$appName][$key])) { | |||
| if (isset($data[$appName][$key])) { | |||
There was a problem hiding this comment.
return $data[$appName][$key] ?? $default;
https://3v4l.org/J6vOL should also work. But current approach is also fine.
There was a problem hiding this comment.
One step after the other.
juliushaertl
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the
andthe later part was checked anyway, but isset also works if a parent key does not exist, so removing it