Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CalDAV Mail Invitations: Bogus Invite/Accept upon deleted person #11230

Closed
labor4 opened this issue Sep 14, 2018 · 5 comments
Closed

CalDAV Mail Invitations: Bogus Invite/Accept upon deleted person #11230

labor4 opened this issue Sep 14, 2018 · 5 comments
Assignees
@brad2014
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: dav

Comments

@labor4
Copy link
Contributor

labor4 commented Sep 14, 2018 •
edited
Loading

A cosmetic issue

Steps to reproduce (I did via caldav Apple Calendar on Mac)

  1. Create Event
  2. Invite person A
    2b. Accept/Decline by that person.
  3. Delete person A

The following is what that person A gets in an email.

Expected behaviour

Just a note the person has been kicked out

Actual behaviour

The note, plus:
Additionally there are still the the "Accept" "Decline" Buttons.

Server configuration

NC 14.0.0
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #8766 (Caldav ), #9942 (Include accept / decline links in CalDAV invitation emails), #2338 (Accept calendar invitation directly in the invitation email ), #2855 (Invitation send to attendees upon calendar import (also for past events)), and #6092 (Cant delete Folder).

@MorrisJobke
Copy link
Member

cc @georgehrke

@brad2014
Copy link
Contributor

brad2014 commented Nov 7, 2018

Note: This is true for any iMip cancel message, which is not only triggered by deleting an invitee from an event, but also from deleting the event.

@brad2014
Copy link
Contributor

brad2014 commented Nov 10, 2018 •
edited
Loading

Also, the email says "The meeting <title> with <organizer> was canceled." That is not the semantics of an iTip CANCEL message. It should say that the invitation was withdrawn/canceled for the recipient (the meeting itself may or may not have been canceled, or the recipient may have been removed from the attendee list by the organizer). Also meetings are not necessarily with the organizer, they are by the organizer. Person A can organize a meeting between person B and person C.

Better: "The invitation for <title> by <organizer> has been canceled."
or maybe
"The invitation for <title> scheduled by <organizer> has been canceled."

Also, using inward (German) »guillemets« in the default English text around meeting titles is a problem, since they are not used in English. English uses super-scripted “double quotes”.

This was referenced Nov 10, 2018
Closed
Merged
@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jun 12, 2019
georgehrke pushed a commit that referenced this issue Aug 1, 2019
@georgehrke
Customize presentation of accept/decline buttons in iMip mail
d70f879 
Fix Issue #11230
Only present accept/decline button links in iMip mail for REQUEST, not CANCEL or others.

Fix Issue #12156
Implement config setting "dav.invitation_link_recipients", to control
which invitation recipients see accept/decline button links.  The
default, for public internet facing servers, is to always include
them.  For a server on a private intranet, this setting can be set
to the email addresses or email domains of users whose browsers can
access the nextcloud server referenced by those accept/decline
button links. It can also be set to "false" to exclude the links
from all requests.

Signed-off-by: Brad Rubenstein <brad@wbr.tech>
georgehrke pushed a commit that referenced this issue Aug 1, 2019
@georgehrke
Customize presentation of accept/decline buttons in iMip mail
87bf430 
Fix Issue #11230
Only present accept/decline button links in iMip mail for REQUEST, not CANCEL or others.

Fix Issue #12156
Implement config setting "dav.invitation_link_recipients", to control
which invitation recipients see accept/decline button links.  The
default, for public internet facing servers, is to always include
them.  For a server on a private intranet, this setting can be set
to the email addresses or email domains of users whose browsers can
access the nextcloud server referenced by those accept/decline
button links. It can also be set to "false" to exclude the links
from all requests.

Signed-off-by: Brad Rubenstein <brad@wbr.tech>
@georgehrke
Copy link
Member

Fixed in #12392

@brad2014 brad2014 self-assigned this Sep 11, 2019
@miaulalala miaulalala mentioned this issue Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brad2014 brad2014

Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: dav
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@MorrisJobke @georgehrke @brad2014 @skjnldsv @labor4 @nextcloud-bot