Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept calendar invitation directly in the invitation email #2338

Closed
enoch85 opened this issue Nov 25, 2016 · 44 comments · Fixed by #9942
Closed

Accept calendar invitation directly in the invitation email #2338

enoch85 opened this issue Nov 25, 2016 · 44 comments · Fixed by #9942
Assignees
Milestone

Comments

@enoch85
Copy link
Member

enoch85 commented Nov 25, 2016

In this issue I asked for better design for the emails being sent when inviting anyone to a event. This request is about the possibility to accept the invitation directly in the email, just like you can do with Google Calendar.

Right now you are presented with this (which is pretty nasty):

BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Sabre//Sabre VObject 3.5.0//EN
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VTIMEZONE
TZID:Africa/Lagos
X-LIC-LOCATION:Africa/Lagos
BEGIN:STANDARD
TZOFFSETFROM:+0100
TZOFFSETTO:+0100
TZNAME:WAT
DTSTART:19700101T000000
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
CREATED:20161125T140909
DTSTAMP:20161125T140909
LAST-MODIFIED:20161125T140909
UID:1J4UQR666RZKWYABID5AF0QKT92XM3TB6JP2D8K0NIQ2VPZM2T9
SUMMARY:Julfest jobbet
LOCATION:Kontoret
CLASS:PUBLIC
STATUS:CONFIRMED
ORGANIZER;CN=Daniel Hansson:MAILTO:daniel@techandme.se
ATTENDEE;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;CUTYPE=INDIVIDUAL;X-NC-
 GROUP-ID=0:MAILTO:daniel.hansson@orestad-linux.se
DTSTART;TZID=Africa/Lagos:20161220T160000
DTEND;TZID=Africa/Lagos:20161220T170000
END:VEVENT
END:VCALENDAR

I think it's a must have to be able to accept the invitation directly in the email especially when speaking of enterprise, how can we compete with e.g. Google otherwise?

cc @Espina2 @eppfel @jancborchardt @MorrisJobke

@joergmschulz
Copy link

joergmschulz commented Nov 27, 2016

This is a topic for the MAIL app. We can't even display all invitations, currently- @ChristophWurst and others (hopefully) are currently rethinking the display of the mails. See topic nextcloud/mail#160. Before this isn't done, we can't even think of connecting mail and calendar.
Maybe a moderator can move this topic to the mail app?

Edit: Fixed link to issue

@enoch85
Copy link
Member Author

enoch85 commented Nov 27, 2016

@joergmschulz I don't agree that this is a mail app issue. What if you are not using the mail app? This issue is about sending invitations to anyone not only people using the mail app.

Try sending an invitation to one with Google Calendar, what will they see? They will see the regular invitation with "Yes" "No" "Maybe". Haven't tried sending an invitation to someone with outlook, but I imagine it's the same. The mail app is just a client to handle the mails that you have on another server, Nextcloud is not a mail server.

@joergmschulz
Copy link

joergmschulz commented Nov 27, 2016 via email

@enoch85
Copy link
Member Author

enoch85 commented Nov 28, 2016

@joergmschulz If the reciver have Nextcloud, and using another (domainbased) email that isn't connected to a service like Google e.g. hey@example.com the only thing you the reciver will see is what I posted in my first issue. DAV must be able to somehow generate a nice invitation, or maybe it's PHP that's necesarry, idk really as I'm not a coder.

@jancborchardt
Copy link
Member

cc @nextcloud/calendar as this is probably more relevant for the folks ;)

@georgehrke georgehrke added this to the Nextcloud 12.0 milestone Dec 16, 2016
@georgehrke georgehrke self-assigned this Dec 16, 2016
@georgehrke
Copy link
Member

I'd be happy to implement the server-side logic for accepting/rejecting invitations. Although I'd appreciate help with the mail template / mail design. (cc @eppfel ;))

@jancborchardt
Copy link
Member

@georgehrke do you have any version you like most (like from Google Calendar / Inbox, or iCloud, etc)? Then we could start building it based on that layout, and improve going forward. cc @nextcloud/designers

@georgehrke
Copy link
Member

@enoch85 posted a screenshot in #2071

@skjnldsv skjnldsv changed the title [Enhancment] Accept calendar invitation directly in the invitation email [Enhancement] Accept calendar invitation directly in the invitation email Dec 18, 2016
@enoch85
Copy link
Member Author

enoch85 commented Feb 15, 2017

Ping

@warnerbryce
Copy link

warnerbryce commented Mar 22, 2017

Ping too, having the power to answer to Nextcloud' calendar invitation inside the email would be great.
This is the big last feature that miss in this calendar.

3 companies using nextcloud as a calendar server waiting for it.

I could help for testing this feature.

@georgehrke
Copy link
Member

@warnerbryce Help developing this feature would be even more appreciated ;)

@enoch85
Copy link
Member Author

enoch85 commented Mar 22, 2017

@georgehrke Give me some months, I just have to learn PHP. ;)

@eppfel
Copy link
Member

eppfel commented Mar 25, 2017

@enoch85
Copy link
Member Author

enoch85 commented Mar 25, 2017

Well, let's get this started. Just posted $50.

@enoch85
Copy link
Member Author

enoch85 commented Mar 30, 2017

Just posted $50.

Seems like it doesn't show up :/ I'll contact BountySource and make it happen.

Btw, Hackweek... Mind looking at this issue? please :)

@warnerbryce
Copy link

Posted 50$, this enhancement is really important for me.

@eppfel
Copy link
Member

eppfel commented Apr 4, 2017

So, for a start...

There is a SabreDav Plugin: http://sabre.io/dav/scheduling/
Based on the both RFCs:

So we have to implement this on the server and than edit the mail template, as far as I understand it @georgehrke ?

@georgehrke
Copy link
Member

The scheduling plugin is already enabled. ;)

We need to hook into the iTip plugin that sends the email, generate some token and write it to the database, use that token to generate a couple of links for the email.
The email needs:

  • Attend
  • does not attend
  • unsure

and we need one token per attendee

@MorrisJobke MorrisJobke changed the title [Enhancement] Accept calendar invitation directly in the invitation email Accept calendar invitation directly in the invitation email Apr 5, 2017
@enoch85
Copy link
Member Author

enoch85 commented Apr 16, 2017

Fixed the Bountsource issue so now it's $100 instead.

@warnerbryce
Copy link

Any update for this request ? It's a deal-blocking for two clients. I will increase bounty in some days so...

@georgehrke
Copy link
Member

Any update for this request ?

it's currently planned for Nextcloud 13 and I can assure you it won't come earlier, as we don't back port features to older releases.

@warnerbryce
Copy link

@labor4 I started on Owncloud from version 6, i've worked with it on aWindows Server with Wamp, an OS X Server with Server.app, an OS X Server with Mamp, and now i'm on Nextcloud on Linux/Debian.
The best options you could get to have a nice Nextcloud Server working on OS X is : (first is worst then it increase)
1 - Use OS X Server app, modify /Library/Server/Web/Config files to make Apache web server works as you want (ports, ssl, .htaccess, etc...) Use postgresql as a database and php 5.... It's really anoying to make it works but it's possible and it's long.
2 - Use OS X system with MAMP (or MAMP Pro), easier to make it work, you can choose the version of apache you want, the version of php, mysql is there too. With a little bit of practice on software, you can have a good Nextcloud Server
3 - Use a virtualisation software (VirtualBox or Parallels) install a linux distribution, install Apache/Ngnix - Mysql-MariaDB - PHP7 - Certbot(letsencrypt). It's really easy to make snapshots, backups, and support from forum.
We're quite out of topic there, if you want to discuss about that you can join me on the help.nextcloud.com forum, my name is Nemskiller.

@enoch85
Copy link
Member Author

enoch85 commented Jan 25, 2018

@warnerbryce

The best options you could get to have a nice Nextcloud Server working

...is the Nextcloud VM. ;)

@warnerbryce
Copy link

@enoch85
It’s my way or the highway.

Yeah Nextcloud VM could be really the best start for a beginner and more.

@warnerbryce
Copy link

warnerbryce commented Mar 14, 2018

Any news about this issue ? Does everything will be in the startingblocks for NC 14 ?

UP ? i hope it won't be delayed to NC 15

@warnerbryce
Copy link

Hello @georgehrke and @jospoortvliet

We have no news about this, does it will be ready for NC 14 ?

@georgehrke
Copy link
Member

@warnerbryce I will look into this in the next couple of days, don't worry 😉

@MorrisJobke
Copy link
Member

Fix is in #9942

@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 26, 2018
@georgehrke
Copy link
Member

@warnerbryce Feel free to open a follow up ticket about the enhancements you suggested in the pull-request, so they don't get lost! :)

@Luncheon3462
Copy link

@ChristophWurst @miaulalala @st3iny, please help get this fixed. When Office 365 sends calendar invitations, the snappymail nextcloud app by @the-djmaze handles them perfectly. They appear in the email message and can be added to a nextcloud calendar with one-click. Maybe this code that @the-djmaze mentioned will work? https://github.com/the-djmaze/snappymail/blob/fffc04499875531bd3dd626d01baaf7a86452cd3/plugins/nextcloud/js/message.js#L111-L179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.