Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select2 select box hard to discover #1932

Closed
nickvergessen opened this issue Oct 27, 2016 · 6 comments
Closed

Select2 select box hard to discover #1932

nickvergessen opened this issue Oct 27, 2016 · 6 comments
Labels
bug design Design, UI, UX, etc. feature: tags good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone
Nextcloud 11.0

Comments

@nickvergessen
Copy link
Member

Since the redesign of the select2 inputs ( #1780 and #1789 ), the collaborative tags dropdown is really awkward to discover:
select2-design-issue

@jancborchardt @nextcloud/designers
@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Oct 27, 2016
@jancborchardt jancborchardt added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Oct 27, 2016
Saiteja-Reddy added a commit to Saiteja-Reddy/server that referenced this issue Nov 8, 2016
@Saiteja-Reddy
Fixed issue nextcloud#1932 , added black border around input field
32625af
skjnldsv added a commit that referenced this issue Nov 8, 2016
@skjnldsv
Inputs select2 float, dropdown and border fix #1932
4a70966 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv added a commit that referenced this issue Nov 8, 2016
@skjnldsv
Inputs select2 float, dropdown and border fix #1932
d0a5fc6 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2016

Result :
2016-11-08_10-34-54

@MariusBluem
Copy link
Member

Great 🎉 ... much better now 🙈

@MariusBluem MariusBluem mentioned this issue Nov 8, 2016
Closed
@jancborchardt
Copy link
Member

@skjnldsv only one detail: The »select tag« placeholder text should be correctly left-aligned. Currently it floats in the middle.

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2016

It was like that, I figured it should stay this way. Will fix! :)

@jancborchardt
Copy link
Member

@skjnldsv can you separate it from the SCSS pull request? Because we are one week from feature freeze, it is very unlikely we will merge SCSS for Nextcloud 11. But this one is a fix we need.

(That’s why it’s always important to separate ;)

@skjnldsv
Copy link
Member

It is now. See the base scss transition #2050

skjnldsv added a commit that referenced this issue Nov 15, 2016
@skjnldsv
Fix select2 dropdown
1a33985 
Fix #1932
@skjnldsv skjnldsv mentioned this issue Nov 15, 2016
Merged
skjnldsv added a commit that referenced this issue Nov 15, 2016
@skjnldsv
Fix select2 dropdown
23a8f9c 
Fix #1932
skjnldsv added a commit that referenced this issue Nov 15, 2016
@skjnldsv
Fix select2 dropdown
2ec7e79 
Fix #1932
skjnldsv added a commit that referenced this issue Nov 17, 2016
@skjnldsv
Fix select2 dropdown
197e964 
Fix #1932
+ no result fix

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv added a commit that referenced this issue Nov 17, 2016
@skjnldsv
Fix select2 dropdown
65f98d5 
Fix #1932
+ no result fix

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv added a commit that referenced this issue Nov 18, 2016
@skjnldsv
Fix select2 dropdown
c0b376d 
Fix #1932
+ no result fix

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv mentioned this issue Dec 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug design Design, UI, UX, etc. feature: tags good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
Nextcloud 11.0
Development

No branches or pull requests
4 participants
@nickvergessen @jancborchardt @skjnldsv @MariusBluem