Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ldap css and jquery ui css fix for menu dropdown #2529

Closed
wants to merge 5 commits into from

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 6, 2016

refs: #1932 #1780 #2524

capture d ecran_2016-12-06_13-14-42

@MorrisJobke @nextcloud/designers

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug design Design, UI, UX, etc. enhancement labels Dec 6, 2016
@skjnldsv skjnldsv added this to the Nextcloud 11.0 milestone Dec 6, 2016
@mention-bot
Copy link

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @jancborchardt and @individual-it to be potential reviewers.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 6, 2016

Rebased and ready to merge! 🚀

@MorrisJobke
Copy link
Member

@blizzz Could you have a look at this?

@codecov-io
Copy link

Current coverage is 57.21% (diff: 20.00%)

Merging #2529 into master will increase coverage by <.01%

@@             master      #2529   diff @@
==========================================
  Files          1202       1202          
  Lines         72470      72466     -4   
  Methods        7365       7365          
  Messages          0          0          
  Branches       1228       1228          
==========================================
+ Hits          41463      41465     +2   
+ Misses        31007      31001     -6   
  Partials          0          0          
Diff Coverage File Path
0% apps/user_ldap/templates/part.wizard-server.php
•••••••••• 100% lib/private/legacy/template.php

Powered by Codecov. Last update b190153...f07e4a0

@blizzz
Copy link
Member

blizzz commented Dec 7, 2016

Advanced tab does not use the available space properly:

spectacle a18316

Looks good otherwise!

@LukasReschke
Copy link
Member

@skjnldsv Can we move that to 12? I'd prefer to consider 11 closed for any non-critical merges.

@skjnldsv
Copy link
Member Author

@LukasReschke If you want! :)
It'w not really a game-changing pr ;)

@blizzz blizzz modified the milestones: Nextcloud 12.0, Nextcloud 11.0 Dec 12, 2016
@LukasReschke
Copy link
Member

Ok. – Master is open again so I suppose we need to fix #2529 (comment) and then can merge this?

@skjnldsv
Copy link
Member Author

@LukasReschke Exactly. I didn't had the time yet.

@skjnldsv skjnldsv self-assigned this Dec 18, 2016
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 22, 2016
@LukasReschke
Copy link
Member

@skjnldsv Is this still interesting? If not we should probably close this 😉

@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 20, 2017

I need to rework this with the scss :)
Leave it open 🎉

@jancborchardt jancborchardt added this to the Nextcloud 13 milestone Apr 25, 2017
@jancborchardt jancborchardt removed this from the Nextcloud 12.0 milestone Apr 25, 2017
@jancborchardt
Copy link
Member

Moving to Nextcloud 13 then as we have feature freeze tomorrow. :)

@MorrisJobke
Copy link
Member

@skjnldsv I guess most of this in here was fixed by #6341 - can we close this then?

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 5, 2017

Ehheh, yes we can! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants