-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ldap css and jquery ui css fix for menu dropdown #2529
Conversation
@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @jancborchardt and @individual-it to be potential reviewers. |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
1219e52
to
f07e4a0
Compare
Rebased and ready to merge! 🚀 |
@blizzz Could you have a look at this? |
Current coverage is 57.21% (diff: 20.00%)@@ master #2529 diff @@
==========================================
Files 1202 1202
Lines 72470 72466 -4
Methods 7365 7365
Messages 0 0
Branches 1228 1228
==========================================
+ Hits 41463 41465 +2
+ Misses 31007 31001 -6
Partials 0 0
|
@skjnldsv Can we move that to 12? I'd prefer to consider 11 closed for any non-critical merges. |
@LukasReschke If you want! :) |
Ok. – Master is open again so I suppose we need to fix #2529 (comment) and then can merge this? |
@LukasReschke Exactly. I didn't had the time yet. |
@skjnldsv Is this still interesting? If not we should probably close this 😉 |
I need to rework this with the scss :) |
Moving to Nextcloud 13 then as we have feature freeze tomorrow. :) |
Ehheh, yes we can! 💪 |
refs: #1932 #1780 #2524
@MorrisJobke @nextcloud/designers