-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Cancel button when editing a user #22608
Comments
This comment has been minimized.
This comment has been minimized.
Hey can i take this 🤩? i'm new to contributions any help would be great |
@ayushkumar121 of course! go for it!! Please also read our contribution page: https://nextcloud.com/contribute |
ok, Thanks |
Hi, @ayushkumar121! Are you still working on this? I'm also interested. :-) |
@sarahyaepark you go on ahead, i'm still facing problems in setting up the dev environment 😪 |
@sarahyaepark if you have any success on setting up the dev environment, please help me so |
Hi, I am new to the open source! If no one is currently working on this issue, I would love to. I have set up the dev environment, but stuck on finding which file to work on to resolve this issue... Any guidance would be greatly appreciated!! In Progress. . . |
I have had a look at this and I think it works as intended. The button with a tick doesn't save anything if you click on it, it simply turns the user entry from an editable form back into a table row. As far as I can see, you need to save each user data field individually by clicking on the arrow button to the right of each field. Here is a screenshot that hopefully clarifies what I'm trying to convey: So it looks like you don't need to refresh the page to discard any unsaved changes - they won't be saved anyway unless you click on the arrow button or press "Enter" on the keyboard. |
One thing that could be improved is tooltips - the round "tick" button has a "Done" tooltip while the arrows don't have anything. Perhaps a tooltip with "Save" could be added to them all? |
I think the solution discussed here and what I am currently working on is to add a 'Cancel' button that will revert any changes made to an user's properties. |
That would perhaps be a bit too involved for a |
@nina-py I was not aware that the "Done" button actually does not save any changes. Still, the issue remains that once you press But to me it seems now that the missing Another example: I edit a user, change the user name, and click on In other (user) editing forms I usually see two different approaches:
I would like to suggest to change the NC user editing to the second approach. The currently used approach where one has to manually "apply" changes for every single input field by clicking the And I am not sure if a simple re-labelling or adding tooltips to buttons will actually be enough to improve this. See my example above where the |
I think there might have been a misunderstanding. I'm a new contributor looking for interesting tickets to work on, I am not defending the current UI or trying to tell people to read the manual - I have actually had to go onto the users page and try every button before I realised the original feature request makes some incorrect assumptions about how things work.
I agree with you - this is exactly how I found out the
I didn't say that it was enough - rather that it would be an incremental improvement over what is there now. But a more substantial UI change should probably be discussed with the designers - perhaps you could bring it to their attention in #22864 which is an umbrella issue for design improvements in Nextcloud 20? |
@nina-py Sorry, that was indeed a misunderstanding on my side. My apologies. You are also correct, that when writing the original feature request I missed that there already is kind of a However, this is only true for the text fields. The multi-select fields for group and group admin persist any changes immediately. Personally, I would still prefer a solution that gets rid of the But as you said, it might make sense to discuss such a change first with the nextcloud team before starting to work on it. |
I think there should be only one way to save changes and the "done" checkmark should be the way to go. Providing multiple ways could confuse the user, as it already does contributers here. I think we should remove the arrow button and instead add an x button next to the checkmark, to cancel the task. |
Thank you for clarifying. Mind if I look into that matter? |
Hi. Can I be assigned to this? I am looking for good first issues. |
@philipreimer Changes are ready for review |
How to use GitHub
Is your feature request related to a problem? Please describe.
There is no obvious intuitive way to cancel editing a user. This is confusing for first time admins.
Steps to reproduce
Now there is only the "OK" button with the check mark icon to submit your changes.
But there is no "Cancel" button to neglect your changes and go back to the original display name.
Describe the solution you'd like
Add a second button "Cancel" next to the "OK" button. Clicking the "Cancel" button should ignore (and maybe revert) any changes you have made to the user's properties and return back to displaying the user's original properties.
Describe alternatives you've considered
The only way I have found to effectively cancel editing a user was by reloading the entire page (F5).
However, that is not immediately obvious to newcomers.
Additional context
The text was updated successfully, but these errors were encountered: